From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: =?ISO-8859-1?Q?Jostein=20Kj=F8nigsen?= Newsgroups: gmane.emacs.devel Subject: Re: cl-macro-expandall symbol definition is void Date: Wed, 26 Nov 2014 09:22:47 +0100 Message-ID: <1416990167.2957718.195545937.6A058819@webmail.messagingengine.com> References: <1416950656.3560983.195379005.39E1EEFA@webmail.messagingengine.com> <8mvbm3vsii.fsf@fencepost.gnu.org> Reply-To: jostein@kjonigsen.net NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset="ISO-8859-1" Content-Transfer-Encoding: quoted-printable X-Trace: ger.gmane.org 1416990208 22663 80.91.229.3 (26 Nov 2014 08:23:28 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Wed, 26 Nov 2014 08:23:28 +0000 (UTC) Cc: emacs-devel@gnu.org To: Glenn Morris , jostein@kjonigsen.net Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Wed Nov 26 09:23:23 2014 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1XtXsf-0005hY-KB for ged-emacs-devel@m.gmane.org; Wed, 26 Nov 2014 09:23:21 +0100 Original-Received: from localhost ([::1]:60822 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XtXsf-0007xC-6S for ged-emacs-devel@m.gmane.org; Wed, 26 Nov 2014 03:23:21 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:53438) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XtXsM-0007ux-T0 for emacs-devel@gnu.org; Wed, 26 Nov 2014 03:23:06 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XtXs8-00015T-HV for emacs-devel@gnu.org; Wed, 26 Nov 2014 03:23:02 -0500 Original-Received: from out4-smtp.messagingengine.com ([66.111.4.28]:36141) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XtXs8-00015F-Cg for emacs-devel@gnu.org; Wed, 26 Nov 2014 03:22:48 -0500 Original-Received: from compute2.internal (compute2.nyi.internal [10.202.2.42]) by mailout.nyi.internal (Postfix) with ESMTP id 1A37B20526 for ; Wed, 26 Nov 2014 03:22:48 -0500 (EST) Original-Received: from web5 ([10.202.2.215]) by compute2.internal (MEProxy); Wed, 26 Nov 2014 03:22:48 -0500 DKIM-Signature: v=1; a=rsa-sha1; c=relaxed/relaxed; d= secure.kjonigsen.net; h=message-id:x-sasl-enc:from:to:cc :mime-version:content-transfer-encoding:content-type:subject :reply-to:date:in-reply-to:references; s=mesmtp; bh=NHlsZrskO1kv abn2ymCoMCy/TEc=; b=QAFxoV8BbKaHtvvi3F0+/YS7yNWmU9ZwHx1feAxji11p d2CIISrSWZha0YvuEbdhvrbas2zIvH2U0/gaaKe31oyWVQ7nfhc2t7fwtFR33ihM +RYT1ijA7hWJlbW785LBfjAFaQzahNVJ6wR8LLVh2ezfrVqwbvswvi1VHjMGjvo= DKIM-Signature: v=1; a=rsa-sha1; c=relaxed/relaxed; d= messagingengine.com; h=message-id:x-sasl-enc:from:to:cc :mime-version:content-transfer-encoding:content-type:subject :reply-to:date:in-reply-to:references; s=smtpout; bh=NHlsZrskO1k vabn2ymCoMCy/TEc=; b=kiTjwMa1yfOJLQqnOB7G1+DOO+pW1/hAe+7QeqXNhPY xki8c7yOLA5FOXI1HIgD3eL+tRLeAbWF4swKaFSCcpNPiwrLyRp/PaD6xGHepGVE dVG2eLczgAKjb4frpDx7mZQKQ7UfLNZvBlE3/ywAeEB0csEoDFXEJcOOIlG3jdbU = Original-Received: by web5.nyi.internal (Postfix, from userid 99) id BBBB9DC1782; Wed, 26 Nov 2014 03:22:47 -0500 (EST) X-Sasl-Enc: 6tY84DpmMKNCVvmslM4u2WHVvYzJiPQgmaZzUZRySxmt 1416990167 X-Mailer: MessagingEngine.com Webmail Interface - ajax-53201334 In-Reply-To: X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 66.111.4.28 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:178287 Archived-At: While I can work aroud this bug by this patch or a similar, I think it's worth noting that csharp-mode worked fine prior to Emacs 24.4. This means that some changes in core emacs now breaks derived c-modes. So yes, we can work around this in csharp-mode (for now), but are we 100% sure we haven't broken any other derived c-modes in the process? Wouldn't it be better to have this fixed in the -official- Emacs version being distrubuted from the GNU website? If building Emacs from source (master-branch) right now, the issue is already fixed. We might just need a new build and that's it. --=20 Jostein Kj=F8nigsen jostein@kjonigsen.net / jostein@secure.kjonigsen.net On Tue, Nov 25, 2014, at 11:35 PM, Glenn Morris wrote: >=20 > Following diff seems to make csharp-mode-0.8.5.el work fine for me. > (Without the `eval-and-compile', it was uncompilable in any Emacs 24.x.) >=20 > Since it uses eg `set-difference', IMO it should in any case explicitly > require cl and not rely on its other dependencies pulling it in. >=20 > *** csharp-mode-0.8.5.el.ORIG 2014-11-25 14:32:22.001787092 -0800 > --- csharp-mode-0.8.5.el 2014-11-25 14:31:13.608157922 -0800 > *************** > *** 379,384 **** > --- 379,385 ---- > ;; 0.8.6 DPC 2011 May ?? > ;; - >=20=20=20 > + (eval-when-compile (require 'cl)) >=20=20=20 > (require 'cc-mode) >=20=20=20 > *************** > *** 472,477 **** > --- 473,479 ---- > "Regex for matching directive blocks in ASP.NET files (.aspx, .ashx, > .ascx)") >=20=20=20 >=20=20=20 > + (eval-and-compile > (defconst csharp-enum-decl-re > (concat > "\\ *************** > *** 484,490 **** > "\\)" > "\\)?") > "Regex that captures an enum declaration in C#" > ! ) >=20=20=20 > ;; =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D >=20=20=20 > --- 486,492 ---- > "\\)" > "\\)?") > "Regex that captures an enum declaration in C#" > ! )) >=20=20=20 > ;; =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D >=20=20=20