From mboxrd@z Thu Jan 1 00:00:00 1970 Path: main.gmane.org!not-for-mail From: David PONCE Newsgroups: gmane.emacs.devel Subject: Re: byte-compiler fails to print complex byte-code data (SOLVED?) Date: Tue, 18 May 2004 11:11:06 +0200 (CEST) Sender: emacs-devel-bounces+emacs-devel=quimby.gnus.org@gnu.org Message-ID: <1408366.1084871466954.JavaMail.www@wwinf0602> Reply-To: david.ponce@wanadoo.fr NNTP-Posting-Host: deer.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: 7bit X-Trace: sea.gmane.org 1084871748 28144 80.91.224.253 (18 May 2004 09:15:48 GMT) X-Complaints-To: usenet@sea.gmane.org NNTP-Posting-Date: Tue, 18 May 2004 09:15:48 +0000 (UTC) Cc: emacs-devel Original-X-From: emacs-devel-bounces+emacs-devel=quimby.gnus.org@gnu.org Tue May 18 11:15:41 2004 Return-path: Original-Received: from quimby.gnus.org ([80.91.224.244]) by deer.gmane.org with esmtp (Exim 3.35 #1 (Debian)) id 1BQ0hI-0004QR-00 for ; Tue, 18 May 2004 11:15:40 +0200 Original-Received: from monty-python.gnu.org ([199.232.76.173]) by quimby.gnus.org with esmtp (Exim 3.35 #1 (Debian)) id 1BQ0hI-0005MO-00 for ; Tue, 18 May 2004 11:15:40 +0200 Original-Received: from localhost ([127.0.0.1] helo=monty-python.gnu.org) by monty-python.gnu.org with esmtp (Exim 4.34) id 1BQ0hA-0000QO-Go for emacs-devel@quimby.gnus.org; Tue, 18 May 2004 05:15:32 -0400 Original-Received: from list by monty-python.gnu.org with tmda-scanned (Exim 4.34) id 1BQ0dV-0006lC-Ic for emacs-devel@gnu.org; Tue, 18 May 2004 05:11:45 -0400 Original-Received: from mail by monty-python.gnu.org with spam-scanned (Exim 4.34) id 1BQ0cu-0006P7-Kv for emacs-devel@gnu.org; Tue, 18 May 2004 05:11:40 -0400 Original-Received: from [193.252.22.25] (helo=mwinf0604.wanadoo.fr) by monty-python.gnu.org with esmtp (Exim 4.34) id 1BQ0cu-0006OZ-6Q; Tue, 18 May 2004 05:11:08 -0400 Original-Received: from wwinf0602 (wwinf0602 [172.22.137.29]) by mwinf0604.wanadoo.fr (SMTP Server) with ESMTP id ED01C28005F5; Tue, 18 May 2004 11:11:06 +0200 (CEST) Original-To: rms@gnu.org X-Originating-IP: [194.2.245.141] X-WUM-FROM: |~| X-WUM-TO: |~| X-WUM-CC: |~| X-WUM-REPLYTO: |~| X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.4 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+emacs-devel=quimby.gnus.org@gnu.org Xref: main.gmane.org gmane.emacs.devel:23621 X-Report-Spam: http://spam.gmane.org/gmane.emacs.devel:23621 Hi, > On latest CVS GNU Emacs, byte compilation fails because `prin1' of > complex byte-code data signals error "Apparently circular structure > being printed" in `byte-compile-output-docform'. [...] > I suspect the problem is caused by this change: > > 2004-05-10 Richard M. Stallman > > * print.c (print_preprocess): Use being_printed, loop_count and > halftail to detect overdeep nesting and cyclic cdr chains. I looked more thoroughly at print.c code, and found that in the print routine, when print_preprocess has been called, with the above change it can leave print_depth incremented, which leads to the "Apparently circular structure being printed" error in next call to print_object. With the following patch, that resets print_depth to 0 before to call print_object, the byte-compiler no more fails to print large byte code data. WDYT? David 2004-05-18 David Ponce * print.c (print): Reset print_depth before to call print_object. Index: print.c =================================================================== RCS file: /cvsroot/emacs/emacs/src/print.c,v retrieving revision 1.202 diff -c -r1.202 print.c *** print.c 17 May 2004 22:47:40 -0000 1.202 --- print.c 18 May 2004 08:54:07 -0000 *************** *** 1220,1226 **** register Lisp_Object printcharfun; int escapeflag; { - print_depth = 0; old_backquote_output = 0; /* Reset print_number_index and Vprint_number_table only when --- 1220,1225 ---- *************** *** 1240,1245 **** --- 1239,1245 ---- start = index = print_number_index; /* Construct Vprint_number_table. This increments print_number_index for the objects added. */ + print_depth = 0; print_preprocess (obj); /* Remove unnecessary objects, which appear only once in OBJ; *************** *** 1264,1269 **** --- 1264,1270 ---- print_number_index = index; } + print_depth = 0; print_object (obj, printcharfun, escapeflag); }