From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: "Daniel Colascione" Newsgroups: gmane.emacs.devel Subject: Re: CHECK_STRUCTS/dmpstruct.h mechanism is broken. Date: Wed, 10 Apr 2019 12:43:32 -0700 Message-ID: <13edd2f05c9c0632414319784cb9d60d.squirrel@dancol.org> References: <20190228202146.GC4686@ACM> <20190228205955.GD4686@ACM> Mime-Version: 1.0 Content-Type: text/plain;charset=iso-8859-1 Content-Transfer-Encoding: 8bit Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="119657"; mail-complaints-to="usenet@blaine.gmane.org" User-Agent: SquirrelMail/1.4.23 [SVN] Cc: emacs-devel@gnu.org To: "Andy Moreton" Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Wed Apr 10 21:44:48 2019 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1hEJ9L-000Uy0-Hh for ged-emacs-devel@m.gmane.org; Wed, 10 Apr 2019 21:44:47 +0200 Original-Received: from localhost ([127.0.0.1]:36949 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hEJ9K-0004iT-IY for ged-emacs-devel@m.gmane.org; Wed, 10 Apr 2019 15:44:46 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:56496) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hEJ8A-0004O2-MS for emacs-devel@gnu.org; Wed, 10 Apr 2019 15:43:35 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hEJ89-0004jS-NE for emacs-devel@gnu.org; Wed, 10 Apr 2019 15:43:34 -0400 Original-Received: from dancol.org ([2600:3c01::f03c:91ff:fedf:adf3]:38522) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1hEJ89-0004i5-DU for emacs-devel@gnu.org; Wed, 10 Apr 2019 15:43:33 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=dancol.org; s=x; h=Content-Transfer-Encoding:Content-Type:MIME-Version:Cc:To:From:Subject:Date:References:In-Reply-To:Message-ID; bh=ZaP5mH272XbpnDQttGA43as9TMM8G7PShGE1U+MMdXU=; b=bzqL+XMRMMAG/yt/OHUV8w1YIGYL8MZ05UPplQWDA62lc933EF846guT239nPWX/QR30rHKMVNctOJxgJ9ztdTbE1MCMKGn0P6hSgaD3LQvixRccMkwZh1xQEpL2MCvUCSqwRAA/Xd0TfMpDXXnSXLci+viRjSkc4ekA+ID5CKPlIV+3kvpJxPJqHYao77Tg7GQ4WfQ61j70TS6lUswVs9B8urIFNsnrB67Knss5JwXtx8kswGef90eZyt9KyfDEJeynAdbLP+xBq0TFQpOO6ZDJKE6jRuCQUSQWBxWzNJw9A/0Y8b6cber57xP4ruhoGG/dJzitHZAzveC8YI8UNw==; Original-Received: from localhost ([127.0.0.1] helo=dancol.org) by dancol.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hEJ88-000697-Ck; Wed, 10 Apr 2019 12:43:32 -0700 Original-Received: from 127.0.0.1 (SquirrelMail authenticated user dancol) by dancol.org with HTTP; Wed, 10 Apr 2019 12:43:32 -0700 In-Reply-To: X-Priority: 3 (Normal) Importance: Normal X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2600:3c01::f03c:91ff:fedf:adf3 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:235250 Archived-At: > On Wed 10 Apr 2019, Paul Eggert wrote: > >> On 4/10/19 6:12 AM, Andy Moreton wrote: >>> this breaks out-of-tree builds, as make tries to use >>> /path/to/emacs/admin/charsets/Makefile rather than the correct path >>> /admin/charsets/Makefile: >> >> Sorry, my tests didn't include a complete out-of-tree bootstrap. I >> installed the attached patch to fix that problem, along with the >> problem's other instance. The other -C changes should be OK. You're >> correct that some of the -C changes were unrelated to the original >> patch. Still, they make the Makefile more consistent and I'd like to >> keep the ones that work. > > The minimal fixes you have committed work for me for a bootstrap build > from a completely clean tree (after 'git clean -Xdf'). > > I'm not convinced that computing filenames using GNU make functions > rather than using literal values is clearer, and the makefiles include > both styles, so more work is needed to achieve consistency using either > approach. > >> PS. I'd like Emacs to switch to a nonrecursive 'make' process, as this >> subsidiary $(MAKE) -C business is for the birds. We've made the switch >> for other GNU projects and it's been a win. This is not a new idea; see: >> >> Miller P. Recursive Make considered harmful. AAUGN J of AUUG. >> 1998;19(1):14-25. https://grosskurth.ca/bib/1997/miller.pdf > > This is a good idea, and should result in better dependency tracking and > possibly faster parallel builds. Please make sure it works for in tree > and out of tree builds, as both are useful. Agreed on moving to nonrecursive make.