From: Albert Krewinkel <tarleb@moltkeplatz.de>
To: Bastien <bzg@gnu.org>
Cc: Albert Krewinkel <tarleb@moltkeplatz.de>, emacs-orgmode@gnu.org
Subject: Re: [PATCH] org.el (org-offer-links-in-entry): Remove code duplication
Date: Sun, 11 May 2014 18:33:28 +0200 [thread overview]
Message-ID: <1399826009-369-1-git-send-email-tarleb@moltkeplatz.de> (raw)
In-Reply-To: <87k39zmcw2.fsf@bzg.ath.cx>
In-Reply-To: <87k39zmcw2.fsf@bzg.ath.cx>
Hi Bastien,
Bastien <bzg@gnu.org> writes:
> Albert Krewinkel <tarleb@moltkeplatz.de> writes:
>
>> * org.el (org-offer-links-in-entry): Use `org-any-link-re' to avoid
>> code duplication.
>
> This is not really code duplication, as the output of `org-any-link-re'
> is different from the output of the current sexp in the code.
I'm not exactly sure what you mean, are you referring to the variables'
different representation in the source? I double checked that
(string-equal re org-any-link-re) => t
when `re' is set to the old value (as of commit 7c8559e).
> That said, the change looks good anyway. Can you double-check there
> cannot be any problem with the value of `org-any-link-re'?
The variable is only ever changed when calling `org-make-link-regexps',
so I'm quite positive that the change does not have any unintended side
effects. The test suite passes, too.
>> This is a TINYCHANGE.
>
> (TINYCHANGE should stand alone on the line.)
Done. As an aside: I did sign the copyright assignment papers to be
able to contrivute to Gnus, but that probably wouldn't help much, as
Org is a different project. Is that correct?
> Thanks!
No, thank you all for all the work you put into this! It is truly
amazing!
Albert Krewinkel (1):
org.el (org-offer-links-in-entry): Reuse global variable
lisp/org.el | 7 ++-----
1 file changed, 2 insertions(+), 5 deletions(-)
--
2.0.0.rc0
next prev parent reply other threads:[~2014-05-11 16:35 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-24 14:36 [PATCH] org.el (org-offer-links-in-entry): Remove code duplication Albert Krewinkel
2014-05-06 9:29 ` Bastien
2014-05-11 16:33 ` Albert Krewinkel [this message]
2014-05-11 16:33 ` [PATCH] org.el (org-offer-links-in-entry): Reuse global variable Albert Krewinkel
2014-05-20 21:08 ` Bastien
2014-05-11 19:09 ` [PATCH] org.el (org-offer-links-in-entry): Remove code duplication Achim Gratz
2014-05-15 10:41 ` Bastien
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1399826009-369-1-git-send-email-tarleb@moltkeplatz.de \
--to=tarleb@moltkeplatz.de \
--cc=bzg@gnu.org \
--cc=emacs-orgmode@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.