From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Michael Mauger Newsgroups: gmane.emacs.bugs Subject: bug#25236: 26.0.50; sql-postgres not working on master Date: Wed, 4 Jan 2017 03:16:00 +0000 (UTC) Message-ID: <1397003198.5767161.1483499760212@mail.yahoo.com> References: <87vauftgz2.fsf@caral.i-did-not-set--mail-host-address--so-tickle-me> <1483121873.22754.0@smtp.gmail.com> Reply-To: Michael Mauger NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-Trace: blaine.gmane.org 1483500076 22539 195.159.176.226 (4 Jan 2017 03:21:16 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Wed, 4 Jan 2017 03:21:16 +0000 (UTC) Cc: "25236@debbugs.gnu.org" <25236@debbugs.gnu.org> To: Simen =?UTF-8?Q?Heggest=C3=B8yl?= , "sunshavi@fastmail.fm" Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Wed Jan 04 04:21:11 2017 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cOc8R-0004lT-TO for geb-bug-gnu-emacs@m.gmane.org; Wed, 04 Jan 2017 04:21:08 +0100 Original-Received: from localhost ([::1]:37067 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cOc8V-0000EH-RV for geb-bug-gnu-emacs@m.gmane.org; Tue, 03 Jan 2017 22:21:11 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:37785) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cOc8P-0000E4-Mz for bug-gnu-emacs@gnu.org; Tue, 03 Jan 2017 22:21:06 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cOc8M-0008Qp-JS for bug-gnu-emacs@gnu.org; Tue, 03 Jan 2017 22:21:05 -0500 Original-Received: from debbugs.gnu.org ([208.118.235.43]:53536) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1cOc8M-0008Qk-Fs for bug-gnu-emacs@gnu.org; Tue, 03 Jan 2017 22:21:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1cOc8M-0002eb-86 for bug-gnu-emacs@gnu.org; Tue, 03 Jan 2017 22:21:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Michael Mauger Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 04 Jan 2017 03:21:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 25236 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 25236-submit@debbugs.gnu.org id=B25236.148350001310121 (code B ref 25236); Wed, 04 Jan 2017 03:21:02 +0000 Original-Received: (at 25236) by debbugs.gnu.org; 4 Jan 2017 03:20:13 +0000 Original-Received: from localhost ([127.0.0.1]:40702 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cOc7Z-0002dA-0x for submit@debbugs.gnu.org; Tue, 03 Jan 2017 22:20:13 -0500 Original-Received: from sonic324.consmr.mail.ne1.yahoo.com ([66.163.187.252]:34430) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cOc7W-0002cv-TS for 25236@debbugs.gnu.org; Tue, 03 Jan 2017 22:20:11 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1483500004; bh=1dFLHrFBb1UR9CWhCnkb7HAxf7wLv4so5muEVdTCODg=; h=Date:From:Reply-To:To:Cc:In-Reply-To:References:Subject:From:Subject; b=YIKdA1GKzYVBsOgHI8o7X756c1+5MtCqOuIg8z8hnD7mZ6RLzdSIknNSwyshbjMUXDSJjdPZa6nGSpL7vgJidqTy/4iYzvswa/4rq1JzKHLNV8LNO1gZgP9S5XQjGQ/JLCaiUI9oQi/T3yISD7wXHnOGsNWsYKuuw6RfQrtjDfjcgaS87aZLlz81RAlQbPtmi3sMckOO9+nzirZaoctaue9BCu0lQ3Qk+6BLYlDzsAvjHPxbSo5xaTP3HBt1dIW42QNtXBGCsOnopK06jhk1svQaXOps8zbKzDiCSdo0pccLvksDJdpDj7M95MfVBPXbxFvTxaSXGimQRPnQTqJ3Yw== X-YMail-OSG: BFmJ4DIVM1kQfP4geVV36YLxWeYSmiXwwagZ9N1..hXprmgTwnnxC1GQaFxFsaP sAf3MFdKHOmxafk7QzsC8uHijsnFL.m0JU_4nNw210p8zH_5X_.yMNAmyuntKr3hGOcYz3GwK3xz ktD9KX2B2w5sZkSVSDZZeZh.kk0bfnLdE2Y29O8rKTRbZTVDmg783S8K5SAtPmdBDqxZvIagTv6a ahNJsqtXf_RVJ123qZrxEB7JoxLAM8R84eexO9kb9TSNbLXpPq8bB.gXBg7N1SsHiTTM9uh85DuZ vjDqEKx1FTuN7hV7CpEXL3jd5yGIecE3XWbRDnhpM7MWipkw_vMDkFFqgFEnPJDR8eE9Lk2_pmGR fVjkIsYYTO6qfsB857q7z_UZATPUk8PWeuTP8DABlq4U5Bf0vwFavvIY5U2CWq6OUwA1n30RypP7 iUe62_v4lZM9d51FKbw4gb_LBNwiLJHuZEOfu8O5SQwJ7xlds0hg68UPMlpojUZedlfGD4JwEySQ U4VHBddy6BAXLg2f.r7Y0r7ELwLEDZPL6WB1XAwcNd0UyL1WJjFYAE9QLanFVFbPvfzl5XTN4Fop dAjFND4Z.Exw- Original-Received: from sonic.gate.mail.ne1.yahoo.com by sonic324.consmr.mail.ne1.yahoo.com with HTTP; Wed, 4 Jan 2017 03:20:04 +0000 In-Reply-To: <1483121873.22754.0@smtp.gmail.com> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:127725 Archived-At: On Friday, December 30, 2016 1:17 PM, Simen Heggest=C3=B8yl wrote: > >This bug seems to be caused by a change I made in >https://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D24646, making >`sql-postgres` able to complete the database name by looking at the >result of `psql -ltX`. > >psql exits with status code 2 if the connection to the server went >bad, for instance if permissions are missing [1]. > >I think we can fix this by being more lax in >`sql-postgres-list-databases`, and just don't provide any completions >should the command fail. Then we'd also need to change the value of >the `REQUIRE-MATCH` parameter to `completing-read` on line 2966, since >requiring a match when there are no completions would make it >impossible to continue. > >What do you think, Michael? > >-- Simen > >[1]=20 >https://www.postgresql.org/docs/current/static/app-psql.html#AEN98634 > Just got back after the holiday. Makes sense that could be a problem. I'm g= etting ready to push a change related to completing-read so let me take a l= ook. Thanks for staying on top of this... --=20 MICHAEL MAUGER // FSF Member // GNU Emacs sql-mode maintainer // GNU Linux,= GNU Emacs