From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Mike Kupfer Newsgroups: gmane.emacs.bugs Subject: bug#22692: 25.0.91; xref-find-definitions fails to prompt Date: Mon, 22 Feb 2016 18:19:28 -0800 Message-ID: <13913.1456193968@allegro.localdomain> References: <20283.1455584523@allegro.localdomain> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" X-Trace: ger.gmane.org 1456194023 24945 80.91.229.3 (23 Feb 2016 02:20:23 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Tue, 23 Feb 2016 02:20:23 +0000 (UTC) Cc: 22692@debbugs.gnu.org To: Dmitry Gutov Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Tue Feb 23 03:20:12 2016 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1aY2aB-0005gt-3k for geb-bug-gnu-emacs@m.gmane.org; Tue, 23 Feb 2016 03:20:11 +0100 Original-Received: from localhost ([::1]:53274 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aY2aA-0001ys-HN for geb-bug-gnu-emacs@m.gmane.org; Mon, 22 Feb 2016 21:20:10 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:40012) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aY2a7-0001xj-8e for bug-gnu-emacs@gnu.org; Mon, 22 Feb 2016 21:20:08 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aY2a2-0006Ig-93 for bug-gnu-emacs@gnu.org; Mon, 22 Feb 2016 21:20:07 -0500 Original-Received: from debbugs.gnu.org ([208.118.235.43]:41590) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aY2a2-0006IX-5y for bug-gnu-emacs@gnu.org; Mon, 22 Feb 2016 21:20:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84) (envelope-from ) id 1aY2a1-0000fM-Qu for bug-gnu-emacs@gnu.org; Mon, 22 Feb 2016 21:20:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Mike Kupfer Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 23 Feb 2016 02:20:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 22692 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 22692-submit@debbugs.gnu.org id=B22692.14561939732517 (code B ref 22692); Tue, 23 Feb 2016 02:20:01 +0000 Original-Received: (at 22692) by debbugs.gnu.org; 23 Feb 2016 02:19:33 +0000 Original-Received: from localhost ([127.0.0.1]:38717 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84) (envelope-from ) id 1aY2ZZ-0000eX-Kv for submit@debbugs.gnu.org; Mon, 22 Feb 2016 21:19:33 -0500 Original-Received: from shell1.rawbw.com ([198.144.192.42]:39829 ident=root) by debbugs.gnu.org with esmtp (Exim 4.84) (envelope-from ) id 1aY2ZX-0000eQ-LR for 22692@debbugs.gnu.org; Mon, 22 Feb 2016 21:19:32 -0500 Original-Received: from allegro.localdomain (m208-249.dsl.rawbw.com [198.144.208.249]) by shell1.rawbw.com (8.15.1/8.15.1) with ESMTP id u1N2JTNP085871; Mon, 22 Feb 2016 18:19:30 -0800 (PST) (envelope-from m.kupfer@acm.org) X-Authentication-Warning: shell1.rawbw.com: Host m208-249.dsl.rawbw.com [198.144.208.249] claimed to be allegro.localdomain In-Reply-To: Your message of "Tue, 23 Feb 2016 02:43:52 +0200." <56CBAB48.6000209@yandex.ru> X-Mailer: MH-E 8.6; nmh 1.6; GNU Emacs 25.0.91 Content-ID: <13912.1456193968.1@allegro.localdomain> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:113509 Archived-At: Dmitry Gutov wrote: > I've changed it like we discussed. Thanks! > However, after reading the quoted text, I'm not quite sure we need to > remove "valid". To my eyes, "valid identifier" in that text means > "syntactically valid", rather than "an identifier defined somewhere in > the current project". The latter would be "an existing identifier", I > guess? [...] > The two other uses of "valid identifier" we have inside Emacs (in > cc-vars.el and idlwave.el) also mean "syntactically valid". In cc-vars.el, "syntactically valid identifiers" appears earlier in the paragraph, so when "valid identifiers" appears later, the interpretation is clear. In idlwave.el, "valid identifier" is used in a comment. I think it's ambiguous (on its own, without studying the surrounding code), but since it's just a comment, I don't care so much about it. (This is as of Emacs 25.0.91; I didn't check the latest in the emacs-25 git branch.) > Mike, thoughts? I have a slight preference for removing "valid" from the Info text, since that change makes the text a little more concise. But I'd also be fine with changing to it to "syntactically valid identifier". cheers, mike