all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Mike Kupfer <m.kupfer@acm.org>
To: Dmitry Gutov <dgutov@yandex.ru>
Cc: 22692@debbugs.gnu.org
Subject: bug#22692: 25.0.91; xref-find-definitions fails to prompt
Date: Mon, 22 Feb 2016 18:19:28 -0800	[thread overview]
Message-ID: <13913.1456193968@allegro.localdomain> (raw)
In-Reply-To: Your message of "Tue, 23 Feb 2016 02:43:52 +0200." <56CBAB48.6000209@yandex.ru>

Dmitry Gutov wrote:

> I've changed it like we discussed.

Thanks!

> However, after reading the quoted text, I'm not quite sure we need to
> remove "valid". To my eyes, "valid identifier" in that text means
> "syntactically valid", rather than "an identifier defined somewhere in
> the current project". The latter would be "an existing identifier", I
> guess?
[...]
> The two other uses of "valid identifier" we have inside Emacs (in
> cc-vars.el and idlwave.el) also mean "syntactically valid".

In cc-vars.el, "syntactically valid identifiers" appears earlier in the
paragraph, so when "valid identifiers" appears later, the interpretation
is clear.

In idlwave.el, "valid identifier" is used in a comment.  I think it's
ambiguous (on its own, without studying the surrounding code), but since
it's just a comment, I don't care so much about it.

(This is as of Emacs 25.0.91; I didn't check the latest in the emacs-25
git branch.)

> Mike, thoughts?

I have a slight preference for removing "valid" from the Info text,
since that change makes the text a little more concise.  But I'd also be
fine with changing to it to "syntactically valid identifier".

cheers,
mike





  reply	other threads:[~2016-02-23  2:19 UTC|newest]

Thread overview: 35+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-02-16  1:02 bug#22692: 25.0.91; xref-find-definitions fails to prompt Mike Kupfer
2016-02-16  3:44 ` Eli Zaretskii
2016-02-16 10:10   ` Dmitry Gutov
2016-02-16 16:01     ` Eli Zaretskii
2016-02-16 10:12 ` Dmitry Gutov
2016-02-17  1:55   ` Mike Kupfer
2016-02-19 13:43     ` Dmitry Gutov
2016-02-19 15:10       ` Mike Kupfer
2016-02-19 15:59       ` Eli Zaretskii
2016-02-19 18:08         ` Dmitry Gutov
2016-02-19 18:37           ` Eli Zaretskii
2016-02-19 18:52             ` Dmitry Gutov
2016-02-19 20:24               ` Eli Zaretskii
2016-02-20  1:28                 ` Dmitry Gutov
2016-02-20  8:45                   ` Eli Zaretskii
2016-02-21  3:36                     ` Mike Kupfer
2016-02-21 22:56                       ` Dmitry Gutov
2016-02-23  0:43         ` Dmitry Gutov
2016-02-23  2:19           ` Mike Kupfer [this message]
2016-02-18  3:45 ` bug#22692: docstring for xref-find-definitions Mike Kupfer
2016-02-18 16:50   ` Eli Zaretskii
2016-02-18 18:48     ` Mike Kupfer
2016-02-19 13:04       ` Dmitry Gutov
2016-02-19 13:01     ` Dmitry Gutov
2016-02-19 15:34       ` Eli Zaretskii
2016-02-20  1:24         ` Dmitry Gutov
2016-02-20  8:33           ` Eli Zaretskii
2016-02-23  0:04             ` Juri Linkov
2016-02-23  0:35               ` Dmitry Gutov
2016-02-27 10:32                 ` Eli Zaretskii
2016-02-27 12:35                   ` Dmitry Gutov
2016-02-27 12:43                     ` Eli Zaretskii
2016-02-29  2:48                       ` Dmitry Gutov
2016-02-23  0:41               ` Drew Adams
2016-02-21  3:42           ` Mike Kupfer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=13913.1456193968@allegro.localdomain \
    --to=m.kupfer@acm.org \
    --cc=22692@debbugs.gnu.org \
    --cc=dgutov@yandex.ru \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.