From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Gregory Heytings Newsgroups: gmane.emacs.bugs Subject: bug#62370: 28.1; sieve-mode: faces should inherit from font-lock-X-face faces Date: Wed, 22 Mar 2023 20:10:37 +0000 Message-ID: <13910d348d640c50ebdc@heytings.org> References: <875yatpclo.fsf@gmail.com> <83y1no6dtd.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; format=flowed; charset=us-ascii Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="11155"; mail-complaints-to="usenet@ciao.gmane.io" Cc: "Trent W. Buck" , 62370@debbugs.gnu.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Wed Mar 22 21:11:16 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pf4nj-0002hJ-UR for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 22 Mar 2023 21:11:15 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pf4nX-0007Hy-8S; Wed, 22 Mar 2023 16:11:03 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pf4nW-0007Hp-7T for bug-gnu-emacs@gnu.org; Wed, 22 Mar 2023 16:11:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pf4nV-0007e8-Uc for bug-gnu-emacs@gnu.org; Wed, 22 Mar 2023 16:11:01 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1pf4nV-0002WR-Kw for bug-gnu-emacs@gnu.org; Wed, 22 Mar 2023 16:11:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Gregory Heytings Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 22 Mar 2023 20:11:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 62370 X-GNU-PR-Package: emacs Original-Received: via spool by 62370-submit@debbugs.gnu.org id=B62370.16795158429667 (code B ref 62370); Wed, 22 Mar 2023 20:11:01 +0000 Original-Received: (at 62370) by debbugs.gnu.org; 22 Mar 2023 20:10:42 +0000 Original-Received: from localhost ([127.0.0.1]:36793 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pf4nB-0002Vq-OU for submit@debbugs.gnu.org; Wed, 22 Mar 2023 16:10:41 -0400 Original-Received: from heytings.org ([95.142.160.155]:50172) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pf4n9-0002Vg-Km for 62370@debbugs.gnu.org; Wed, 22 Mar 2023 16:10:40 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=heytings.org; s=20220101; t=1679515838; bh=XzcpmUSmHGd1mQnor/nX7w66AQJ0W/yocfbtfA6YCU0=; h=Date:From:To:cc:Subject:In-Reply-To:Message-ID:References:From; b=fTyyeVYyIRhF9dkflkDyxZMS+eGQyNW+ZcuGnK8oKA2ZiAcl2d1zC5a5eo3KHCzSF xgzellKS2Rzuft5+KX2tpuWygp5MOcuoMTaE75qHXIkH5HJ08ysFeZ546SqqM/aKCN x0+JkFIBEkhk3o4O2yJBEVUsa42EFfDjKLQIUBZZqBoz5c113fpdgNc1XjSaek92Hl 29wzCooCcEZpqnKk3+yNCscFUdsKzVmV1ikVUTZosEfl+1HAPSYYYe3LLsIl4zmgLt CluyyN9CdThfqSLhS1B9K4ZcnLzcfO2iPtt/TnGkoi/SoG1kqr19guy5iJ5i+Lg6QJ GRjQg+3SRxhFg== In-Reply-To: <83y1no6dtd.fsf@gnu.org> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:258413 Archived-At: >> I think sieve-mode should inherit from font-lock-*-face, as most other >> things do. > > I'm not sure I agree. These faces are with us for a long time, so > changing their defaults now brings disadvantages: it could cause someone > dislike the result. > > Does anyone else have an opinion about this? > I agree with both Trent and you. Modes should inherit from font-lock-*-faces, unless there's a good reason not to inherit from these faces. Otherwise customizing the visual appearance of Emacs is a nightmare. This is, by the way, made clear in (elisp)Major Mode Conventions: "Each face that the mode defines should, if possible, inherit from an existing Emacs face. See Basic Faces, and see Faces for Font Lock." But the sieve-* faces have existed for twenty years, so it's now too late to change them.