From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Mattias =?UTF-8?Q?Engdeg=C3=A5rd?= Newsgroups: gmane.emacs.bugs Subject: bug#68244: hash-table improvements Date: Tue, 13 Feb 2024 11:12:37 +0100 Message-ID: <13877748-AFAB-4310-A0CA-104752C8BF2D@gmail.com> References: <170438379722.3921.9312235725296561206@vcs2.savannah.gnu.org> <20240104155642.B4A99C00344@vcs2.savannah.gnu.org> <8d49ebdc-9da7-4e70-a080-d8e892b980b6@gutov.dev> <08314177-5AE9-4352-94A0-641830B4094D@gmail.com> <19265EA5-E6F3-446C-AD9B-763693CF0A48@gmail.com> <6F3E332D-54ED-4E70-BBAA-A207750B52F8@gmail.com> Mime-Version: 1.0 (Mac OS X Mail 14.0 \(3654.120.0.1.15\)) Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="22716"; mail-complaints-to="usenet@ciao.gmane.io" Cc: Dmitry Gutov , Eli Zaretskii , 68244@debbugs.gnu.org, Stefan Monnier , Stefan Kangas To: Gerd =?UTF-8?Q?M=C3=B6llmann?= Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Tue Feb 13 11:14:57 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1rZpoU-0005gZ-9d for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 13 Feb 2024 11:14:54 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rZpoN-0005EL-Uf; Tue, 13 Feb 2024 05:14:47 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rZpoL-0005E5-Eb for bug-gnu-emacs@gnu.org; Tue, 13 Feb 2024 05:14:45 -0500 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1rZpoK-000687-VP for bug-gnu-emacs@gnu.org; Tue, 13 Feb 2024 05:14:45 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1rZpob-0004oK-SS for bug-gnu-emacs@gnu.org; Tue, 13 Feb 2024 05:15:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Mattias =?UTF-8?Q?Engdeg=C3=A5rd?= Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 13 Feb 2024 10:15:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 68244 X-GNU-PR-Package: emacs Original-Received: via spool by 68244-submit@debbugs.gnu.org id=B68244.170781924518394 (code B ref 68244); Tue, 13 Feb 2024 10:15:01 +0000 Original-Received: (at 68244) by debbugs.gnu.org; 13 Feb 2024 10:14:05 +0000 Original-Received: from localhost ([127.0.0.1]:41764 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rZpng-0004mc-Iy for submit@debbugs.gnu.org; Tue, 13 Feb 2024 05:14:04 -0500 Original-Received: from mail-lj1-f175.google.com ([209.85.208.175]:43104) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rZpne-0004lx-EA for 68244@debbugs.gnu.org; Tue, 13 Feb 2024 05:14:03 -0500 Original-Received: by mail-lj1-f175.google.com with SMTP id 38308e7fff4ca-2d0c9967fdcso51869961fa.0 for <68244@debbugs.gnu.org>; Tue, 13 Feb 2024 02:13:44 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1707819159; x=1708423959; darn=debbugs.gnu.org; h=to:references:message-id:content-transfer-encoding:cc:date :in-reply-to:from:subject:mime-version:sender:from:to:cc:subject :date:message-id:reply-to; bh=gvdnwvBBnVkX8s2GUJf1G+OrRzThlzxh6NVZtwfP2EE=; b=F3c/mPELG8XXps4M5gEfDEObVfnFRZw6Gv3zKLlGy6YQOP6I/B8hw15UF08mUrREkO gCvC+ddLhQDwkngleY+Qd3nhuTQ+gfvotLvnvT2YcaOTZ6AkVFKl+R/UxQjnuo+FQXsW Aaiuy8+rnc1zfSGENNGSLkWQp9a8jIZa6qpnAZhXhNSvUc8KPbnlnjTnRrmQHEYxxmIy dgthtlA1vDnvrU7Kx3jUO/8fWlX+cdo4QsaCMTeiNDMS/HFv5jbnZCBDt8+I30fXymMb NzFN1dC3T9qmUf5vsj5rPxt5nbcbOBLQTBo71eEgBbwRYlX1YfIqnF3V90rcfe2tnDhz XQ1Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1707819159; x=1708423959; h=to:references:message-id:content-transfer-encoding:cc:date :in-reply-to:from:subject:mime-version:sender:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=gvdnwvBBnVkX8s2GUJf1G+OrRzThlzxh6NVZtwfP2EE=; b=pVFjZDarEt2G7w1xRMYkjHiV2Kv/ktY4o7pvcvj9uQdGl6B498Bycbr+6Nht0sSAhJ cpsdT3LK//aqVyUQJ2lxSG2icmFF2ZU72YsRn68pDzxJ2IzDX/RPq+jv28Uie/htb+8A 8CtG67g3aLT0GKdNAdKfku+xfyMxyYnwUQ+JyIe/y1Cfv6V8XDE8xVE97vZr/DVxLc5u IPsGhqjkUYoB9Ti6AUGerD1hpprMP/zrKX2Re5I8ttYgjQ4KKzRSlt4QQWaIeRXGIObR kgS90SmGhVCKC7JHLZGs4pkHRwGugCLHIeIrFaRO2MaNL7DZCva48OL2SzcmxFeR8ScP /dWQ== X-Forwarded-Encrypted: i=1; AJvYcCVxLAVhBqEQot9chY+S4/BwIdvnyU2Ebrkb/lIAr/TVajm1eUcYdRSX4KthnIEgqf1B4TfjYFgqQZvsNDY8KvEtwBYwOZs= X-Gm-Message-State: AOJu0Yyp8QKtL1kVNX/Cc+x8xiZ0c689MuHfM5xnNuH0KwWmFIKlKpdZ lgjek2sSilNUYAjFsPIYnjJ+F2JdnVeoEEDiO3XaSnciA5Vengy6 X-Google-Smtp-Source: AGHT+IGY5bc93sgse3IyH6KrSjtZHHzNUoVhAqdF7Hrym2/VHCYMdMwTOSTDf1laR8dcRH99Jam88w== X-Received: by 2002:a2e:9110:0:b0:2d0:fd07:92a6 with SMTP id m16-20020a2e9110000000b002d0fd0792a6mr701803ljg.23.1707819158681; Tue, 13 Feb 2024 02:12:38 -0800 (PST) X-Forwarded-Encrypted: i=1; AJvYcCXB3I8AfDydWHH76SROuGLK5BSXCQQLRbCeQlqXFUeIyg06ERdNd1ZVmz3K3vzIfRTR+ZvckV8ML4pdIvcb5IyvIZrXmzSSkG2wGLs6KRlu5pQ+U2MrcImy09xk2q60b/3iBI/pNyydIzaXbqvAqpceBXvDJe1nbL6OR4/BJw== Original-Received: from smtpclient.apple (c80-217-1-132.bredband.tele2.se. [80.217.1.132]) by smtp.gmail.com with ESMTPSA id z7-20020a2e8e87000000b002d0f98bcd81sm421266ljk.107.2024.02.13.02.12.38 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Tue, 13 Feb 2024 02:12:38 -0800 (PST) In-Reply-To: X-Mailer: Apple Mail (2.3654.120.0.1.15) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:279952 Archived-At: 13 feb. 2024 kl. 10.05 skrev Gerd M=C3=B6llmann = : > I wonder, what does your code do for the places using (make-vector n = 0) > create obarrays? I'm not 100% sure, but I think Cedet was an example = of > that in Emacs itself. That code would still work, but just for completeness I changed all = those instances to using `obarray-make`, including cedet. (See the = branch scratch/obarray.) A more worrying problem is code that uses `obarray-make` but assumes the = result to be vectors. It may be unsafe to let obarray-make return an = obarray object for that reason. With Stefan's suggestion, if I = understood it right, we'd have `obarray-make` return (vector 0). I'll = give it a try.