From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Nicolas Petton Newsgroups: gmane.emacs.bugs Subject: bug#15519: 24.3; secrets.el `secrets-create-collection' is broken (fix included) Date: Wed, 02 Oct 2013 19:14:25 +0200 Message-ID: <1380734065.9521.12.camel@lingonberry> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit X-Trace: ger.gmane.org 1380832223 21845 80.91.229.3 (3 Oct 2013 20:30:23 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Thu, 3 Oct 2013 20:30:23 +0000 (UTC) To: 15519@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Thu Oct 03 22:30:26 2013 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1VRpXV-0003bl-P4 for geb-bug-gnu-emacs@m.gmane.org; Thu, 03 Oct 2013 22:30:25 +0200 Original-Received: from localhost ([::1]:45076 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VRpXV-0005W5-D1 for geb-bug-gnu-emacs@m.gmane.org; Thu, 03 Oct 2013 16:30:25 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:55504) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VRpXK-0005RZ-Se for bug-gnu-emacs@gnu.org; Thu, 03 Oct 2013 16:30:23 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VRpXC-0005yA-Ez for bug-gnu-emacs@gnu.org; Thu, 03 Oct 2013 16:30:14 -0400 Original-Received: from debbugs.gnu.org ([140.186.70.43]:44087) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VRpXC-0005y6-Ca for bug-gnu-emacs@gnu.org; Thu, 03 Oct 2013 16:30:06 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.80) (envelope-from ) id 1VRpXB-0006c0-3M for bug-gnu-emacs@gnu.org; Thu, 03 Oct 2013 16:30:05 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Nicolas Petton Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 03 Oct 2013 20:30:04 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 15519 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Original-Received: via spool by submit@debbugs.gnu.org id=B.138083215825313 (code B ref -1); Thu, 03 Oct 2013 20:30:04 +0000 Original-Received: (at submit) by debbugs.gnu.org; 3 Oct 2013 20:29:18 +0000 Original-Received: from localhost ([127.0.0.1]:52376 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1VRpWP-0006aC-52 for submit@debbugs.gnu.org; Thu, 03 Oct 2013 16:29:17 -0400 Original-Received: from eggs.gnu.org ([208.118.235.92]:56010) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1VRQ0j-00019J-H9 for submit@debbugs.gnu.org; Wed, 02 Oct 2013 13:14:53 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VRQ0b-0003yf-3R for submit@debbugs.gnu.org; Wed, 02 Oct 2013 13:14:53 -0400 Original-Received: from lists.gnu.org ([2001:4830:134:3::11]:56551) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VRQ0b-0003ya-04 for submit@debbugs.gnu.org; Wed, 02 Oct 2013 13:14:45 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:57712) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VRQ0S-00056E-Hh for bug-gnu-emacs@gnu.org; Wed, 02 Oct 2013 13:14:44 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VRQ0J-0003wA-Ob for bug-gnu-emacs@gnu.org; Wed, 02 Oct 2013 13:14:36 -0400 Original-Received: from mail-we0-x233.google.com ([2a00:1450:400c:c03::233]:41006) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VRQ0J-0003vo-Gs for bug-gnu-emacs@gnu.org; Wed, 02 Oct 2013 13:14:27 -0400 Original-Received: by mail-we0-f179.google.com with SMTP id x55so1311399wes.24 for ; Wed, 02 Oct 2013 10:14:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=message-id:subject:from:to:date:content-type:mime-version :content-transfer-encoding; bh=qnvrCXef5OjrY7Gs9BgQU5X8zLT7FLDH12GvyY3SoQo=; b=dP+NlqrQb4w5F9EpQIkHCFTCNWgieWqdV35F3ogh0IzCVywjiMnoJnO+x1mvWJayix kiZR4B8l1lPM96r7uGE1JxSiBIrHF+Pi0bTjXJTf3u0b7hBGEpWs3Ulm/sN+ICv88Deq XW5/emgAlltQ2de6hzZtZ+K4/SHM8XluJGSWVgSCYxCqk1tjENj3K9l1bYbgm4VxNxRY z5/whkALNKqWRHZTZxNVozODxlKS/JhyW0EpiBv1S46S+RNamcW8QR9KgY13nJBbF1hk pe65qvr1mWhLlRl7q9br8GeqzRmQhKfHEvyJKRRN8jhCStMxayZvSuHSk2xTjyzxB19m BPFg== X-Received: by 10.180.185.97 with SMTP id fb1mr3039925wic.61.1380734066550; Wed, 02 Oct 2013 10:14:26 -0700 (PDT) Original-Received: from [192.168.0.45] (hel59-4-88-160-125-31.fbx.proxad.net. [88.160.125.31]) by mx.google.com with ESMTPSA id dl10sm7430622wib.1.1969.12.31.16.00.00 (version=TLSv1 cipher=RC4-SHA bits=128/128); Wed, 02 Oct 2013 10:14:26 -0700 (PDT) X-Mailer: Evolution 3.10.0-0ubuntu1~saucy1 X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-Mailman-Approved-At: Thu, 03 Oct 2013 16:29:15 -0400 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:78903 Archived-At: In secrets.el, secrets-create-collection is broken (the DBus message signature is wrong and the collection label is not the right one). Here's a fixed version of the function: (defun secrets-create-collection (collection) "Create collection labeled COLLECTION if it doesn't exist. Return the D-Bus object path for collection." (let ((collection-path (secrets-collection-path collection))) ;; Create the collection. (when (secrets-empty-path collection-path) (setq collection-path (secrets-prompt (cadr ;; "CreateCollection" returns the prompt path as second arg. (dbus-call-method :session secrets-service secrets-path secrets-interface-service "CreateCollection" `(:array (:dict-entry "org.freedesktop.Secret.Collection.Label" (:variant ,collection))) ""))))) ;; Return object path of the collection. collection-path))