From: Nicolas Petton <petton.nicolas@gmail.com>
To: 15519@debbugs.gnu.org
Subject: bug#15519: 24.3; secrets.el `secrets-create-collection' is broken (fix included)
Date: Wed, 02 Oct 2013 19:14:25 +0200 [thread overview]
Message-ID: <1380734065.9521.12.camel@lingonberry> (raw)
In secrets.el, secrets-create-collection is broken (the DBus message
signature is wrong and the collection label is not the right one).
Here's a fixed version of the function:
(defun secrets-create-collection (collection)
"Create collection labeled COLLECTION if it doesn't exist.
Return the D-Bus object path for collection."
(let ((collection-path (secrets-collection-path collection)))
;; Create the collection.
(when (secrets-empty-path collection-path)
(setq collection-path
(secrets-prompt
(cadr
;; "CreateCollection" returns the prompt path as second arg.
(dbus-call-method
:session secrets-service secrets-path
secrets-interface-service "CreateCollection"
`(:array
(:dict-entry
"org.freedesktop.Secret.Collection.Label" (:variant ,collection)))
"")))))
;; Return object path of the collection.
collection-path))
reply other threads:[~2013-10-02 17:14 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1380734065.9521.12.camel@lingonberry \
--to=petton.nicolas@gmail.com \
--cc=15519@debbugs.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.