From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Brian Leung via "Bug reports for GNU Emacs, the Swiss army knife of text editors" Newsgroups: gmane.emacs.bugs Subject: bug#45797: 28.0.50; [PATCH]: Simplify comint-read-input-ring Date: Mon, 11 Jan 2021 20:20:04 +0100 (CET) Message-ID: <1374515308.96389.1610392804487@ichabod.co-bxl> Reply-To: Brian Leung , Brian Leung Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="----=_Part_96349_1550428200.1610392779197" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="31765"; mail-complaints-to="usenet@ciao.gmane.io" To: 45797@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Mon Jan 11 20:44:07 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kz36k-000883-Tt for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 11 Jan 2021 20:44:06 +0100 Original-Received: from localhost ([::1]:56028 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kz36j-0003m5-UR for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 11 Jan 2021 14:44:05 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:51196) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kz2kR-00062b-51 for bug-gnu-emacs@gnu.org; Mon, 11 Jan 2021 14:21:04 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:46760) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kz2kQ-0000iV-TM for bug-gnu-emacs@gnu.org; Mon, 11 Jan 2021 14:21:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1kz2kQ-0002yM-Oa for bug-gnu-emacs@gnu.org; Mon, 11 Jan 2021 14:21:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Brian Leung Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 11 Jan 2021 19:21:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 45797 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch X-Debbugs-Original-To: Bug Gnu Emacs Original-Received: via spool by submit@debbugs.gnu.org id=B.161039281911340 (code B ref -1); Mon, 11 Jan 2021 19:21:02 +0000 Original-Received: (at submit) by debbugs.gnu.org; 11 Jan 2021 19:20:19 +0000 Original-Received: from localhost ([127.0.0.1]:58306 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kz2jj-0002wo-7R for submit@debbugs.gnu.org; Mon, 11 Jan 2021 14:20:19 -0500 Original-Received: from lists.gnu.org ([209.51.188.17]:51364) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kz2jg-0002wc-P7 for submit@debbugs.gnu.org; Mon, 11 Jan 2021 14:20:18 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:51084) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kz2jg-0005Eu-Eq for bug-gnu-emacs@gnu.org; Mon, 11 Jan 2021 14:20:16 -0500 Original-Received: from wilbur.contactoffice.com ([212.3.242.68]:55266) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kz2jc-0000X6-Aw for bug-gnu-emacs@gnu.org; Mon, 11 Jan 2021 14:20:16 -0500 Original-Received: from ichabod.co-bxl (ichabod.co-bxl [10.2.0.36]) by wilbur.contactoffice.com (Postfix) with ESMTP id C89F4762 for ; Mon, 11 Jan 2021 20:20:07 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=mailfence.com; s=20160819-nLV10XS2; t=1610392807; bh=Ic7XcllCGBRbDBhjvygjUlH4qJBqhmPPVF7mz1qJIV0=; h=Date:To:Subject:Reply-To:From:From; b=tkhEPO/xdMuqqjRuWrnF05TTpySnpWPr/97Z+TZIqhsDE8XNB/NO5rvc28I5Gdp/7 qb5eyiOm7vwWwLXpvvKElTUB5JLh4fvjeTAaGib171y1S0HH5+Q87LqfOA3M1tonPY w0dUV48Z33siS2WqlMsZH6kW6D+h9gbcCBHnRQtL29zWc84lFp7sQ+TYrHihb7AlRm Qaw2pwh87cjzJsO7q4tY00dmJVyg2a86iuNWqxBYxF/TYMzn8xF0zADd+X6tV08XBa T1FN5PTRPPhSTDVhZPg74pQ8q0cxGsZNDIPvUoNoU1lcfwEddsI9BhbMaUtUfRNJQt zfhWCYSfW6Jvg== X-Priority: 3 X-Mailer: ContactOffice Mail X-ContactOffice-Account: com:225491745 Received-SPF: pass client-ip=212.3.242.68; envelope-from=leungbk@mailfence.com; helo=wilbur.contactoffice.com X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:197741 Archived-At: ------=_Part_96349_1550428200.1610392779197 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable See attached. --=C2=A0 Sent with https://mailfence.com Secure and private email ------=_Part_96349_1550428200.1610392779197 Content-Type: text/x-diff; charset=us-ascii; name=0001-comint-read-input-ring-Simplify-last-commit.patch Content-Transfer-Encoding: 7bit Content-Description: File Attachment: 0001-comint-read-input-ring-Simplify-last-commit.patch Content-Disposition: attachment; filename=0001-comint-read-input-ring-Simplify-last-commit.patch >From 7adf2a49d3b247f424b7a9c2fab24a82418bbb8e Mon Sep 17 00:00:00 2001 From: Brian Leung Date: Mon, 11 Jan 2021 11:09:30 -0800 Subject: [PATCH] comint-read-input-ring: Simplify last commit * lisp/comint.el (comint-read-input-ring): Simplify. It is not necessary to use `goto-char' again since we have already moved point to the desired location. --- lisp/comint.el | 1 - 1 file changed, 1 deletion(-) diff --git a/lisp/comint.el b/lisp/comint.el index 3476fd146c..53153af7d2 100644 --- a/lisp/comint.el +++ b/lisp/comint.el @@ -1000,7 +1000,6 @@ comint-read-input-ring (goto-char (match-end 0))) (setq start (point)) (setq history (buffer-substring start end)) - (goto-char start) (when (and (not (string-match history-ignore history)) (or (null ignoredups) (ring-empty-p ring) -- 2.29.2 ------=_Part_96349_1550428200.1610392779197--