all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
* bug#14238: [PATCH] Help page for character description forgets the character
@ 2013-04-21 11:38 Kelly Dean
  2013-04-22 14:26 ` Stefan Monnier
  0 siblings, 1 reply; 4+ messages in thread
From: Kelly Dean @ 2013-04-21 11:38 UTC (permalink / raw)
  To: 14238

[-- Attachment #1: Type: text/plain, Size: 307 bytes --]

On 24.3, emacs -Q
Type the letters AB, then put point on A. Do describe-char, then put point on B, and do describe-char again.
Change the A to C, the press [back] in *Help*.
The help page is now for C, not for A. It should be for A; you never did describe-char on C.
The attached descharbug.patch fixes it.

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: descharbug.patch --]
[-- Type: text/x-diff; name="descharbug.patch", Size: 1426 bytes --]

--- emacs-24.3/lisp/descr-text.el
+++ emacs-24.3/lisp/descr-text.el
@@ -670,8 +670,11 @@
                                             (if (cadr x) (length (car x)) 0))
                                           item-list)))
       (set-buffer src-buf)
-      (help-setup-xref (list 'describe-char pos buffer)
-                       (called-interactively-p 'interactive))
+      (describe-char-make-help multibyte-p max-width item-list overlays char-description disp-vector composition component-chars eight-bit-p char text-props-desc (called-interactively-p 'interactive)))))
+
+(defun describe-char-make-help (multibyte-p max-width item-list overlays char-description disp-vector composition component-chars eight-bit-p char text-props-desc interactive-p)
+      (help-setup-xref (list 'describe-char-make-help multibyte-p max-width item-list overlays char-description disp-vector composition component-chars eight-bit-p char text-props-desc nil)
+                       interactive-p)
       (with-help-window (help-buffer)
         (with-current-buffer standard-output
           (set-buffer-multibyte multibyte-p)
@@ -804,7 +807,7 @@
                             (format "  %s: %s\n" elt val)))))))
 
           (if text-props-desc (insert text-props-desc))
-          (setq buffer-read-only t))))))
+          (setq buffer-read-only t))))
 
 (define-obsolete-function-alias 'describe-char-after 'describe-char "22.1")
 

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2013-04-27  4:19 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-04-21 11:38 bug#14238: [PATCH] Help page for character description forgets the character Kelly Dean
2013-04-22 14:26 ` Stefan Monnier
2013-04-26 21:01   ` Kelly Dean
2013-04-27  4:19     ` Stefan Monnier

Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.