From: Kelly Dean <kellydeanch@yahoo.com>
To: 14238@debbugs.gnu.org
Subject: bug#14238: [PATCH] Help page for character description forgets the character
Date: Sun, 21 Apr 2013 04:38:21 -0700 (PDT) [thread overview]
Message-ID: <1366544301.44150.YahooMailClassic@web141106.mail.bf1.yahoo.com> (raw)
[-- Attachment #1: Type: text/plain, Size: 307 bytes --]
On 24.3, emacs -Q
Type the letters AB, then put point on A. Do describe-char, then put point on B, and do describe-char again.
Change the A to C, the press [back] in *Help*.
The help page is now for C, not for A. It should be for A; you never did describe-char on C.
The attached descharbug.patch fixes it.
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: descharbug.patch --]
[-- Type: text/x-diff; name="descharbug.patch", Size: 1426 bytes --]
--- emacs-24.3/lisp/descr-text.el
+++ emacs-24.3/lisp/descr-text.el
@@ -670,8 +670,11 @@
(if (cadr x) (length (car x)) 0))
item-list)))
(set-buffer src-buf)
- (help-setup-xref (list 'describe-char pos buffer)
- (called-interactively-p 'interactive))
+ (describe-char-make-help multibyte-p max-width item-list overlays char-description disp-vector composition component-chars eight-bit-p char text-props-desc (called-interactively-p 'interactive)))))
+
+(defun describe-char-make-help (multibyte-p max-width item-list overlays char-description disp-vector composition component-chars eight-bit-p char text-props-desc interactive-p)
+ (help-setup-xref (list 'describe-char-make-help multibyte-p max-width item-list overlays char-description disp-vector composition component-chars eight-bit-p char text-props-desc nil)
+ interactive-p)
(with-help-window (help-buffer)
(with-current-buffer standard-output
(set-buffer-multibyte multibyte-p)
@@ -804,7 +807,7 @@
(format " %s: %s\n" elt val)))))))
(if text-props-desc (insert text-props-desc))
- (setq buffer-read-only t))))))
+ (setq buffer-read-only t))))
(define-obsolete-function-alias 'describe-char-after 'describe-char "22.1")
next reply other threads:[~2013-04-21 11:38 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-04-21 11:38 Kelly Dean [this message]
2013-04-22 14:26 ` bug#14238: [PATCH] Help page for character description forgets the character Stefan Monnier
2013-04-26 21:01 ` Kelly Dean
2013-04-27 4:19 ` Stefan Monnier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1366544301.44150.YahooMailClassic@web141106.mail.bf1.yahoo.com \
--to=kellydeanch@yahoo.com \
--cc=14238@debbugs.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.