From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Kelly Dean Newsgroups: gmane.emacs.bugs Subject: bug#14225: [PATCH] Winner mode fails to run mark activation and deactivation hooks Date: Wed, 17 Apr 2013 20:17:33 -0700 (PDT) Message-ID: <1366255053.95181.YahooMailClassic@web141101.mail.bf1.yahoo.com> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="844607989-528228110-1366255053=:95181" X-Trace: ger.gmane.org 1366255122 4888 80.91.229.3 (18 Apr 2013 03:18:42 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Thu, 18 Apr 2013 03:18:42 +0000 (UTC) To: 14225@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Thu Apr 18 05:18:46 2013 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1USfMz-0007a3-HS for geb-bug-gnu-emacs@m.gmane.org; Thu, 18 Apr 2013 05:18:45 +0200 Original-Received: from localhost ([::1]:36407 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1USfMz-0002Ql-0F for geb-bug-gnu-emacs@m.gmane.org; Wed, 17 Apr 2013 23:18:45 -0400 Original-Received: from eggs.gnu.org ([208.118.235.92]:60187) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1USfMu-0002Qc-2D for bug-gnu-emacs@gnu.org; Wed, 17 Apr 2013 23:18:42 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1USfMr-0003PW-2E for bug-gnu-emacs@gnu.org; Wed, 17 Apr 2013 23:18:40 -0400 Original-Received: from debbugs.gnu.org ([140.186.70.43]:53575) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1USfMq-0003PS-VM for bug-gnu-emacs@gnu.org; Wed, 17 Apr 2013 23:18:36 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.72) (envelope-from ) id 1USfR8-0004rf-Kp for bug-gnu-emacs@gnu.org; Wed, 17 Apr 2013 23:23:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Kelly Dean Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 18 Apr 2013 03:23:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 14225 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Original-Received: via spool by submit@debbugs.gnu.org id=B.136625533218609 (code B ref -1); Thu, 18 Apr 2013 03:23:02 +0000 Original-Received: (at submit) by debbugs.gnu.org; 18 Apr 2013 03:22:12 +0000 Original-Received: from localhost ([127.0.0.1]:57684 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1USfQK-0004q3-Aw for submit@debbugs.gnu.org; Wed, 17 Apr 2013 23:22:12 -0400 Original-Received: from eggs.gnu.org ([208.118.235.92]:48680) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1USfQH-0004pv-C9 for submit@debbugs.gnu.org; Wed, 17 Apr 2013 23:22:10 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1USfLw-0003Hg-N1 for submit@debbugs.gnu.org; Wed, 17 Apr 2013 23:17:42 -0400 Original-Received: from lists.gnu.org ([208.118.235.17]:45954) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1USfLw-0003Hc-J2 for submit@debbugs.gnu.org; Wed, 17 Apr 2013 23:17:40 -0400 Original-Received: from eggs.gnu.org ([208.118.235.92]:60028) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1USfLu-0002NK-0Q for bug-gnu-emacs@gnu.org; Wed, 17 Apr 2013 23:17:40 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1USfLr-0003Gl-5x for bug-gnu-emacs@gnu.org; Wed, 17 Apr 2013 23:17:37 -0400 Original-Received: from nm35-vm9.bullet.mail.bf1.yahoo.com ([72.30.239.59]:39969) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1USfLq-0003Gd-TF for bug-gnu-emacs@gnu.org; Wed, 17 Apr 2013 23:17:35 -0400 Original-Received: from [98.139.214.32] by nm35.bullet.mail.bf1.yahoo.com with NNFMP; 18 Apr 2013 03:17:33 -0000 Original-Received: from [98.139.212.249] by tm15.bullet.mail.bf1.yahoo.com with NNFMP; 18 Apr 2013 03:17:33 -0000 Original-Received: from [127.0.0.1] by omp1058.mail.bf1.yahoo.com with NNFMP; 18 Apr 2013 03:17:33 -0000 X-Yahoo-Newman-Property: ymail-5 X-Yahoo-Newman-Id: 570761.11172.bm@omp1058.mail.bf1.yahoo.com Original-Received: (qmail 38846 invoked by uid 60001); 18 Apr 2013 03:17:33 -0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s1024; t=1366255053; bh=/f+FPV+MnubkNE6+YLk729SH4pwvjWuLYI8gBcsrLwc=; h=X-YMail-OSG:Received:X-Rocket-MIMEInfo:X-Mailer:Message-ID:Date:From:Subject:To:MIME-Version:Content-Type; b=X1+ThmWZE4IqjHLXNyDcwFPNEUoKCI/sYEfIoBsHNBiTKxvxTDvqjNBbprNR6S2uUkcYR8cA6jkSKhJKVnKwPvdz6wnxktXtDLzw5Rfk9Shz9BdbG7P1VQ9V7ykZOmfpyQCuBg1S27tFix1JlFzyETuPYYeMsTZNu4kyp5PMMM4= DomainKey-Signature: a=rsa-sha1; q=dns; c=nofws; s=s1024; d=yahoo.com; h=X-YMail-OSG:Received:X-Rocket-MIMEInfo:X-Mailer:Message-ID:Date:From:Subject:To:MIME-Version:Content-Type; b=X+I1lq2AWu79Pf3aZ0VcffyJR4rsirl8pTCltAQz1EHmPK5Ne+L1uLWjY9p6q45Dhak5QWJV09jb2Y7Nj7ZFHjCVi8IOhvPAKcB1sC6+OhQW0dAzMfrlN/ODlNezS3aQgxoD0yV6NsJDNR65Gxqg13uxBcwAiBJnGrfzPZmS4cI=; X-YMail-OSG: ISIgZ70VM1lNdDxxA76Ob9qDa574U20tN5ofJR5C4DRqeEa 1hq2f690e0oe_Ne2q6zo6o6HqLQ2Q04pxUDrRW7RsRmTUPGhUuIlIcdVLq8x ibNk6SdD7Gh6aq1rd4x86IbXeps1gdgg4DT3SwgxFnrTJYmr0ttOHe5U__1g 6vSR6Qj.tiwI_Ch5_T0856U2pAq70PXIJqNkL3DW5ZMufr0kjCAUbUED61bp 3djqj6xlbJcwIEtUd3LtJ97_wPg.xMKBxyiriaAQmZ1LshBd7MaBIpaflmuL 47XItnFsC0pHE16DCfowirWZ2YVe8PkeFwzXUIvogLcbX1hcMZgjm4k6zxQP ZCkP4FavXlERHwFZa01TduBX38XoOesIwoqawwd8hBlfG37MGk64V7YhM.Ew tp_jInnKD6arXdlTWkHT2OiFBptEWEfmKH2dZ0JCQuKBfW_DMq.EBkwfXJVO DE5vS1FeYAUuaFcq9BlZ1nm52IhIPWjs- Original-Received: from [62.75.138.125] by web141101.mail.bf1.yahoo.com via HTTP; Wed, 17 Apr 2013 20:17:33 PDT X-Rocket-MIMEInfo: 002.001, VXNpbmcgRW1hY3MgMjQuMwplbWFjcyAtUQood2lubmVyLW1vZGUgMSkKKGFkZC1ob29rICdkZWFjdGl2YXRlLW1hcmstaG9vayAobGFtYmRhICgpIChzZXRxIGN1cnNvci10eXBlIHQpKSkKKGFkZC1ob29rICdhY3RpdmF0ZS1tYXJrLWhvb2sgKGxhbWJkYSAoKSAoc2V0cSBjdXJzb3ItdHlwZSAnYmFyKSkpCkMteCAyCkMtYyBsZWZ0CgpOb3RpY2UgdGhhdCB0aGUgY3Vyc29yIHR5cGUgaXMgbm93IGEgYmFyLCBub3QgYSBibG9jay4gSXQgc2hvdWxkIGJlIGEgYmxvY2suClRoZSBhdHRhY2hlZCB3aW5uZXJidWcBMAEBAQE- X-Mailer: YahooMailClassic/15.1.7 YahooMailWebService/0.8.140.532 X-detected-operating-system: by eggs.gnu.org: FreeBSD 8.x X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:73483 Archived-At: --844607989-528228110-1366255053=:95181 Content-Type: text/plain; charset=us-ascii Using Emacs 24.3 emacs -Q (winner-mode 1) (add-hook 'deactivate-mark-hook (lambda () (setq cursor-type t))) (add-hook 'activate-mark-hook (lambda () (setq cursor-type 'bar))) C-x 2 C-c left Notice that the cursor type is now a bar, not a block. It should be a block. The attached winnerbug.patch fixes it. BTW, by default in Emacs, when the region is active but empty, there's no visual indication of this status. Neither is there indication of the active region if point is one less than mark and blink-cursor-mode is off. Also, if point is greater than mark, the active region is highlighted, but the block cursor does an inverse-video highlight of the character following the region, which (speaking from experience) an Emacs newbie finds distracting, since it seems to indicate that that character is also part of the region. Setting the cursor type to bar when the region is active solves all those problems, and I recommend it as the default for Emacs. --844607989-528228110-1366255053=:95181 Content-Type: text/x-diff; name="winnerbug.patch" Content-Transfer-Encoding: base64 Content-Disposition: attachment; filename="winnerbug.patch" LS0tIGVtYWNzLTI0LjMvbGlzcC93aW5uZXIuZWwKKysrIGVtYWNzLTI0LjMv bGlzcC93aW5uZXIuZWwKQEAgLTMwOSw3ICszMDksOSBAQAogICAgICAgICAg ICAgICAgICBmb3IgZW50cnkgPSAoY2FkciAoYXNzcSBidWYgd2lubmVyLXBv aW50LWFsaXN0KSkKICAgICAgICAgICAgICAgICAgZG8gKHByb2duIChzZXQt YnVmZmVyIGJ1ZikKICAgICAgICAgICAgICAgICAgICAgICAgICAgIChzZXQt bWFyayAoY2FyIGVudHJ5KSkKLSAgICAgICAgICAgICAgICAgICAgICAgICAg IChzZXRmICh3aW5uZXItYWN0aXZlLXJlZ2lvbikgKGNkciBlbnRyeSkpKSkp CisgICAgICAgICAgICAgICAgICAgICAgICAgICAoc2V0ZiAod2lubmVyLWFj dGl2ZS1yZWdpb24pIChjZHIgZW50cnkpKQorCQkJICAgKGlmIChjZHIgZW50 cnkpIChydW4taG9va3MgJ2FjdGl2YXRlLW1hcmstaG9vaykKKwkJCSAgICAg KHJ1bi1ob29rcyAnZGVhY3RpdmF0ZS1tYXJrLWhvb2spKSkpKQogICAgICAg OzsgRGVsZXRlIHdpbmRvd3MsIHdob3NlIGJ1ZmZlcnMgYXJlIGRlYWQgb3Ig Ym9yaW5nLgogICAgICAgOzsgUmV0dXJuIHQgaWYgdGhpcyBpcyBzdGlsbCBh IHBvc3NpYmxlIGNvbmZpZ3VyYXRpb24uCiAgICAgICAob3IgKG51bGwgeHdp bnMpCg== --844607989-528228110-1366255053=:95181--