all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Brian Leung via "Bug reports for GNU Emacs, the Swiss army knife of text editors" <bug-gnu-emacs@gnu.org>
To: Lars Ingebrigtsen <larsi@gnus.org>, Eli Zaretskii <eliz@gnu.org>
Cc: rpluim@gmail.com, 43117@debbugs.gnu.org, dgutov@yandex.ru
Subject: bug#43117: [PATCH] Add .git-blame-ignore-revs file
Date: Sun, 13 Sep 2020 20:49:06 +0200 (CEST)	[thread overview]
Message-ID: <1357196034.463572.1600022946152@ichabod.co-bxl> (raw)
In-Reply-To: <87363lh856.fsf@gnus.org>

[-- Attachment #1: Type: text/plain, Size: 1347 bytes --]

> I don't think these purely
> stylistic rewrites are a good idea, as it means that "git blame" and
> vc-region-history gets less useful, and applying older patches fails
> more often.

OK, I won't submit that commit then. The other commit I had introduced a .git-blame-ignore-revs file, which allows certain commits to be ignored during git-blame sessions. I've modified that commit accordingly and attached. Would that be of use?

My FSF papers are attached.

> ----------------------------------------
> From: Lars Ingebrigtsen <larsi@gnus.org>
> Sent: Sun Sep 13 19:57:25 CEST 2020
> To: Eli Zaretskii <eliz@gnu.org>
> Cc: Brian Leung <leungbk@mailfence.com>, <rpluim@gmail.com>, <dgutov@yandex.ru>, <43117@debbugs.gnu.org>
> Subject: Re: bug#43117: [PATCH] Add .git-blame-ignore-revs file
> 
> 
> Eli Zaretskii <eliz@gnu.org> writes:
> 
> > Is it just me? do others think such changes are a good idea?
> 
> I hate one-form-`if' more than anybody, but I don't think these purely
> stylistic rewrites are a good idea, as it means that "git blame" and
> vc-region-history gets less useful, and applying older patches fails
> more often.
> 
> -- 
> (domestic pets only, the antidote for overdose, milk.)
>    bloggy blog: http://lars.ingebrigtsen.no


-- 
Sent with https://mailfence.com
Secure and private email

[-- Attachment #2: File Attachment: 0001-Add-.git-blame-ignore-revs-file.patch --]
[-- Type: text/x-diff, Size: 1454 bytes --]

From 46b647d2fea41b3d0d3fcd2fa6f92795da967d75 Mon Sep 17 00:00:00 2001
From: Brian Leung <leungbk@mailfence.com>
Date: Sun, 13 Sep 2020 11:42:31 -0700
Subject: [PATCH] Add .git-blame-ignore-revs file

Git 2.23 introduced the ability to use a file to selectively ignore
certain commits during blame sessions.
---
 .git-blame-ignore-revs | 27 +++++++++++++++++++++++++++
 1 file changed, 27 insertions(+)
 create mode 100644 .git-blame-ignore-revs

diff --git a/.git-blame-ignore-revs b/.git-blame-ignore-revs
new file mode 100644
index 0000000000..52cf967eff
--- /dev/null
+++ b/.git-blame-ignore-revs
@@ -0,0 +1,27 @@
+# Configure git to ignore commits listed in this file with:
+#
+#   git config blame.ignoreRevsFile .git-blame-ignore-revs
+
+# ; tiny indentation fix to lisp/progmodes/elisp-mode.el
+bf018eefa2a9c33f9f80e977ee085e89df526992
+
+# ; Fix typos
+a3ca5318760b350309e50adf38fabc259c48ba06
+
+# ; Fix typos in etc/NEWS
+a6b45145824043eb0c049270ef37e64f1a677b4e
+
+# ; * lisp/textmodes/flyspell.el (flyspell-mode-on): Fix typo.
+f8082a5ccae11508c7eb80ca4d9fabb341985419
+
+# ; * lisp/info.el (Info-up): Fix a typo in a comment.
+478c2e23620eeda65030458762a843231f7e9b35
+
+# ; Fix typos; change "Emacs-Lisp" to "Emacs Lisp"
+abca75d2e9b2a406157383dfb7fe3f185e0b5741
+
+# ; * lisp/man.el (Man-mode): Fix formatting.
+9b35b0c99ceaeca74a16bea86a665ae5f44430a1
+
+# ; Fix typo in last change
+60cb56e9999050740f4b987ccb806ee6e8227c07
-- 
2.28.0


[-- Attachment #3: File Attachment: leung.tar.gz --]
[-- Type: application/x-gzip, Size: 148289 bytes --]

  reply	other threads:[~2020-09-13 18:49 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-08-30 17:46 bug#43117: [PATCH] Add .git-blame-ignore-revs file Brian Leung via Bug reports for GNU Emacs, the Swiss army knife of text editors
2020-08-31 10:16 ` Robert Pluim
2020-08-31 20:11   ` Dmitry Gutov
2020-08-31 20:34     ` Robert Pluim
2020-08-31 20:45       ` Dmitry Gutov
2020-08-31 20:57         ` Robert Pluim
2020-08-31 21:03           ` Dmitry Gutov
2020-09-13  0:42             ` Brian Leung via Bug reports for GNU Emacs, the Swiss army knife of text editors
2020-09-13 14:07               ` Eli Zaretskii
2020-09-13 17:06                 ` Brian Leung via Bug reports for GNU Emacs, the Swiss army knife of text editors
2020-09-13 17:34                   ` Eli Zaretskii
2020-09-13 17:57                     ` Lars Ingebrigtsen
2020-09-13 18:49                       ` Brian Leung via Bug reports for GNU Emacs, the Swiss army knife of text editors [this message]
2020-10-18 17:03                         ` Stefan Kangas
2020-10-18 17:18                           ` Eli Zaretskii
2020-10-18 17:54                             ` Stefan Kangas
2020-10-18 17:59                               ` Eli Zaretskii
2020-10-18 18:25                                 ` Stefan Kangas
2020-10-18 18:41                                   ` Eli Zaretskii
2020-10-19 16:06                                     ` Stefan Kangas
2020-10-19 16:40                                       ` Eli Zaretskii
2020-10-20 10:38                                         ` Lars Ingebrigtsen
2020-10-20 12:05                                           ` Stefan Kangas
2021-03-12  1:07                                             ` Stefan Kangas

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1357196034.463572.1600022946152@ichabod.co-bxl \
    --to=bug-gnu-emacs@gnu.org \
    --cc=43117@debbugs.gnu.org \
    --cc=dgutov@yandex.ru \
    --cc=eliz@gnu.org \
    --cc=larsi@gnus.org \
    --cc=leungbk@mailfence.com \
    --cc=rpluim@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.