From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Kelly Dean Newsgroups: gmane.emacs.bugs Subject: bug#13169: [PATCH] kill-region fails to deactivate mark after cutting empty region Date: Thu, 13 Dec 2012 00:19:16 -0800 (PST) Message-ID: <1355386756.25768.YahooMailClassic@web141106.mail.bf1.yahoo.com> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="1234169369-984943936-1355386756=:25768" X-Trace: ger.gmane.org 1355386820 18864 80.91.229.3 (13 Dec 2012 08:20:20 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Thu, 13 Dec 2012 08:20:20 +0000 (UTC) To: 13169@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Thu Dec 13 09:20:35 2012 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1Tj41y-0004Lh-IG for geb-bug-gnu-emacs@m.gmane.org; Thu, 13 Dec 2012 09:20:34 +0100 Original-Received: from localhost ([::1]:48697 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Tj41l-0001mF-F4 for geb-bug-gnu-emacs@m.gmane.org; Thu, 13 Dec 2012 03:20:21 -0500 Original-Received: from eggs.gnu.org ([208.118.235.92]:48967) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Tj41e-0001lE-A9 for bug-gnu-emacs@gnu.org; Thu, 13 Dec 2012 03:20:18 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Tj41b-0002y7-KB for bug-gnu-emacs@gnu.org; Thu, 13 Dec 2012 03:20:14 -0500 Original-Received: from debbugs.gnu.org ([140.186.70.43]:57915) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Tj41b-0002xq-GI for bug-gnu-emacs@gnu.org; Thu, 13 Dec 2012 03:20:11 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.72) (envelope-from ) id 1Tj42P-0004x2-U1 for bug-gnu-emacs@gnu.org; Thu, 13 Dec 2012 03:21:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Kelly Dean Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 13 Dec 2012 08:21:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 13169 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Original-Received: via spool by submit@debbugs.gnu.org id=B.135538682318957 (code B ref -1); Thu, 13 Dec 2012 08:21:01 +0000 Original-Received: (at submit) by debbugs.gnu.org; 13 Dec 2012 08:20:23 +0000 Original-Received: from localhost ([127.0.0.1]:39933 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1Tj41n-0004vi-54 for submit@debbugs.gnu.org; Thu, 13 Dec 2012 03:20:23 -0500 Original-Received: from eggs.gnu.org ([208.118.235.92]:37537) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1Tj41k-0004vV-6R for submit@debbugs.gnu.org; Thu, 13 Dec 2012 03:20:21 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Tj40q-0002XY-VQ for submit@debbugs.gnu.org; Thu, 13 Dec 2012 03:19:28 -0500 Original-Received: from lists.gnu.org ([208.118.235.17]:58270) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Tj40q-0002XS-RX for submit@debbugs.gnu.org; Thu, 13 Dec 2012 03:19:24 -0500 Original-Received: from eggs.gnu.org ([208.118.235.92]:48876) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Tj40o-0001fV-53 for bug-gnu-emacs@gnu.org; Thu, 13 Dec 2012 03:19:24 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Tj40k-0002N7-Dv for bug-gnu-emacs@gnu.org; Thu, 13 Dec 2012 03:19:21 -0500 Original-Received: from nm23-vm0.bullet.mail.bf1.yahoo.com ([98.139.212.191]:40490) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Tj40k-0002Jh-8P for bug-gnu-emacs@gnu.org; Thu, 13 Dec 2012 03:19:18 -0500 Original-Received: from [98.139.212.148] by nm23.bullet.mail.bf1.yahoo.com with NNFMP; 13 Dec 2012 08:19:16 -0000 Original-Received: from [98.139.212.229] by tm5.bullet.mail.bf1.yahoo.com with NNFMP; 13 Dec 2012 08:19:16 -0000 Original-Received: from [127.0.0.1] by omp1038.mail.bf1.yahoo.com with NNFMP; 13 Dec 2012 08:19:16 -0000 X-Yahoo-Newman-Property: ymail-3 X-Yahoo-Newman-Id: 680007.64961.bm@omp1038.mail.bf1.yahoo.com Original-Received: (qmail 25810 invoked by uid 60001); 13 Dec 2012 08:19:16 -0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s1024; t=1355386756; bh=dIhspwV2FGXyEv+m0ND8FFGep+d7ozu8+x6qPwsct14=; h=X-YMail-OSG:Received:X-Rocket-MIMEInfo:X-Mailer:Message-ID:Date:From:Subject:To:MIME-Version:Content-Type; b=RMhnMfS9vZ1ky4/r3aTNF0SsoGr6Awiq6d8juTs/G7HroxeDK8qVgvx2TXby2pFDPq27I/kIJ4TyXaqUSnVHhyGZJ/mOzst1Ps7e9kUPqavTOCo4az0BtJhok1QVGJrpYtSPe/LZXCFx3ohceK0H4umn4J56rtg4DOJT6IzEU6k= DomainKey-Signature: a=rsa-sha1; q=dns; c=nofws; s=s1024; d=yahoo.com; h=X-YMail-OSG:Received:X-Rocket-MIMEInfo:X-Mailer:Message-ID:Date:From:Subject:To:MIME-Version:Content-Type; b=PTKUiSwo5KI6pixbb2E7sJHtcLDoBHNF+7usga3PHS9uaWP1Yahm0fmZLuS5YYyyjEBN/1LWv5VwgoZhGIixyhbJJYCD0Mr8lXO693CrbbGUrCUo+/SqxdFd70mObiFlKTe5uIHtFq9aFIS1VXbOXZx7PZKjg5TP2sbKXqTrIpk=; X-YMail-OSG: 4R1kxdAVM1nPoFPNoitCRVKZzS05vkiOIM7Htv6jqDF3NEg MZ_su5E3yE1Ih396XZ81Bw3Z9OH9T2A2SjiuQYblz9RH3vKMGdVkRhmUzxCj LA_lQz0FTr0mc0NpXHsz9hOCamKp5riQraDFibQrIhj1pg2pxQAbOdj8Gd24 GkFqqtRqdr4jpWXLdbq_zI.ONH9Ic.ddAV5pkX1cOejJmzV_hPzS4YR.b1sd tIBSW9BxJuZIDnPFIdumRl4_a9fgexUNPIV22TE7tOlhlkMLsext6RbsR5Pl N5L9vp7zmmW4VVyFWZrM2iMF_KCqxlco3O0M6bqZNS0QNWKB7W1tIImlIt2V W8IIH3837kyAmfQyntRWu0S2C5iD3A.MmOBTDGqtWb5AlvRWffbaq5tVhCdR djAG_eXq_sKosd1tIoE.42MBYRJiPkRpUHeez6vOtovygRRJD.GeMag-- Original-Received: from [96.44.189.100] by web141106.mail.bf1.yahoo.com via HTTP; Thu, 13 Dec 2012 00:19:16 PST X-Rocket-MIMEInfo: 001.001, T24gMjQuMiwgZW1hY3MgLVEKQy1TUEMgTS13IEMtcApraWxsLXJpbmctc2F2ZSBjb3BpZWQgYW4gZW1wdHkgcmVnaW9uLCBhbmQgZGVhY3RpdmF0ZWQgdGhlIG1hcmsuIFRoaXMgaXMgY29ycmVjdC4gQnV0IG5vdyBkbwpDLVNQQyBDLXcgQy1wCmtpbGwtcmVnaW9uIGN1dCBhbiBlbXB0eSByZWdpb24sIHdoaWNoIGlzIGNvcnJlY3QsIGJ1dCB0aGUgbWFyayBpcyBzdGlsbCBhY3RpdmUsIHdoaWNoIGlzIGluY29ycmVjdC4gV2hlbiB0aGUgYnVmZmVyIGFuZCB0ZXh0IGFyZW4ndCByZWFkLW9ubHksIGtpbGwtcmUBMAEBAQE- X-Mailer: YahooMailClassic/15.1.1 YahooMailWebService/0.8.128.478 X-detected-operating-system: by eggs.gnu.org: FreeBSD 8.x X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:68444 Archived-At: --1234169369-984943936-1355386756=:25768 Content-Type: text/plain; charset=us-ascii On 24.2, emacs -Q C-SPC M-w C-p kill-ring-save copied an empty region, and deactivated the mark. This is correct. But now do C-SPC C-w C-p kill-region cut an empty region, which is correct, but the mark is still active, which is incorrect. When the buffer and text aren't read-only, kill-region relies on the command loop to deactivate the mark after the buffer is modified, but when cutting an empty region, the buffer isn't modified, so the mark is never deactivated. The attached killregionbug.patch fixes it. --1234169369-984943936-1355386756=:25768 Content-Type: text/x-diff; name="killregionbug.patch" Content-Transfer-Encoding: base64 Content-Disposition: attachment; filename="killregionbug.patch" LS0tIGVtYWNzLTI0LjIvbGlzcC9zaW1wbGUuZWwJMjAxMi0wOC0yMiAyMjoz Mzo0Mi4wMDAwMDAwMDAgLTA3MDAKKysrIGVtYWNzLTI0LjIvbGlzcC9zaW1w bGUuZWwubmV3MgkyMDEyLTEyLTEyIDIyOjUyOjQ2LjI1ODQ2MjMwNiAtMDgw MApAQCAtMzIzMyw2ICszMjMzLDcgQEAKIAkgICAgKGtpbGwtbmV3IHN0cmlu ZyBuaWwgeWFuay1oYW5kbGVyKSkpCiAJKHdoZW4gKG9yIHN0cmluZyAoZXEg bGFzdC1jb21tYW5kICdraWxsLXJlZ2lvbikpCiAJICAoc2V0cSB0aGlzLWNv bW1hbmQgJ2tpbGwtcmVnaW9uKSkKKwkoc2V0cSBkZWFjdGl2YXRlLW1hcmsg dCkKIAluaWwpCiAgICAgKChidWZmZXItcmVhZC1vbmx5IHRleHQtcmVhZC1v bmx5KQogICAgICA7OyBUaGUgY29kZSBhYm92ZSBmYWlsZWQgYmVjYXVzZSB0 aGUgYnVmZmVyLCBvciBzb21lIG9mIHRoZSBjaGFyYWN0ZXJzCg== --1234169369-984943936-1355386756=:25768--