From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Dmitry Gutov Newsgroups: gmane.emacs.devel Subject: Re: master ad442b8: Make all vc-*-responsible-p functions return a string Date: Mon, 15 Nov 2021 16:21:24 +0300 Message-ID: <13513403-1f79-de43-6eb8-96e3bc6371a8@yandex.ru> References: <20211114013858.24577.64348@vcs0.savannah.gnu.org> <20211114013900.254D7209C6@vcs0.savannah.gnu.org> <87pmr386yi.fsf@gnus.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="4947"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.13.0 Cc: Emacs developers To: Lars Ingebrigtsen , Stefan Kangas Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Mon Nov 15 14:23:13 2021 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mmbx3-00013O-J3 for ged-emacs-devel@m.gmane-mx.org; Mon, 15 Nov 2021 14:23:13 +0100 Original-Received: from localhost ([::1]:36418 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mmbx2-0007WJ-F2 for ged-emacs-devel@m.gmane-mx.org; Mon, 15 Nov 2021 08:23:12 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:59352) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mmbvV-0005vm-90 for emacs-devel@gnu.org; Mon, 15 Nov 2021 08:21:37 -0500 Original-Received: from [2a00:1450:4864:20::133] (port=40560 helo=mail-lf1-x133.google.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mmbvT-0001CX-5K for emacs-devel@gnu.org; Mon, 15 Nov 2021 08:21:37 -0500 Original-Received: by mail-lf1-x133.google.com with SMTP id l22so43507664lfg.7 for ; Mon, 15 Nov 2021 05:21:34 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=sender:subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=kEjEDNmpr0cjiwC9aP6OQg3Ih4WdHYQmKGpCJ6mp3Xo=; b=gRXUAaOu6sGwk+ilsDBKCXsdgENOP2yIp3XH6L+weTea/SeaXIoOUVkhQ5DwPmcT4O HRPN3WCo7f4xeU0mheyo3bydms2vC9dbUGc9sr7VYN6N56FEWlZMKPqs6MFEAQ1Z3OeU oajWoWuC7F7UCot70Kj63LzFYJXzFbR3aN70Q6Q30mpEtDKXgoCTAofjl9MHnOFDtnnT AOBGX1eiWam5Na8nAW9jHEObD/JRo2GcEEjB3VY6k4FxqXpgSijaZdfjAO48cZRncPj8 +2WY+7xokPjZQxznE89wN+Z8zz5uvstcTu9bBkPqliuJqBwimgcMggNILsiIeq6/mKrF oLBg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:sender:subject:to:cc:references:from:message-id :date:user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=kEjEDNmpr0cjiwC9aP6OQg3Ih4WdHYQmKGpCJ6mp3Xo=; b=E39UBJ9rjuoNEivDDFG62Tz3LZAEVIJc+hm/f2IQ29rB8ilkDPK9jmuz2z3PUFe0UO fDq1loepi9InVCZqiFi3f3C1ahyB8d00GORiZnIJ3oSOKuJytRBEZCelwqULp+WVUcD7 9spI5B6teZqwKGufJPv2KQ7Z6oSv+vJXwElPcTzppsxEzHqQ9uukU0J1MJ7LHigu4HCR TjEK2gsLHqLqZR0y2wEiRz4TSVTsVfsjiuOCM3wioSh83asgE0gMrBXZzgSxdIcFqAEa lqhIAIDJ6r7+qLEln7vDN606yDC7dpjs534cn/riaIDizf8j9wMhM/HLXcEi6q4FZRqx o3Iw== X-Gm-Message-State: AOAM5301JJNjY5NzjGZKywVilulQDrjXMqufkDeJn+JiSdkLJtjYzL2z HVXIgq+OBy2Cajbzxl7Il668cHJf7Ag= X-Google-Smtp-Source: ABdhPJwz6P6uMrvs9873NEjSh+tXn5Bow1UVeZFZ6b/Ihv6AJWpFeJO3LtC+oiLNDiUFf06/Vj5SYw== X-Received: by 2002:a05:6512:3da9:: with SMTP id k41mr32385195lfv.563.1636982493346; Mon, 15 Nov 2021 05:21:33 -0800 (PST) Original-Received: from [192.168.0.103] ([5.18.235.131]) by smtp.googlemail.com with ESMTPSA id x12sm1414931lfa.243.2021.11.15.05.21.32 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 15 Nov 2021 05:21:32 -0800 (PST) In-Reply-To: <87pmr386yi.fsf@gnus.org> Content-Language: en-US X-Host-Lookup-Failed: Reverse DNS lookup failed for 2a00:1450:4864:20::133 (failed) Received-SPF: pass client-ip=2a00:1450:4864:20::133; envelope-from=raaahh@gmail.com; helo=mail-lf1-x133.google.com X-Spam_score_int: -29 X-Spam_score: -3.0 X-Spam_bar: --- X-Spam_report: (-3.0 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FORGED_FROMDOMAIN=0.25, FREEMAIL_FROM=0.001, HEADER_FROM_DIFFERENT_DOMAINS=0.25, NICE_REPLY_A=-2.278, PDS_HP_HELO_NORDNS=0.001, RCVD_IN_DNSWL_NONE=-0.0001, RDNS_NONE=0.793, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:279501 Archived-At: On 14.11.2021 11:41, Lars Ingebrigtsen wrote: > Stefan Kangas writes: > >> I believe this broke a test: >> >> 1 unexpected results: >> FAILED vc-test-cvs01-register > Yup. Should be fixed now. FWIW, -responsible-p is documented to return non-nil rather than a particular string, at the top of vc.el. So it was the previous change that was (osensibly) broken, since we'd generally use vc-root-dir to fetch said strings. But I suppose this is a good change if it removes the need to hit the disk twice. The description of 'responsible-p' needs to be updated, though. Perhaps also describe what values can be returned by backends which do not support 'root'.