From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Martin Blais Newsgroups: gmane.emacs.bugs Subject: bug#12288: 24.2.50; compilation-start: Query for killing existing compilation process only if query-on-exit-flag is non-nil Date: Sat, 01 Sep 2012 14:17:50 -0400 Message-ID: <1346523470.14751.140661122426041.16CA21FC@webmail.messagingengine.com> References: <87ehms759q@ch.ristopher.com> <874nnit3f9@ch.ristopher.com> <1346512261.21458.140661122378029.2F7185E7@webmail.messagingengine.com> <87y5kt92yp@ch.ristopher.com> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain Content-Transfer-Encoding: 7bit X-Trace: ger.gmane.org 1346523527 9944 80.91.229.3 (1 Sep 2012 18:18:47 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Sat, 1 Sep 2012 18:18:47 +0000 (UTC) Cc: 12288@debbugs.gnu.org To: Christopher Schmidt Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sat Sep 01 20:18:49 2012 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1T7sHN-0000j0-H4 for geb-bug-gnu-emacs@m.gmane.org; Sat, 01 Sep 2012 20:18:45 +0200 Original-Received: from localhost ([::1]:52737 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1T7sHK-0006oL-Vz for geb-bug-gnu-emacs@m.gmane.org; Sat, 01 Sep 2012 14:18:43 -0400 Original-Received: from eggs.gnu.org ([208.118.235.92]:37849) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1T7sHI-0006oG-UO for bug-gnu-emacs@gnu.org; Sat, 01 Sep 2012 14:18:41 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1T7sHI-0007gp-0J for bug-gnu-emacs@gnu.org; Sat, 01 Sep 2012 14:18:40 -0400 Original-Received: from debbugs.gnu.org ([140.186.70.43]:51852) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1T7sHH-0007gl-Sv for bug-gnu-emacs@gnu.org; Sat, 01 Sep 2012 14:18:39 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.72) (envelope-from ) id 1T7sIb-0005Ie-Sh for bug-gnu-emacs@gnu.org; Sat, 01 Sep 2012 14:20:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Martin Blais Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 01 Sep 2012 18:20:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 12288 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch X-Debbugs-Original-Cc: bug-gnu-emacs@gnu.org Original-Received: via spool by submit@debbugs.gnu.org id=B.134652356120262 (code B ref -1); Sat, 01 Sep 2012 18:20:01 +0000 Original-Received: (at submit) by debbugs.gnu.org; 1 Sep 2012 18:19:21 +0000 Original-Received: from localhost ([127.0.0.1]:33165 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1T7sHv-0005Gi-Im for submit@debbugs.gnu.org; Sat, 01 Sep 2012 14:19:20 -0400 Original-Received: from eggs.gnu.org ([208.118.235.92]:58089) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1T7sHs-0005GW-W2 for submit@debbugs.gnu.org; Sat, 01 Sep 2012 14:19:18 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1T7sGX-0007fG-FB for submit@debbugs.gnu.org; Sat, 01 Sep 2012 14:17:54 -0400 Original-Received: from lists.gnu.org ([208.118.235.17]:34080) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1T7sGX-0007fC-CE for submit@debbugs.gnu.org; Sat, 01 Sep 2012 14:17:53 -0400 Original-Received: from eggs.gnu.org ([208.118.235.92]:37795) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1T7sGW-0006o0-FC for bug-gnu-emacs@gnu.org; Sat, 01 Sep 2012 14:17:53 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1T7sGV-0007f2-Gc for bug-gnu-emacs@gnu.org; Sat, 01 Sep 2012 14:17:52 -0400 Original-Received: from out1-smtp.messagingengine.com ([66.111.4.25]:47279) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1T7sGV-0007ey-8x for bug-gnu-emacs@gnu.org; Sat, 01 Sep 2012 14:17:51 -0400 Original-Received: from compute5.internal (compute5.nyi.mail.srv.osa [10.202.2.45]) by gateway1.nyi.mail.srv.osa (Postfix) with ESMTP id 99B3A20416; Sat, 1 Sep 2012 14:17:50 -0400 (EDT) Original-Received: from betaweb1.nyi.mail.srv.osa ([10.202.2.10]) by compute5.internal (MEProxy); Sat, 01 Sep 2012 14:17:50 -0400 DKIM-Signature: v=1; a=rsa-sha1; c=relaxed/relaxed; d= messagingengine.com; h=message-id:from:to:cc:mime-version :content-transfer-encoding:content-type:subject:date:in-reply-to :references; s=smtpout; bh=yheMAnQOpVaPibRlrqeulYMX9y8=; b=UVRS1 bHUTrYIsUrV12cN1WhS47FEOkvA/jg4H09jDoYahAK7D83ylKRBGMOEWsnd2V9dT FXzQs309LicCygABZMUbfYURpmMu4wSAmxiqLtrcBDK2w6PjJwrtpSaTsXjMg8Pu ynVgFx9rKGkvlYE7NblLgVeG+UTmQsDmM/KE+w= Original-Received: by betaweb1.nyi.mail.srv.osa (Postfix, from userid 99) id 4E94762B385; Sat, 1 Sep 2012 14:17:50 -0400 (EDT) X-Sasl-Enc: KOwj8Odq5cgzeRjby2sNop8vhFf5BenSFW+EaAQqWkEs 1346523470 X-Mailer: MessagingEngine.com Webmail Interface In-Reply-To: <87y5kt92yp@ch.ristopher.com> X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 3) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 2) X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:63653 Archived-At: On Sat, Sep 1, 2012, at 11:29, Christopher Schmidt wrote: > Martin Blais writes: > > I'm not sure I understand. Let's recap a bit: > > > > a. in 'compilation-start-hook, there's a hint that you can force the > > process-query-on-exit-flag on the compile process; that would > > presumably allow you to kill the buffer without a query, but not on a > ^^^^^^^^^^^^ > > subsequent call to compile. (BTW I just tried the suggested hook as is > ^^^^^^^^^^^^^^^^^^^^^^^^^^ > > and it doesn't work for me, but that's another issue). > > This is exactly what I don't want. > > Those processes that have a nil query-on-exit-flag should be killed by > compilation-start without a yes-or-no query. A buffer-local non-nil > value for compilation-always-kill allows me to achieve that. > > I still think a check for query-on-exit-flag in compilation-start is a > good idea. Non-nil query-on-exit-flag and non-nil buffer-local > compilation-always-kill feels redundant, doesn't it? Maybe what we should do is this (just an idea, not sure if it'll make sense to you): 1. Make the compile code check the process-query-on-exit-flag instead of the compilation-always-kill variable. This would simplify matters, in that there's a single flag that decides whether to kill the running process, and it's the same flag that's already being used for when you kill a buffer. One thing. 2. Provide a way to set the default value of process-query-on-exit-flag on compile subprocesses easier than the hook/comment. Suppressing the ask on recompile is a very common desire BTW--some people have packages to do just that--and IMO being able to customize this via a dedicated variable is valuable. What do you think?