From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Drew Adams Newsgroups: gmane.emacs.bugs Subject: bug#30660: mention describe-bindings on (info "(emacs) Keymaps") Date: Sat, 24 Aug 2019 08:06:19 -0700 (PDT) Message-ID: <13355700-914e-477e-99b6-c278b55e5563@default> References: <831b5f34-28c7-4753-bed9-0a28de484aa8@default> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="128662"; mail-complaints-to="usenet@blaine.gmane.org" Cc: 30660@debbugs.gnu.org, =?UTF-8?Q?=E7=A9=8D=E4=B8=B9=E5=B0=BC?= Dan Jacobson To: Stefan Kangas Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sat Aug 24 17:07:13 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1i1XdH-000XLb-MW for geb-bug-gnu-emacs@m.gmane.org; Sat, 24 Aug 2019 17:07:11 +0200 Original-Received: from localhost ([::1]:38166 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1i1XdF-0000pp-Rc for geb-bug-gnu-emacs@m.gmane.org; Sat, 24 Aug 2019 11:07:09 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:55750) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1i1Xd9-0000pV-Rg for bug-gnu-emacs@gnu.org; Sat, 24 Aug 2019 11:07:04 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1i1Xd8-0001ly-P8 for bug-gnu-emacs@gnu.org; Sat, 24 Aug 2019 11:07:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:34391) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1i1Xd8-0001lt-KE for bug-gnu-emacs@gnu.org; Sat, 24 Aug 2019 11:07:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1i1Xd8-0005XM-Ct for bug-gnu-emacs@gnu.org; Sat, 24 Aug 2019 11:07:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Drew Adams Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 24 Aug 2019 15:07:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 30660 X-GNU-PR-Package: emacs Original-Received: via spool by 30660-submit@debbugs.gnu.org id=B30660.156665919021244 (code B ref 30660); Sat, 24 Aug 2019 15:07:02 +0000 Original-Received: (at 30660) by debbugs.gnu.org; 24 Aug 2019 15:06:30 +0000 Original-Received: from localhost ([127.0.0.1]:43212 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1i1Xcb-0005Wa-Uf for submit@debbugs.gnu.org; Sat, 24 Aug 2019 11:06:30 -0400 Original-Received: from userp2120.oracle.com ([156.151.31.85]:49978) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1i1XcZ-0005WK-IK for 30660@debbugs.gnu.org; Sat, 24 Aug 2019 11:06:28 -0400 Original-Received: from pps.filterd (userp2120.oracle.com [127.0.0.1]) by userp2120.oracle.com (8.16.0.27/8.16.0.27) with SMTP id x7OF3eXh153814; Sat, 24 Aug 2019 15:06:21 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=mime-version : message-id : date : from : sender : to : cc : subject : references : in-reply-to : content-type : content-transfer-encoding; s=corp-2019-08-05; bh=BZaS4ZYFfewSekwaYCyYPcVgud2bidSfHQgxAoZJ/l4=; b=FBhtsSqGm361EW2Ce9JoxolqjEUtnhU0BEVtuYpmBpaEy5J66/eZncc4atfaQHsV366O 2m+aDzWfbanLfSjc9X3o6iLGTIaymPjNfz8Kp45jqPVLaKmXwO0zjdSPzM5u6khl6DFe D3dx/OrlrsJ+rbpeTVAA901/zVyNxEAz8WRpEccbX+FIDtBgmv9bTzBJOjjT9PMQEmq+ WrFX8Mf7Karx5XwvDppg78guyesP7B9lnki19Mi5YlKu0PJshzYgVzFNe0eemiJlZ8o8 ZtL7JdLuhQAamIbKrheL2UqROTCYsE9R/6PhJdloMJWwf42Vw6GrAmDdXwRqmxujPBF+ uQ== Original-Received: from userp3020.oracle.com (userp3020.oracle.com [156.151.31.79]) by userp2120.oracle.com with ESMTP id 2ujwvq18fk-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Sat, 24 Aug 2019 15:06:21 +0000 Original-Received: from pps.filterd (userp3020.oracle.com [127.0.0.1]) by userp3020.oracle.com (8.16.0.27/8.16.0.27) with SMTP id x7OF2frO140343; Sat, 24 Aug 2019 15:06:21 GMT Original-Received: from userv0122.oracle.com (userv0122.oracle.com [156.151.31.75]) by userp3020.oracle.com with ESMTP id 2ujw6g3bsh-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Sat, 24 Aug 2019 15:06:21 +0000 Original-Received: from abhmp0016.oracle.com (abhmp0016.oracle.com [141.146.116.22]) by userv0122.oracle.com (8.14.4/8.14.4) with ESMTP id x7OF6J3I017813; Sat, 24 Aug 2019 15:06:20 GMT In-Reply-To: X-Priority: 3 X-Mailer: Oracle Beehive Extensions for Outlook 2.0.1.9.1 (1003210) [OL 16.0.4873.0 (x86)] X-Proofpoint-Virus-Version: vendor=nai engine=6000 definitions=9359 signatures=668684 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 suspectscore=0 malwarescore=0 phishscore=0 bulkscore=0 spamscore=0 mlxscore=0 mlxlogscore=999 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1906280000 definitions=main-1908240166 X-Proofpoint-Virus-Version: vendor=nai engine=6000 definitions=9359 signatures=668684 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 priorityscore=1501 malwarescore=0 suspectscore=0 phishscore=0 bulkscore=0 spamscore=0 clxscore=1015 lowpriorityscore=0 mlxscore=0 impostorscore=0 mlxlogscore=999 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1906280000 definitions=main-1908240166 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:165779 Archived-At: > I've now packaged up a proposed patch Thanks for working on this. Looks mostly OK to me. However: 1. I object to the use of `C-h M' as the key binding. Please use `C-h M-k'. The letter `M/m' has other, and more useful, associations (mode, mail, . And `M' currently is translated to the often used `C-h m'. `K' is often associated in Emacs with "key" or "kill". And it's as easy to use Meta as it is to use Shift. [And users of `help-fns+.el', which has the same command but with additional features, are used to `C-h M-k'. Because the vanilla version will lack those additional features I'll continue to maintain `describe-keymap' in `help-fns+.el'. If those features are also added to vanilla Emacs someday then I won't need to maintain it.] 2. When testing with `emacs -Q' (but perhaps because I ran into the error of #3?), and also using `C-h f' etc., I somehow ended up with two [back] links at the bottom of *Help*, like this: [back] [back] Please check that what you end up with doesn't lead to this. 3. The code raises this error when KEYMAP is not a symbol and SEARCH-SYMBOLS-P is nil, because FILE-NAME is nil. (describe-keymap isearch-mode-map) =3D>=20 Debugger entered--Lisp error: (wrong-type-argument stringp nil) file-name-nondirectory(nil) (if (eq file-name (quote C-source)) "C source code" (file-name-nondirecto= ry file-name)) ... 4. When fixing that bug, please be sure not to print a generated name ("KEYMAP OBJECT (no variable)") for a non-existent or not found variable. 5. When fixing that bug, if the keymap is fine, and it has a variable that is not defined in a file, don't try to print a file for it. Don't try to print a file for the non-variable case either. Wrt 3-5: It's not right to blindly print a variable name and a file for it. The code needs to handle cases such as variable not given, no variable at all, and variable not defined in a file.