From: Kaushik Srenevasan <ksrenevasan@gmail.com>
To: emacs-devel@gnu.org
Subject: [PATCH] GUD-MI's disassembly buffer should follow $PC in the absence of debug information.
Date: Mon, 23 Jan 2012 22:46:47 -0800 [thread overview]
Message-ID: <1327387607.1742.21.camel@garuda3.sysenter> (raw)
All,
GUD-MI's disassembly buffer only works when the current frame has debug
information. While debugging dynamically generated code it'd be useful
to simply follow the program counter. I understand that newer GDBs
expose an API that lets a JIT compiler register debug information for
dynamically generated code, but JITs typically only do so for real
functions. So, having the disassembly buffer follow $PC would still be
useful while stepping through dynamically generated, shorter sequences
of code (like call stubs, inline caches etc.).
The latest GDB (7.4.50.20120122-cvs) does this in its TUI mode while my
stable GDB's (7.0.1-debian) behavior is the same as Emacs 23 GUD.
Please review and merge.
Thanks,
-Kaushik
=== modified file 'lisp/progmodes/gdb-mi.el'
--- lisp/progmodes/gdb-mi.el 2012-01-05 09:46:05 +0000
+++ lisp/progmodes/gdb-mi.el 2012-01-24 05:13:10 +0000
@@ -3259,8 +3259,12 @@
(let* ((frame (gdb-current-buffer-frame))
(file (bindat-get-field frame 'fullname))
(line (bindat-get-field frame 'line)))
- (when file
- (format "-data-disassemble -f %s -l %s -n -1 -- 0" file line)))
+ (if file
+ (format "-data-disassemble -f %s -l %s -n -1 -- 0" file line)
+ ;; If we're unable to get a file name / line for $PC, simply
+ ;; follow $PC, disassembling the next 10 (x ~15 (on IA) ==
+ ;; 150 bytes) instructions.
+ "-data-disassemble -s $pc -e \"$pc + 150\" -- 0"))
gdb-disassembly-handler
;; We update disassembly only after we have actual frame information
;; about all threads, so no there's `update' signal in this list
@@ -3319,8 +3323,12 @@
(gdb-table-add-row table
(list
(bindat-get-field instr 'address)
- (apply #'format "<%s+%s>:"
- (gdb-get-many-fields instr 'func-name 'offset))
+ (let
+ ((func-name (bindat-get-field instr 'func-name))
+ (offset (bindat-get-field instr 'offset)))
+ (if func-name
+ (format "<%s+%s>:" func-name offset)
+ ""))
(bindat-get-field instr 'inst)))
(when (string-equal (bindat-get-field instr 'address)
address)
next reply other threads:[~2012-01-24 6:46 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-01-24 6:46 Kaushik Srenevasan [this message]
2012-01-24 11:44 ` [PATCH] GUD-MI's disassembly buffer should follow $PC in the absence of debug information Juanma Barranquero
-- strict thread matches above, loose matches on Subject: below --
2012-01-29 9:17 Nick Roberts
2012-01-30 21:52 ` Kaushik Srenevasan
2012-01-31 5:53 ` Nick Roberts
2012-01-31 7:19 ` Kaushik Srenevasan
2012-02-04 10:36 ` Nick Roberts
2012-02-06 9:14 ` Kaushik Srenevasan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1327387607.1742.21.camel@garuda3.sysenter \
--to=ksrenevasan@gmail.com \
--cc=emacs-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.