From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: "Reiner Steib" Newsgroups: gmane.emacs.devel Subject: Re: bug#7854: emacs-23 (regression) - fix breaks `dired' Date: Mon, 14 Feb 2011 03:59:42 -0800 Message-ID: <1297684782.13324.1420559071@webmail.messagingengine.com> References: <87r5bdrond.fsf@stupidchicken.com> <83y65lot4x.fsf@gnu.org> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit X-Trace: dough.gmane.org 1297684847 21262 80.91.229.12 (14 Feb 2011 12:00:47 GMT) X-Complaints-To: usenet@dough.gmane.org NNTP-Posting-Date: Mon, 14 Feb 2011 12:00:47 +0000 (UTC) Cc: 7854@debbugs.gnu.org, emacs-devel@gnu.org To: "Eli Zaretskii" , "Chong Yidong" Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Mon Feb 14 13:00:41 2011 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1Pox6b-00083T-Fv for ged-emacs-devel@m.gmane.org; Mon, 14 Feb 2011 13:00:37 +0100 Original-Received: from localhost ([127.0.0.1]:44121 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Pox6a-0006SQ-SE for ged-emacs-devel@m.gmane.org; Mon, 14 Feb 2011 07:00:36 -0500 Original-Received: from [140.186.70.92] (port=43942 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Pox5r-000646-Hp for emacs-devel@gnu.org; Mon, 14 Feb 2011 06:59:53 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Pox5p-0002GW-GA for emacs-devel@gnu.org; Mon, 14 Feb 2011 06:59:51 -0500 Original-Received: from out1.smtp.messagingengine.com ([66.111.4.25]:33414) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Pox5k-0002DJ-JX; Mon, 14 Feb 2011 06:59:44 -0500 Original-Received: from compute3.internal (compute3.nyi.mail.srv.osa [10.202.2.43]) by gateway1.messagingengine.com (Postfix) with ESMTP id A900020682; Mon, 14 Feb 2011 06:59:42 -0500 (EST) Original-Received: from web1.messagingengine.com ([10.202.2.211]) by compute3.internal (MEProxy); Mon, 14 Feb 2011 06:59:42 -0500 DKIM-Signature: v=1; a=rsa-sha1; c=relaxed/relaxed; d=messagingengine.com; h=message-id:from:to:cc:mime-version:content-transfer-encoding:content-type:in-reply-to:references:subject:date; s=smtpout; bh=30KkOIfm1aDYNhTWRHtviBfY15g=; b=kuLhMvJKARUFAkDWZOSzlJIqzDaLPX2qySdW8LyRe+5zIWPfAyyj8geY9O1AiHfqK28HNAiJOY/oZU6qwSbgLKk3oSrtNo0FQMJdxet6PDuD1W7d+ZjxOO18HPyHiEJ+rVPVfjGjd3qmYWgrGThZm6pw7AJCFkCKJVLFfqmboW0= Original-Received: by web1.messagingengine.com (Postfix, from userid 99) id 86D363CF1DC; Mon, 14 Feb 2011 06:59:42 -0500 (EST) X-Sasl-Enc: lYLe+MFTcD/g2cGuSZURsSP3ZS1iIVEGHcNkG9f3rDSK 1297684782 X-Mailer: MessagingEngine.com Webmail Interface In-Reply-To: <83y65lot4x.fsf@gnu.org> X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 66.111.4.25 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:135996 Archived-At: On Sat, 12 Feb 2011 23:11 +0200, "Eli Zaretskii" wrote: > > From: Chong Yidong > > Date: Sat, 12 Feb 2011 15:20:06 -0500 > > Cc: 7854@debbugs.gnu.org, Reiner Steib > > > > Could someone with access to Windows please test the regression reported > > at Bug#7854? I could not reproduce it, replacing "u:/tmp" with "/tmp/". > > > > > $ emacs -Q -l files-emacs23-git.el --eval '(dired "u:/tmp/")' > > > (files-emacs23-git.el = > > > http://git.savannah.gnu.org/cgit/emacs.git/plain/lisp/files.el?h=emacs-23&id=8588a5a723f4e5cfa115341a242126a9efc71808) > > > > > > I get: > > > > > > | if: Reading directory: "ls -al -- u:/tmp/" exited with status 1 > > > > If someone could come up with a smaller testcase, that would be good > > too. > > I cannot reproduce this with the current trunk (replacing u:/tmp with > a directory I actually have on my system). Up comes Dired with the > listing of that directory. The only way I can cause it to fail is by > removing ls.exe from my PATH -- but that produces a different error > message: > > Debugger entered--Lisp error: (file-error "Searching for program" "no > such file or directory" "ls") > call-process("ls" nil t nil "-al" "--" "h:/test/.") > apply(call-process "ls" nil t nil ("-al" "--" "h:/test/.")) > > This error is expected: loading files.el overrides the replacement > functions installed by ls-lisp.el (which is preloaded on Windows), so > now Dired on Windows must have a working ls.exe executable. Thanks for the explanation. > (I actually don't understand what is the purpose of loading files.el > from Emacs 23 into Emacs 24, but that's me.) As I use a pre-compiled Emacs (when using Windows), I loaded the most recent version of files.el for the emacs-23 branch from git-web (with Stefans's fix for the original problem) on the command line (using emacs 23.2) because the old files.elc is dumped (if I understand correctly). The original problem was reported for the trunk, but the (potential) regression was found in the emacs-23 branch. Sorry for the confusion. > Reiner, can you still see this problem in today's trunk? Now I downloaded the most recent binaries: 23.3 pretest (emacs-23.2.93-bin-i386.zip) and trunk (emacs-20110207-bin-i386.zip). I cannot reproduce the problem with these versions. So please close this bug again - sorry for the noise. Bye, Reiner -- http://www.fastmail.fm - mmm... Fastmail...