From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Jostein =?UTF-8?Q?Kj=C3=B8nigsen?= Newsgroups: gmane.emacs.bugs Subject: bug#65470: 29.1.50; js-ts-mode: regex pattern can cause incorrect parenthesis matching Date: Sat, 26 Aug 2023 23:13:15 +0200 Message-ID: <127B5BEA-A24B-48A3-9827-85B7CDB67D10@secure.kjonigsen.net> References: Mime-Version: 1.0 (1.0) Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="4372"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 65470@debbugs.gnu.org, Theodor Thornhill , Dmitry Gutov , btuin@mailo.com, Eli Zaretskii , Jostein =?UTF-8?Q?Kj=C3=B8nigsen?= To: Fu Yuan Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sat Aug 26 23:14:08 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qa0bb-0000o5-Ne for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 26 Aug 2023 23:14:08 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qa0bV-0004UY-IH; Sat, 26 Aug 2023 17:13:57 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qa0bU-0004UQ-KN for bug-gnu-emacs@gnu.org; Sat, 26 Aug 2023 17:13:56 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qa0bU-0000dY-CK for bug-gnu-emacs@gnu.org; Sat, 26 Aug 2023 17:13:56 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1qa0bZ-0002lx-MY for bug-gnu-emacs@gnu.org; Sat, 26 Aug 2023 17:14:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Jostein =?UTF-8?Q?Kj=C3=B8nigsen?= Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 26 Aug 2023 21:14:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 65470 X-GNU-PR-Package: emacs Original-Received: via spool by 65470-submit@debbugs.gnu.org id=B65470.169308442310624 (code B ref 65470); Sat, 26 Aug 2023 21:14:01 +0000 Original-Received: (at 65470) by debbugs.gnu.org; 26 Aug 2023 21:13:43 +0000 Original-Received: from localhost ([127.0.0.1]:43543 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qa0bG-0002lI-Ki for submit@debbugs.gnu.org; Sat, 26 Aug 2023 17:13:43 -0400 Original-Received: from out2-smtp.messagingengine.com ([66.111.4.26]:41441) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qa0bE-0002l3-5t for 65470@debbugs.gnu.org; Sat, 26 Aug 2023 17:13:41 -0400 Original-Received: from compute2.internal (compute2.nyi.internal [10.202.2.46]) by mailout.nyi.internal (Postfix) with ESMTP id 9EC345C007F; Sat, 26 Aug 2023 17:13:29 -0400 (EDT) Original-Received: from mailfrontend1 ([10.202.2.162]) by compute2.internal (MEProxy); Sat, 26 Aug 2023 17:13:29 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= secure.kjonigsen.net; h=cc:cc:content-transfer-encoding :content-type:content-type:date:date:from:from:in-reply-to :in-reply-to:message-id:mime-version:references:reply-to:sender :subject:subject:to:to; s=fm3; t=1693084409; x=1693170809; bh=YH 2hv7HRFdcxQuAb+D+vHuRQirfx58mNnf0flMr9pBE=; b=FK51KSuiUNt3UNd0hp kEM3hdCRgHXmu/UsJxHaio9C1h/bE0klsRY2CgJ5Zr0PuxLa9RDSuL3k5j0rQ96F MMPN+24MSs7XZG69IbgAFsNlx6jiCAN/YXBSYIDNouI/x5AAB7qSlN6yQ99/1Sy4 agv9UFg+dR5fpVJpZRyUv2D/1zTNcZhbOC+seDQg9Rq2OBwWISsCKFEGxvKfFeff Wy1NmHIwH/S6gyAHnM34sIUW0poV+sCazlfTF/BDeeaTey1Qsu+lXItzJ2Zhfsdu AGeGxrJWCad66D6lQ+Oik2WcEPiDccEyBETJxGtXzrFLw655z2lBRbcMB9/dTleT UiyA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:content-type:date:date:feedback-id:feedback-id :from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:sender:subject:subject:to:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm1; t= 1693084409; x=1693170809; bh=YH2hv7HRFdcxQuAb+D+vHuRQirfx58mNnf0 flMr9pBE=; b=tKxTr2TY4m1u8WJbcr2RWa2i0LyZh8J5/qZySLv3h09IMXnwLw1 50OfeEzz2bDWw8J2R+yS2dmN1SDz8iktxqjXpYwMr6iyryF8z3ch/KvKepH6yY6A 3r1FcAAj/UnFtMDCrx0p9JdLaNKC/X8hxkWEBhXUHgETLWaPvqoScLLU77zMWeye bn7ZQuW8jg9teNmW2m8vHuHSz0LyFeeXNWJIRtQ1UiGMyFfPY2FRygAgvUqYYEPP Y1RSx8ZsgC0+dzPAOyvhEGfv+eplUMiBpsyoXb+o+Hjp7VpuKhMgg6rcZW9FrguN 8RZKoorrxojj9lzeAZZdDQHnGDA6vqJwSfw== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedviedrudeftddgudehjecutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfgh necuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmd enucfjughrpegtgffhggfufffkfhevjgfvofesthhqmhdthhdtjeenucfhrhhomheplfho shhtvghinhcumfhjpphnihhgshgvnhcuoehjohhsthgvihhnsehsvggtuhhrvgdrkhhjoh hnihhgshgvnhdrnhgvtheqnecuggftrfgrthhtvghrnhepvdeitdefudetveeghfegfeff hfeuledtteevheekkeduhfejiefhvefffedugedtnecuvehluhhsthgvrhfuihiivgeptd enucfrrghrrghmpehmrghilhhfrhhomhepjhhoshhtvghinhesshgvtghurhgvrdhkjhho nhhighhsvghnrdhnvght X-ME-Proxy: Feedback-ID: ib2f84088:Fastmail Original-Received: by mail.messagingengine.com (Postfix) with ESMTPA; Sat, 26 Aug 2023 17:13:28 -0400 (EDT) In-Reply-To: X-Mailer: iPhone Mail (20G75) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:268520 Archived-At: > On 26 Aug 2023, at 17:29, Fu Yuan wrote: >=20 > =EF=BB=BF >>>=20 >>>>> On Aug 24, 2023, at 11:59 PM, Jostein Kj=C3=B8nigsen wrote: >>>>>=20 >>>>>=20 >>>>>=20 >>>>>> On 24 Aug 2023, at 21:47, Theodor Thornhill wrote= : >>>>>=20 >>>>> Eli Zaretskii writes: >>>>>=20 >>>>>>=20 >>>>>> Would someone please add syntax-propertize-function in modes that nee= d >>>>>> it? I think this should be done on the emacs-29 branch. >>>>>>=20 >>>>>> TIA >>>>>=20 >>>>> I'll add it to my list, but if someone will grab it that's fine, as I'= m >>>>> a little short on time the next couple of weeks :-( >>>>>=20 >>>>> Theo >>>>=20 >>>> I=E2=80=99ve just been forced over to a Mac at work, and I can=E2=80=99= t (yet) for the life of me figure out how to build Emacs from source on this= platform. It seems Emacs is not picking up libraries I=E2=80=99ve installed= using homebrew? >>>>=20 >>>> If anyone can help me get past this roadblock, I might be able to get a= patch going. (It=E2=80=99s a ARM-based Mac, if that matters.) >>>=20 >>> It=E2=80=99s been quite a while since I needed to setup this, so I don=E2= =80=99t quite remember. But setting LD_LIBRARY_PATH (Homebrew=E2=80=99s path= ) and PKG_CONFIG_PATH (/usr/local/lib/pkgconfig) should help the build proce= ss and Emacs find the libraries. >>>=20 >>> Yuan >>=20 >> I figured it out in the end. For anyone suffering a similar problem: >>=20 >> I had all packages I needed installed, but not pkg-config, leading config= ure not being able to locate any of them.=20 >>=20 >> Installing pkg-config too and running =E2=80=9Cmake bootstrap=E2=80=9D go= t me a working build.=20 >>=20 >> With that out of the way, I=E2=80=99ll see if I can come up with some pat= ches for the typescript ts-modes sometime the next week.=20 >=20 > Good to hear that! Exiles you are at it, could you also have a look at JSX= ? I think the latest tree-sitter grammar breaks some queries. >=20 > Yuan I don=E2=80=99t really work with JSX and don=E2=80=99t think have a =E2=80=9C= idiomatic=E2=80=9D code base to try it on where I would notice brokenness.=20= I think this would be better handled by people more experienced with both JS= X and our JSX code base than I am.=20 =E2=80=94 Jostein=