From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Maus Subject: [PATCH] Don't create marker if target is entire file. Date: Mon, 5 Jul 2010 21:28:34 +0200 Message-ID: <1278358114-1212-1-git-send-email-dmaus@ictsoc.de> References: <8739vzpqx1.wl%dmaus@ictsoc.de> Return-path: Received: from [140.186.70.92] (port=53664 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1OVrLh-0002YY-01 for emacs-orgmode@gnu.org; Mon, 05 Jul 2010 15:29:02 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69) (envelope-from ) id 1OVrLf-0007rr-Ob for emacs-orgmode@gnu.org; Mon, 05 Jul 2010 15:29:00 -0400 Received: from mysql1.xlhost.de ([213.202.242.106]:54849) by eggs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1OVrLf-0007rK-Jl for emacs-orgmode@gnu.org; Mon, 05 Jul 2010 15:28:59 -0400 In-Reply-To: <8739vzpqx1.wl%dmaus@ictsoc.de> List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org To: emacs-orgmode@gnu.org * org-agenda.el (org-agenda-bulk-action): Don't create marker for position if target is entire file. If the target of a bulk refile operation is the entire file, `org-refile-get-location' returns nil for the refile position. Creating a marker for the target file's buffer at position nil returns a marker that points nowhere (Cf. GNU Emacs Lisp Reference Manual, 31.6). `org-refile' adds headings to level 1 if the target position for the target file is nil -- and hence a marker that points nowhere is not nil, tries to jump to nowhere. --- lisp/org-agenda.el | 11 ++++++----- 1 files changed, 6 insertions(+), 5 deletions(-) diff --git a/lisp/org-agenda.el b/lisp/org-agenda.el index 4345f06..1fe4639 100644 --- a/lisp/org-agenda.el +++ b/lisp/org-agenda.el @@ -7489,11 +7489,12 @@ The prefix arg is passed through to the command if possible." "Refile to: " (marker-buffer (car org-agenda-bulk-marked-entries)) org-refile-allow-creating-parent-nodes)) - (setcar (nthcdr 3 rfloc) - (move-marker (make-marker) (nth 3 rfloc) - (or (get-file-buffer (nth 1 rfloc)) - (find-buffer-visiting (nth 1 rfloc)) - (error "This should not happen")))) + (if (nth 3 rfloc) + (setcar (nthcdr 3 rfloc) + (move-marker (make-marker) (nth 3 rfloc) + (or (get-file-buffer (nth 1 rfloc)) + (find-buffer-visiting (nth 1 rfloc)) + (error "This should not happen"))))) (setq cmd (list 'org-agenda-refile nil (list 'quote rfloc) t) redo-at-end t)) -- 1.7.1