From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: martin rudalics Newsgroups: gmane.emacs.devel Subject: Re: [PATCH] Add function window-line-width Date: Fri, 8 Nov 2019 10:21:45 +0100 Message-ID: <125a5b4a-5ac8-426f-5762-af0e91962c78@gmx.at> References: <8846a8ad-0299-1ff7-cc9a-0aaed18e76c0@gmx.at> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="90642"; mail-complaints-to="usenet@blaine.gmane.org" Cc: emacs-devel@gnu.org To: =?UTF-8?Q?S=c3=a9bastien_Chapuis?= Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Fri Nov 08 10:22:26 2019 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1iT0TJ-000NT4-M6 for ged-emacs-devel@m.gmane.org; Fri, 08 Nov 2019 10:22:25 +0100 Original-Received: from localhost ([::1]:50896 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iT0TI-0001Br-0w for ged-emacs-devel@m.gmane.org; Fri, 08 Nov 2019 04:22:24 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:35501) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iT0Sk-0001BI-GC for emacs-devel@gnu.org; Fri, 08 Nov 2019 04:21:51 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1iT0Sj-0001Tx-H4 for emacs-devel@gnu.org; Fri, 08 Nov 2019 04:21:50 -0500 Original-Received: from mout.gmx.net ([212.227.17.21]:58161) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1iT0Sj-0001TH-7I for emacs-devel@gnu.org; Fri, 08 Nov 2019 04:21:49 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net; s=badeba3b8450; t=1573204907; bh=CDVA0C/+Xev4QaMSIZM0EV1jOfUnggWd7Y6UfrfamT8=; h=X-UI-Sender-Class:Subject:To:Cc:References:From:Date:In-Reply-To; b=YO+VTPqH1bwjVNo+1e95LAPnoi9AT6P7RXsZ+JgWyprKy4DzPGnTFkjb3d021QU9k Mhxkyk9ne1sYXbXKGqp6QxgqgIFxaYjaogl0yKIt6tDtfwXR1if0VcPiOQGQlJImny jD7wjhXcA+14gLWMT0QpeHtqFjXKRcB2si5GvI5A= X-UI-Sender-Class: 01bb95c1-4bf8-414a-932a-4f6e2808ef9c Original-Received: from [192.168.1.102] ([212.95.7.234]) by mail.gmx.com (mrgmx105 [212.227.17.168]) with ESMTPSA (Nemesis) id 1N3KTy-1hljEP15ec-010IZI; Fri, 08 Nov 2019 10:21:47 +0100 In-Reply-To: Content-Language: de-AT X-Provags-ID: V03:K1:JzCBfrMyA0uz0LvKd9uBqJc3p3Ml4TMmj9/SuOlXdV3CIFvaew1 HIWWMraY+ba9//cj7dJqwZsHlj/wZlG4N4MhXVglRIqMjgLLJYAkfSaV+ZRfP0mX8nYH+i6 fsveQ9h5EgEMBQUeMsWhn/MRUFXAY9FUan6EK2IZJ1ctKYH7gjn+sqMir8mo1LeoUwtCdI5 msAdZbhL8IJCQPE52TYiw== X-UI-Out-Filterresults: notjunk:1;V03:K0:azgo5SE4MbE=:1+01GYAwNP429ustA9UQAU 69xSgde5Z1K5n3HFlkDqIPhwGwhht2HZ8K43ej+IOBSqrYwavUrFOP8J1gxdYP/muWaIjOqY0 cXBChjUqCLJYMW8Oqx6Qs0cV9d88g/NT9cwN05lSZNJzRXljnnfVIpnLEBtyvxDlWVkMpY8PF S8WC8mx/foirtMDqV7O+mxHJJ3SuIiMtMn27IjHROdzg/XVsUAHzdLZNMYcWsBDy4cJIuVP4f ZKjip56QbwTRMg+MTrrTYoTj6PQOvQ/3vEc4VwMvewQjTmglfO4twonJwyBaKs1JXlcTa8QWQ 8tI3FtRuRo9/PfDci/UCESw9Zm4L/gkoiaHHF328wXkCIR6AtjQYJRejfeU439xF9K+RIEbWM 1UzL0EvaMWkFV8+Ap4SkXZ05RHqyllkJsz4NHfoBJNfoNlL83J9FGJBei1S+MaVe7nW932YS8 ozmYs0w/zLp5YrihpJ9TOmZYNnYqurZbMZ/M0dIeVX4gvVhQdI+4geENw/Tnvk9TUqPliTs0n nebTRPZndaICbBnhdQaixJNVuD+mZG1dauhPPz/u8zyrtnf21sOTrJp5cJ6TA0bZ54A2rgs8f oqiQkOprYLBN741U6ulmhDAusIKsRiVn1hXoqBrJLhrUF3dHJZuJF/HBpKGNAXVrv54itk3H0 5JvSmeIVClEaSP+QVlfpJxL0w1lVyu3CsFq0RsWF+cSx6SIPnPUAkGeY4WWfqaIdI0Z45TpFG 7clWmIr1mjYSoDva1pNZU8WkaVWBIfPcnVEkH+YjanHXbqavOAPL7Qol2FHDpGQhxoWan49B X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 212.227.17.21 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:241971 Archived-At: > The first point is important for my use case, so if 'window-line-width' is > not accepted, would you agree for a patch > adding a parameter to 'window-lines-pixel-dimensions' controlling this > behavior ? I certainly would but it's up to Eli to decide. > 'window-text-pixel-size' uses a display iterator to compute values, I don't > know the details of this iterator but it seems to > be slower than fetching values directly from the glyph matrix. As > mentioned, I need the width of all lines on window. It would be good to know how much slower 'window-text-pixel-size' then is. If it is significantly slower, we probably should replace it with a function based on directly accessing the glyph matrix. Can you try to measure the respective performances? Thanks, martin