Re: Problems with EDE

["Eric M. Ludlam" <eric@siege-engine.com>]

Thanks for the patch.  I have applied it to my repository.

I've added cedet/cedet-ediff.el to my repository which lets me diff
between the Emacs CVS repository and the CEDET repository more easilly,
which allowed me to also get the spelling fix someone checked in.

If you would like to just diff the Emacs repository, I'll be able to use
my new tool to get your patch merged into my repository more easily now.

Thanks
Eric

On Thu, 2009-10-08 at 18:15 -0400, Chong Yidong wrote:
> Sascha Wilde <wilde@sha-bang.de> writes:
> 
> > Yet another one:
> > ede-make-dist does not work for ede automake projects:
> >
> >   -*- mode: compilation; default-directory: "/tmp/cedet-test1/" -*-
> >   Compilation started at Thu Oct  8 22:52:13
> >
> >   make -f /tmp/cedet-test1/Makefile.am dist
> >   make: *** No rule to make target `dist'.  Stop.
> >
> >   Compilation exited abnormally with code 2 at Thu Oct  8 22:52:13
> >
> > Using the Makefile.am is obviously wrong.  The actual Makefile contains
> > an working dist target.
> 
> This is a bug in project-make-dist (the filename comparison forgets that
> ede-proj-dist-makefile returns a full filename).  I've checked in a fix
> into the trunk.
> 
> Eric, here's a patch for your tree (it also includes a stylistic
> correction, to use expand-file-name instead of concat to generate full
> filenames).
> 
> 
> * cedet/ede/ede-proj.el (project-make-dist, project-compile-project):
> Fix filename test.
> (ede-proj-dist-makefile): Use expand-file-name instead of concat
> to expand file names.
> 
> *** cedet/ede/ede-proj.el.~1.62.~	2009-08-18 19:56:57.000000000 -0400
> --- cedet/ede/ede-proj.el	2009-10-08 18:12:20.000000000 -0400
> ***************
> *** 453,459 ****
>   	     (not (y-or-n-p "Dist file already exists.