From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Dmitry Gutov Newsgroups: gmane.emacs.bugs Subject: bug#60338: [PATCH] Add option to present server changes as diffs Date: Thu, 7 Sep 2023 15:41:55 +0300 Message-ID: <11e35fa9-0956-b147-ac7e-d54416197df5@gutov.dev> References: <87ilhy1dub.fsf@posteo.net> <877cs97kgb.fsf@posteo.net> <83jzw8yjv5.fsf@gnu.org> <877cs8g8oy.fsf@posteo.net> <83fs6wyhak.fsf@gnu.org> <87y1koerm6.fsf@posteo.net> <83bkhkyeze.fsf@gnu.org> <87v8fr6o86.fsf@posteo.net> <87zg52e12n.fsf@posteo.net> <871qi9q9uc.fsf@posteo.net> <87a5ww7qa3.fsf@gmail.com> <87jzvsdco1.fsf@posteo.net> <87zg2669kk.fsf@gmail.com> <87sf7w526r.fsf@gmail.com> <868r9io6lo.fsf@mail.linkov.net> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="12756"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.13.0 Cc: Philip Kaludercic , 60338@debbugs.gnu.org, Eshel Yaron , =?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?= , Eli Zaretskii To: Juri Linkov Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu Sep 07 14:43:09 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qeELk-000371-H7 for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 07 Sep 2023 14:43:09 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qeELe-00062i-Tw; Thu, 07 Sep 2023 08:43:02 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qeELc-00062H-Cz for bug-gnu-emacs@gnu.org; Thu, 07 Sep 2023 08:43:00 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qeELc-0005fA-4x for bug-gnu-emacs@gnu.org; Thu, 07 Sep 2023 08:43:00 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1qeELd-0003AK-OW for bug-gnu-emacs@gnu.org; Thu, 07 Sep 2023 08:43:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Dmitry Gutov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 07 Sep 2023 12:43:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 60338 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 60338-submit@debbugs.gnu.org id=B60338.169409052912103 (code B ref 60338); Thu, 07 Sep 2023 12:43:01 +0000 Original-Received: (at 60338) by debbugs.gnu.org; 7 Sep 2023 12:42:09 +0000 Original-Received: from localhost ([127.0.0.1]:38822 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qeEKn-000399-6a for submit@debbugs.gnu.org; Thu, 07 Sep 2023 08:42:09 -0400 Original-Received: from out2-smtp.messagingengine.com ([66.111.4.26]:47607) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qeEKk-00038A-Cv for 60338@debbugs.gnu.org; Thu, 07 Sep 2023 08:42:07 -0400 Original-Received: from compute3.internal (compute3.nyi.internal [10.202.2.43]) by mailout.nyi.internal (Postfix) with ESMTP id 657C65C0089; Thu, 7 Sep 2023 08:41:59 -0400 (EDT) Original-Received: from mailfrontend2 ([10.202.2.163]) by compute3.internal (MEProxy); Thu, 07 Sep 2023 08:41:59 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gutov.dev; h=cc :cc:content-transfer-encoding:content-type:content-type:date :date:from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:sender:subject:subject:to:to; s=fm3; t= 1694090519; x=1694176919; bh=NLVhao8Cb/mJg9vpDpKuxTrnT6/MPLf0SRR NLC9OIwA=; b=DqmMrHw2v0KeoeJP3h7lgO+9Qp2kRAK+8BUeUPTprLDcbXr+InN JsD74763vl4AX1nhHOqaSKKpF0ayc7uQ4swhaVBXrL5XGsOAx6PGCEpNjlaTJKik isAf/IpDXLlzF26OeOd6oEKaLrxlj7pqs+N8yX2QRYCX9vbUzb4cqEn6cM0WR0co f7YZ7n8NVec2AbOaWng/XkLv4p0bqeoe/D9Zb9IwKynFkoN/fSF4nItIhumAU81/ 4yLvtKqKDHAIOuAm9xaRv2URZaebOJBJ5cI2HZZCAahqVZjYDZbc2SCy/gNJqbQ9 A96xPmAT9PfJA6jyMEXuk92PhQA51CaeN9Q== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:content-type:date:date:feedback-id:feedback-id :from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:sender:subject:subject:to:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm1; t= 1694090519; x=1694176919; bh=NLVhao8Cb/mJg9vpDpKuxTrnT6/MPLf0SRR NLC9OIwA=; b=riMjpm2XY7/ff8ARIEG4USxbmF3xAtAyBMWOg+HWu2UKc/jQh+p Iq9na6o5yJ0l4eLRL6qngTLN7kgcS+Gfx524GykosM/0vtrDdPR2MzADpcup2tiF qfVW20RcCNGxeLWpVEXHSADp3YsetSK6xkxa4BwckYUcSRPvEdjJLZG1jKbyhi+o hilhP6E5t3jc8j+4jUBVbaDnijlYhfaCIq+kKgCMGRBCkCX9SkH5YXrh9QjU0ORx jjpU180Jd/XLdY/RQAcaVSSd0m9op+R2zDYrWJHnk+7bLPXKXgDXYl4RDZw5aysu /7KR1VHfDwdffDtIE4eEhgGJrtSDLtbiIJw== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedviedrudehhedgheefucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhepkfffgggfuffvvehfhfgjtgfgsehtjeertddtfeejnecuhfhrohhmpeffmhhi thhrhicuifhuthhovhcuoegumhhithhrhiesghhuthhovhdruggvvheqnecuggftrfgrth htvghrnhepiefgteevheevveffheeltdeukeeiieekueefgedugfefgefhudelgfefveel vdevnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomhepug hmihhtrhihsehguhhtohhvrdguvghv X-ME-Proxy: Feedback-ID: i0e71465a:Fastmail Original-Received: by mail.messagingengine.com (Postfix) with ESMTPA; Thu, 7 Sep 2023 08:41:57 -0400 (EDT) Content-Language: en-US In-Reply-To: <868r9io6lo.fsf@mail.linkov.net> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:269647 Archived-At: On 07/09/2023 09:28, Juri Linkov wrote: >> Two other thoughts after trying it: >> >> - I would probably want to bind the originally proposed >> 'diff-apply-everything' to 'C-c C-c' (e.g. "commit the change to disk"), >> but that's already taken in diff-mode. > If there are no more intuitive keys, maybe then use the proposed by Philip > 'C-c C-x'? IDK, seems a little dangerous given to its proximity to 'C-x C-c'. Personally, the existing 'C-c C-c' binding seems unnecessary given that this command has 6 other bindings already. If we chose to replace it, we could just start the new command with a prompt (Apply all changes from diff?), so it doesn't surprise anyone.