From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Gregory Heytings Newsgroups: gmane.emacs.devel Subject: Re: Unicode confusables and reordering characters considered harmful Date: Wed, 03 Nov 2021 16:01:20 +0000 Message-ID: <11d5fecb4476ff938838@heytings.org> References: <875ytag0hb.fsf@yahoo.com> <87zgqmd5np.fsf@mat.ucm.es> <83wnlqk3rn.fsf@gnu.org> <72dd5c2a-42c7-b12e-05ed-e93adbd89727@gmail.com> <83ilxajyhw.fsf@gnu.org> <83fssejxf8.fsf@gnu.org> <835ytajsv2.fsf@gnu.org> <11d5fecb44af1d388b7f@heytings.org> <11d5fecb449846dc0851@heytings.org> <837ddpicbb.fsf@gnu.org> <11d5fecb442f6eb9e9e3@heytings.org> <83v919gv9a.fsf@gnu.org> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="0QLc6dQRsf" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="8339"; mail-complaints-to="usenet@ciao.gmane.io" Cc: cpitclaudel@gmail.com, stefan@marxist.se, monnier@iro.umontreal.ca, emacs-devel@gnu.org To: Eli Zaretskii Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Wed Nov 03 17:05:52 2021 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1miIlr-0001tO-VE for ged-emacs-devel@m.gmane-mx.org; Wed, 03 Nov 2021 17:05:52 +0100 Original-Received: from localhost ([::1]:54520 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1miIlp-00064u-Rw for ged-emacs-devel@m.gmane-mx.org; Wed, 03 Nov 2021 12:05:49 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:43148) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1miIhZ-00078z-Oe for emacs-devel@gnu.org; Wed, 03 Nov 2021 12:01:26 -0400 Original-Received: from heytings.org ([95.142.160.155]:51280) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1miIhX-0005Ke-Hr; Wed, 03 Nov 2021 12:01:25 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=heytings.org; s=20210101; t=1635955280; bh=UwLpO6jFt4hdghPkSQK8m5IxXZjA7duW7fCk9lKXspk=; h=Date:From:To:cc:Subject:In-Reply-To:Message-ID:References:From; b=tTrytDcbk2KxmkGI+pPAAB5Ib8ztkN47g0KvNp4BqZVq97AtISMAacHK/knNXLedT /xrbCINKNSl4BKSvEBXu2xZYqZljMjYYX/Ocr248oKXrJiJgvQ7V8sQ1raQ8mpZZFT xN0ItaYUgk0zoZcn05GP3S7liLlxvZDCPbktPuItsGIIKlqu6U9/Me5UgQCmMu+2qf Eyx5dum2nxeDijfv5dqokqBjRI7Z2VMCP++LPTw8dWGYYQgdLQwzc9LIH3+QogxyIQ /wJdefotvi5aeDv3BnB4MZ0YCqGQlI5k/dnsf3Nl9Yjgqp8oCpWP8GuBqnUQ4dCEm4 74UQEpUwhvPVA== In-Reply-To: <83v919gv9a.fsf@gnu.org> Received-SPF: pass client-ip=95.142.160.155; envelope-from=gregory@heytings.org; helo=heytings.org X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:278587 Archived-At: --0QLc6dQRsf Content-Type: text/plain; format=flowed; charset=us-ascii >> The directionality characters would be highlighted, that's all (and it >> would be easy to add a toggle command to (un)highlight them on demand, >> see attached). This functionality is orthogonal to the one you propose >> AFAIU, both could coexist. > > It could, but I don't think we should install such features. > Why not? Is this not simply an improved (and built-in) version of your initial suggestion to use glyphless-char-display? Except that glyphless-char-display is global (whereas buffer-display-table is buffer-local), and that a tofu is not as visible as a character highlighted with the font-lock-warning-face. Here's an improved patch which also highlights these characters in strings and comments. --0QLc6dQRsf Content-Type: text/x-diff; name=Make-bidi-reordering-characters-visible.patch Content-Transfer-Encoding: base64 Content-ID: <11d5fecb4499616a39a8@heytings.org> Content-Description: Content-Disposition: attachment; filename=Make-bidi-reordering-characters-visible.patch RnJvbSBjMTVkMjFiODMzZjMyODk2MTM4YWZmZmFhOWQ3YzlkOTE3ZDUyZWE3 IE1vbiBTZXAgMTcgMDA6MDA6MDAgMjAwMQ0KRnJvbTogR3JlZ29yeSBIZXl0 aW5ncyA8Z3JlZ29yeUBoZXl0aW5ncy5vcmc+DQpEYXRlOiBXZWQsIDMgTm92 IDIwMjEgMTU6NTg6MDIgKzAwMDANClN1YmplY3Q6IFtQQVRDSF0gTWFrZSBi aWRpIHJlb3JkZXJpbmcgY2hhcmFjdGVycyB2aXNpYmxlDQoNCiogbGlzcC9w cm9nbW9kZXMvcHJvZy1tb2RlLmVsIChiaWRpLXJlb3JkZXJpbmctY2hhcmFj dGVycy12aXNpYmxlLA0KYmlkaS1yZW9yZGVyaW5nLWNoYXJhY3RlcnMtZm9u dGlmeSwNCmJpZGktcmVvcmRlcmluZy1jaGFyYWN0ZXJzLXRvZ2dsZS12aXNp YmlsaXR5KTogTmV3IGZ1bmN0aW9ucy4NCi0tLQ0KIGxpc3AvcHJvZ21vZGVz L3Byb2ctbW9kZS5lbCB8IDQ3ICsrKysrKysrKysrKysrKysrKysrKysrKysr KysrKysrKysrKy0NCiAxIGZpbGUgY2hhbmdlZCwgNDYgaW5zZXJ0aW9ucygr KSwgMSBkZWxldGlvbigtKQ0KDQpkaWZmIC0tZ2l0IGEvbGlzcC9wcm9nbW9k ZXMvcHJvZy1tb2RlLmVsIGIvbGlzcC9wcm9nbW9kZXMvcHJvZy1tb2RlLmVs DQppbmRleCBkYjM1MGE1ZjcwLi5lNGY2M2IwNjQ1IDEwMDY0NA0KLS0tIGEv bGlzcC9wcm9nbW9kZXMvcHJvZy1tb2RlLmVsDQorKysgYi9saXNwL3Byb2dt b2Rlcy9wcm9nLW1vZGUuZWwNCkBAIC0yODksNiArMjg5LDUwIEBAIHR1cm4t b24tcHJldHRpZnktc3ltYm9scy1tb2RlDQogICAgICAgICAgICAgIChsb2Nh bC12YXJpYWJsZS1wICdwcmV0dGlmeS1zeW1ib2xzLWFsaXN0KSkNCiAgICAg KHByZXR0aWZ5LXN5bWJvbHMtbW9kZSAxKSkpDQogDQorKGRlZnZhci1sb2Nh bCBiaWRpLXJlb3JkZXJpbmctY2hhcmFjdGVycy12aXNpYmxlIG5pbA0KKyAg IkludGVybmFsIHZhcmlhYmxlIHVzZWQgYnkgYGJpZGktcmVvcmRlcmluZy1j aGFyYWN0ZXJzLXZpc2libGUnLiIpDQorDQorKGRlZnVuIGJpZGktcmVvcmRl cmluZy1jaGFyYWN0ZXJzLWZvbnRpZnkgKCkNCisgICJGb250aWZ5IGJpZGkg cmVvcmRlcmluZyBjaGFyYWN0ZXJzIHdpdGggYGZvbnQtbG9jay13YXJuaW5n LWZhY2UnLiINCisgIChmb250LWxvY2stYWRkLWtleXdvcmRzDQorICAgbmls DQorICAgJygoIuKBqVxcfOKArFxcfOKBqFxcfOKBp1xcfOKBplxcfOKAq1xc fOKAqlxcfOKArlxcfOKArSIgLiAoMCAnZm9udC1sb2NrLXdhcm5pbmctZmFj ZSB0KSkpKSkNCisNCisoZGVmdW4gYmlkaS1yZW9yZGVyaW5nLWNoYXJhY3Rl cnMtdmlzaWJsZSAoKQ0KKyAgIkRpc3BsYXkgYmlkaSByZW9yZGVyaW5nIGNo YXJhY3RlcnMgYXMgYXJyb3dzLiINCisgIChzZXRxIGJ1ZmZlci1kaXNwbGF5 LXRhYmxlIChvciBidWZmZXItZGlzcGxheS10YWJsZQ0KKyAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgIHN0YW5kYXJkLWRpc3BsYXktdGFibGUN CisgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAobWFrZS1kaXNw bGF5LXRhYmxlKSkpDQorICAoYmlkaS1yZW9yZGVyaW5nLWNoYXJhY3Rlci10 b2dnbGUtdmlzaWJpbGl0eSkNCisgIChhZGQtaG9vayAnZm9udC1sb2NrLW1v ZGUtaG9vayAjJ2JpZGktcmVvcmRlcmluZy1jaGFyYWN0ZXJzLWZvbnRpZnkp KQ0KKw0KKzs7OyMjI2F1dG9sb2FkDQorKGRlZnVuIGJpZGktcmVvcmRlcmlu Zy1jaGFyYWN0ZXItdG9nZ2xlLXZpc2liaWxpdHkgKCkNCisgICJUb2dnbGUg dGhlIHZpc2liaWxpdHkgb2YgYmlkaSByZW9yZGVyaW5nIGNoYXJhY3RlcnMu Ig0KKyAgKGludGVyYWN0aXZlKQ0KKyAgKHNldHEgYmlkaS1yZW9yZGVyaW5n LWNoYXJhY3RlcnMtdmlzaWJsZQ0KKyAgICAgICAgKG5vdCBiaWRpLXJlb3Jk ZXJpbmctY2hhcmFjdGVycy12aXNpYmxlKSkNCisgICh3aGVuIGJpZGktcmVv cmRlcmluZy1jaGFyYWN0ZXJzLXZpc2libGUNCisgICAgKGFzZXQgYnVmZmVy LWRpc3BsYXktdGFibGUgP+KAqiBbP+KGkl0pDQorICAgIChhc2V0IGJ1ZmZl ci1kaXNwbGF5LXRhYmxlID/igKsgWz/ihpBdKQ0KKyAgICAoYXNldCBidWZm ZXItZGlzcGxheS10YWJsZSA/4oCtIFs/4oaSXSkNCisgICAgKGFzZXQgYnVm ZmVyLWRpc3BsYXktdGFibGUgP+KAriBbP+KGkF0pDQorICAgIChhc2V0IGJ1 ZmZlci1kaXNwbGF5LXRhYmxlID/igaYgWz/ihpJdKQ0KKyAgICAoYXNldCBi dWZmZXItZGlzcGxheS10YWJsZSA/4oGnIFs/4oaQXSkNCisgICAgKGFzZXQg YnVmZmVyLWRpc3BsYXktdGFibGUgP+KBqCBbP+KGk10pDQorICAgIChhc2V0 IGJ1ZmZlci1kaXNwbGF5LXRhYmxlID/igKwgWz/ihpFdKQ0KKyAgICAoYXNl dCBidWZmZXItZGlzcGxheS10YWJsZSA/4oGpIFs/4oaRXSkpDQorICAodW5s ZXNzIGJpZGktcmVvcmRlcmluZy1jaGFyYWN0ZXJzLXZpc2libGUNCisgICAg KGFzZXQgYnVmZmVyLWRpc3BsYXktdGFibGUgP+KAqiBuaWwpDQorICAgIChh c2V0IGJ1ZmZlci1kaXNwbGF5LXRhYmxlID/igKsgbmlsKQ0KKyAgICAoYXNl dCBidWZmZXItZGlzcGxheS10YWJsZSA/4oCtIG5pbCkNCisgICAgKGFzZXQg YnVmZmVyLWRpc3BsYXktdGFibGUgP+KAriBuaWwpDQorICAgIChhc2V0IGJ1 ZmZlci1kaXNwbGF5LXRhYmxlID/igaYgbmlsKQ0KKyAgICAoYXNldCBidWZm ZXItZGlzcGxheS10YWJsZSA/4oGnIG5pbCkNCisgICAgKGFzZXQgYnVmZmVy LWRpc3BsYXktdGFibGUgP+KBqCBuaWwpDQorICAgIChhc2V0IGJ1ZmZlci1k aXNwbGF5LXRhYmxlID/igKwgbmlsKQ0KKyAgICAoYXNldCBidWZmZXItZGlz cGxheS10YWJsZSA/4oGpIG5pbCkpKQ0KKw0KIDs7OyMjI2F1dG9sb2FkDQog KGRlZmluZS1nbG9iYWxpemVkLW1pbm9yLW1vZGUgZ2xvYmFsLXByZXR0aWZ5 LXN5bWJvbHMtbW9kZQ0KICAgcHJldHRpZnktc3ltYm9scy1tb2RlIHR1cm4t b24tcHJldHRpZnktc3ltYm9scy1tb2RlKQ0KQEAgLTMwMCw3ICszNDQsOCBA QCBwcm9nLW1vZGUNCiAgIChzZXRxLWxvY2FsIHBhcnNlLXNleHAtaWdub3Jl LWNvbW1lbnRzIHQpDQogICAoYWRkLWhvb2sgJ2NvbnRleHQtbWVudS1mdW5j dGlvbnMgJ3Byb2ctY29udGV4dC1tZW51IDEwIHQpDQogICA7OyBBbnkgcHJv Z3JhbW1pbmcgbGFuZ3VhZ2UgaXMgYWx3YXlzIHdyaXR0ZW4gbGVmdCB0byBy aWdodC4NCi0gIChzZXRxIGJpZGktcGFyYWdyYXBoLWRpcmVjdGlvbiAnbGVm dC10by1yaWdodCkpDQorICAoc2V0cSBiaWRpLXBhcmFncmFwaC1kaXJlY3Rp b24gJ2xlZnQtdG8tcmlnaHQpDQorICAoYmlkaS1yZW9yZGVyaW5nLWNoYXJh Y3RlcnMtdmlzaWJsZSkpDQogDQogKHByb3ZpZGUgJ3Byb2ctbW9kZSkNCiAN Ci0tIA0KMi4zMy4wDQoNCg== --0QLc6dQRsf--