From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Drew Adams Newsgroups: gmane.emacs.bugs Subject: bug#32106: 25.2: tabulated-list-resize-current-column [PATCH INCLUDED] Date: Mon, 24 Jun 2019 08:51:04 -0700 (PDT) Message-ID: <11ba7555-6b7a-45d9-8306-da4f519e2e09@default> References: <20180709155611.qtqa2s24rzx5osye@E15-2016.optimum.net> <19b9c926-3ec6-4130-a7d8-86fb82ac7061@default> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: quoted-printable Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="194987"; mail-complaints-to="usenet@blaine.gmane.org" Cc: 32106@debbugs.gnu.org, Boruch Baum To: Lars Ingebrigtsen Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Mon Jun 24 17:54:26 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1hfRIY-000ocO-2T for geb-bug-gnu-emacs@m.gmane.org; Mon, 24 Jun 2019 17:54:26 +0200 Original-Received: from localhost ([::1]:52580 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hfRIX-0002mX-06 for geb-bug-gnu-emacs@m.gmane.org; Mon, 24 Jun 2019 11:54:25 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:51144) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hfRIB-0002kO-1j for bug-gnu-emacs@gnu.org; Mon, 24 Jun 2019 11:54:04 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hfRI9-0005Bz-TF for bug-gnu-emacs@gnu.org; Mon, 24 Jun 2019 11:54:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:44128) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1hfRI9-0005Bj-OA for bug-gnu-emacs@gnu.org; Mon, 24 Jun 2019 11:54:01 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1hfRI9-0003Vq-La for bug-gnu-emacs@gnu.org; Mon, 24 Jun 2019 11:54:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Drew Adams Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 24 Jun 2019 15:54:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 32106 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 32106-submit@debbugs.gnu.org id=B32106.156139159713433 (code B ref 32106); Mon, 24 Jun 2019 15:54:01 +0000 Original-Received: (at 32106) by debbugs.gnu.org; 24 Jun 2019 15:53:17 +0000 Original-Received: from localhost ([127.0.0.1]:57670 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hfRHR-0003Ub-Bm for submit@debbugs.gnu.org; Mon, 24 Jun 2019 11:53:17 -0400 Original-Received: from userp2120.oracle.com ([156.151.31.85]:51784) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hfRHO-0003UL-N9 for 32106@debbugs.gnu.org; Mon, 24 Jun 2019 11:53:15 -0400 Original-Received: from pps.filterd (userp2120.oracle.com [127.0.0.1]) by userp2120.oracle.com (8.16.0.27/8.16.0.27) with SMTP id x5OFn7Yg102097; Mon, 24 Jun 2019 15:53:08 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=mime-version : message-id : date : from : sender : to : cc : subject : references : in-reply-to : content-type : content-transfer-encoding; s=corp-2018-07-02; bh=QQZP+2lNvHxxZY4OTujSjkGXX591k9rQ8KW0x9DJDHM=; b=YHRs0rKGNGyQhJCiVoVBu8MuRFIdn2hwhbmSJmgs5ZamRsm+9lvo5c2Ko+9gxPQFCTtv yYLQNQeW0cCqPqxcBw5om3RswU0ga/8x4yl4sgx0PM8EgnGSDaVwcQAehncEsB1y+vfl X/ITBxD2vLiwPkgFyGQkOHkF2nm9mTcoezdsodXWAz2AoRmCdUPfTSk8D/KFi/ZHwYSd YNCBQqTXoKpJNhA5yEOMhuUKIy9CZZwe/B8TfPkxsSHUWcynAXW8b02Pci9n7CEplyBy jgUpO4WxdKCj8pArxhLjy5fhiDroiAHCqSW8diTZ0rlUhu8Z2NB/trrpcfC4Nny01LEo hQ== Original-Received: from aserp3020.oracle.com (aserp3020.oracle.com [141.146.126.70]) by userp2120.oracle.com with ESMTP id 2t9cyq7773-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Mon, 24 Jun 2019 15:53:07 +0000 Original-Received: from pps.filterd (aserp3020.oracle.com [127.0.0.1]) by aserp3020.oracle.com (8.16.0.27/8.16.0.27) with SMTP id x5OFogP7184429; Mon, 24 Jun 2019 15:51:07 GMT Original-Received: from aserv0121.oracle.com (aserv0121.oracle.com [141.146.126.235]) by aserp3020.oracle.com with ESMTP id 2t9p6tnkec-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Mon, 24 Jun 2019 15:51:07 +0000 Original-Received: from abhmp0006.oracle.com (abhmp0006.oracle.com [141.146.116.12]) by aserv0121.oracle.com (8.14.4/8.13.8) with ESMTP id x5OFp6Mu031990; Mon, 24 Jun 2019 15:51:06 GMT In-Reply-To: X-Priority: 3 X-Mailer: Oracle Beehive Extensions for Outlook 2.0.1.9.1 (1003210) [OL 16.0.4861.0 (x86)] X-Proofpoint-Virus-Version: vendor=nai engine=6000 definitions=9298 signatures=668687 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 suspectscore=0 malwarescore=0 phishscore=0 bulkscore=0 spamscore=0 mlxscore=0 mlxlogscore=886 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1810050000 definitions=main-1906240126 X-Proofpoint-Virus-Version: vendor=nai engine=6000 definitions=9298 signatures=668687 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 priorityscore=1501 malwarescore=0 suspectscore=0 phishscore=0 bulkscore=0 spamscore=0 clxscore=1015 lowpriorityscore=0 mlxscore=0 impostorscore=0 mlxlogscore=939 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1810050000 definitions=main-1906240126 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:161231 Archived-At: > Looks good. I've now added some documentation and then pushed these > changes to the trunk. >=20 > Finding the right key pair to bind these one was a struggle, though. > w/n would be natural for widen/narrow, right? But n is taken. So I > thought e/s for expand/shrink? s is taken in *Buffer List* buffers, > which is probably the most prominent use case for the mode. >=20 > So I went with w/c for widen/contract, but that's a bit eh... >=20 > Bikeshedding is welcome! FWIW, I'm not sure these commands should be bound by default. `tabulated-list-mode' is a helper mode. It's used by other modes (user-defined major modes) to build specific kinds of tables. Of course, you can say that if we bind, say, `+' and `-' in `tabulated-list-mode' then a mode that derives from it can always rebind such keys. And `t-l-m' already binds some keys, as does its parent mode, `special-mode'. Still, I'm not sure binding more keys in `t-l-m' is a good idea. (I don't oppose it; just not convinced.) In its defense, users can get used to such keys that then work (by default) across all or most uses of `t-l-m'. If you do decide to bind these commands in `t-l-m' then I'd suggest that the two keys be _obvious_ opposites (so, maybe not `w' and `c'). It's not important that they be easy to type (e.g., they can use modifiers), but it's helpful if their keys are repeatable (by just pressing and holding). FWIW, I used `+' and `-' for the same purpose in my library `buff-menu+.el' (which I had to abandon when `buff-menu.el' moved to use `t-l-m', as `t-l-m' is too simplistic and rigid for some `buff-menu+.el' features).