From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Dmitry Gutov Newsgroups: gmane.emacs.bugs Subject: bug#59935: 29.0.60; project-list-buffers is slow Date: Sun, 11 Dec 2022 20:37:51 +0200 Message-ID: <119c73c2-b219-5ee6-6fb3-c92d7ffea37d@yandex.ru> References: <86a63vi2lu.fsf@mail.linkov.net> <4a78ffcc-15fb-27ac-48b9-82fe84c596aa@yandex.ru> <86bko9na29.fsf@mail.linkov.net> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="19286"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.4.2 Cc: 59935@debbugs.gnu.org To: Juri Linkov Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sun Dec 11 19:38:17 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1p4RDM-0004t6-Or for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 11 Dec 2022 19:38:16 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1p4RD8-0005H5-Vc; Sun, 11 Dec 2022 13:38:04 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1p4RD7-0005Gs-Vw for bug-gnu-emacs@gnu.org; Sun, 11 Dec 2022 13:38:02 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1p4RD7-00085f-Nz for bug-gnu-emacs@gnu.org; Sun, 11 Dec 2022 13:38:01 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1p4RD7-0001fA-KQ for bug-gnu-emacs@gnu.org; Sun, 11 Dec 2022 13:38:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Dmitry Gutov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 11 Dec 2022 18:38:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 59935 X-GNU-PR-Package: emacs Original-Received: via spool by 59935-submit@debbugs.gnu.org id=B59935.16707838796386 (code B ref 59935); Sun, 11 Dec 2022 18:38:01 +0000 Original-Received: (at 59935) by debbugs.gnu.org; 11 Dec 2022 18:37:59 +0000 Original-Received: from localhost ([127.0.0.1]:47601 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p4RD5-0001ew-Hv for submit@debbugs.gnu.org; Sun, 11 Dec 2022 13:37:59 -0500 Original-Received: from mail-wm1-f53.google.com ([209.85.128.53]:47021) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p4RD4-0001ep-1C for 59935@debbugs.gnu.org; Sun, 11 Dec 2022 13:37:58 -0500 Original-Received: by mail-wm1-f53.google.com with SMTP id f13-20020a1cc90d000000b003d08c4cf679so3365947wmb.5 for <59935@debbugs.gnu.org>; Sun, 11 Dec 2022 10:37:57 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :sender:from:to:cc:subject:date:message-id:reply-to; bh=SXxcZTLJjIgF0ZstxsCBJE2T47wv1miMSlGS+yMQQnw=; b=qwAeebUuieKX894PX+xxX4YTqpizpj/N7Sh8xquQADXs6MrcHnPjkdtsyUqbfb1ygl K3hkj9bUFHuErCb2YW3mRgBmGmnSDArs80uHgIllQq1ReN45krnyeURixoykgaGclTP3 ncDWgwqG3r69rWnmx7MQEb9VR6xnLzSuw9IinaHB1rsb3l53jarWx55F3HTxrZrf8CCI ow6sw2c39sIixb6awLsi5cbyXtSW3/RYnQgDLSIgD0zNh709RWMfYqak2dD7fn+Nj2Rk o97W0vMO4iBcwFvSSvoN1+s2Q2T6QWfo5ImvLhd/GJQdG9fT6ErHK/NvmiTXADez9vjn ZfVA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :sender:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=SXxcZTLJjIgF0ZstxsCBJE2T47wv1miMSlGS+yMQQnw=; b=Fs+luau1EsLU1t+ryJhbL4FIHgryKfvU6Dy5RfCLOFoSYR6d30HwVcoOnxnW88r3Z4 cNJE9fXwTTIInh0QSUaIINsAcZql9qzarQKI5mL/4Xn/2D/ah71ifCQS6EfCkJ8OmuN/ y6JPdWk66zxWoYPN9KmqztcQjEPNTzmb8l4zPLF1B3RLmlMHGYoS7wysaIe56EJrbItD MmqCJ3vAPlBeBNpFDsgklxNyBwZgDLG5zRq4SzOAC66JJzpXvqI2zsqJ/gxeVygcmpUk q/lION3U+iCahjoxzHvILwEkH04SrJkO7ZKxDFIq155/foZmnXvlPinPmLDWRI0M6ZWw xtuQ== X-Gm-Message-State: ANoB5pmMsaqtTma7WF3tH75riIGbtwI2sttfBGBcID/WjjB5OKuYJhJQ NYlBFwa0wQRBkRPnCfv7xDKoWuEWRs0= X-Google-Smtp-Source: AA0mqf6KRO4h9CYICCebeXFA/sH9VW97xiAn7zfxOnEy8AeyDTPSJehteu0giwsMkwwOW1t9lqoV6w== X-Received: by 2002:a05:600c:a15:b0:3c6:f0b8:74e6 with SMTP id z21-20020a05600c0a1500b003c6f0b874e6mr10165083wmp.4.1670783872463; Sun, 11 Dec 2022 10:37:52 -0800 (PST) Original-Received: from [192.168.0.2] ([46.251.119.176]) by smtp.googlemail.com with ESMTPSA id v1-20020a5d6781000000b002422b462975sm6728860wru.34.2022.12.11.10.37.51 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 11 Dec 2022 10:37:52 -0800 (PST) Content-Language: en-US In-Reply-To: <86bko9na29.fsf@mail.linkov.net> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:250647 Archived-At: On 11/12/2022 19:07, Juri Linkov wrote: > +(defvar-local Buffer-menu-buffer-list-function nil > + "Function to return buffers for the buffer list.") > > (setq Buffer-menu-files-only > (and files-only (>= (prefix-numeric-value files-only) 0))) > - (setq Buffer-menu-filter-predicate filter-predicate) > + (when (functionp buffer-list) > + (setq Buffer-menu-buffer-list-function buffer-list)) Here's an idea: when 'list-buffers-noselect' received a plain list of buffers in its BUFFER-LIST argument, it doesn't save that anywhere. That seems like a bug, doesn't it? That hitting 'g' in such a buffer-list buffer resets its contents to all buffer (except hidden, etc). So it probably makes sense to save it as well. Long story short, I suggest to name the new variable Buffer-menu-buffer-list, and save the value of the BUFFER-LIST argument to it no matter what. And, likewise, use it. But when the value is a function, call it to obtain the actual list. One side-effect of this, though, is that the BUFFER-LIST argument to list-buffers--refresh will have no purpose anymore.