From: Dmitry Gutov <dgutov@yandex.ru>
To: Juri Linkov <juri@linkov.net>
Cc: 23484@debbugs.gnu.org
Subject: bug#23484: 25.1.50; undo doesn't work properly in xref-query-replace-in-results
Date: Mon, 9 May 2016 23:10:15 +0300 [thread overview]
Message-ID: <118c4316-9179-c9dd-e7d1-97b96921d922@yandex.ru> (raw)
In-Reply-To: <8760unxaoi.fsf@mail.linkov.net>
On 05/09/2016 11:01 PM, Juri Linkov wrote:
> Why not using an original search string instead of ‘.*’ thus avoiding
> tricks with isearch-filter-predicate/replace-re-search-function?
A few reasons:
- We don't actually save it.
- Being able to replace _any_ regexp inside the matches is a feature
(though maybe it's not going to be very popular).
- We're replacing the given list of matches, not all regexp occurrences.
> perform-replace will have no problem finding the same matches
> as found by xref.
That's not true, xref is not limited by Grep is regexp searching in the
ways that its results are found.
E.g. xref-find-references is not necessarily the result of a regexp
search. The default implementation is a bit basic, but different
backends can implement smarter logic (so that the search takes into
account the context at point, and only returns the uses of the local
variable within its scope, or only method calls, etc). We'll still want
to be able to replace them.
next prev parent reply other threads:[~2016-05-09 20:10 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-08 19:06 bug#23484: 25.1.50; undo doesn't work properly in xref-query-replace-in-results Dmitry Gutov
2016-05-08 20:19 ` Juri Linkov
2016-05-08 20:26 ` Dmitry Gutov
2016-05-09 20:01 ` Juri Linkov
2016-05-09 20:10 ` Dmitry Gutov [this message]
2016-05-09 20:19 ` Dmitry Gutov
2016-05-10 21:34 ` Juri Linkov
2016-05-10 22:03 ` Dmitry Gutov
2016-05-11 20:48 ` Juri Linkov
2016-05-11 21:11 ` Dmitry Gutov
2016-05-12 20:57 ` Juri Linkov
2016-05-12 22:01 ` Dmitry Gutov
2016-05-14 20:34 ` Juri Linkov
2016-05-14 21:13 ` Dmitry Gutov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=118c4316-9179-c9dd-e7d1-97b96921d922@yandex.ru \
--to=dgutov@yandex.ru \
--cc=23484@debbugs.gnu.org \
--cc=juri@linkov.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.