From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Bill Wohler Newsgroups: gmane.emacs.bugs Subject: bug#13824: 24.3.50; :package-version not taking priority over :version Date: Sat, 10 Aug 2019 15:10:13 -0700 Organization: Newt Software Message-ID: <116969.1565475013@olgas.newt.com> References: <87txozc7c4.fsf@bzg.ath.cx> <83sgq98jet.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="241067"; mail-complaints-to="usenet@blaine.gmane.org" Cc: bzg@altern.org, Stefan Kangas , 13824@debbugs.gnu.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sun Aug 11 00:11:15 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1hwZZz-0010ZP-D0 for geb-bug-gnu-emacs@m.gmane.org; Sun, 11 Aug 2019 00:11:15 +0200 Original-Received: from localhost ([::1]:38194 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hwZZy-0003U9-Fm for geb-bug-gnu-emacs@m.gmane.org; Sat, 10 Aug 2019 18:11:14 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:33352) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hwZZn-0003U3-Pd for bug-gnu-emacs@gnu.org; Sat, 10 Aug 2019 18:11:05 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hwZZm-00042j-Bu for bug-gnu-emacs@gnu.org; Sat, 10 Aug 2019 18:11:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:35722) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1hwZZm-00042a-8F for bug-gnu-emacs@gnu.org; Sat, 10 Aug 2019 18:11:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1hwZZm-0001NN-2X for bug-gnu-emacs@gnu.org; Sat, 10 Aug 2019 18:11:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Bill Wohler Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 10 Aug 2019 22:11:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 13824 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: confirmed Original-Received: via spool by 13824-submit@debbugs.gnu.org id=B13824.15654750465242 (code B ref 13824); Sat, 10 Aug 2019 22:11:02 +0000 Original-Received: (at 13824) by debbugs.gnu.org; 10 Aug 2019 22:10:46 +0000 Original-Received: from localhost ([127.0.0.1]:44543 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hwZZS-0001MK-0c for submit@debbugs.gnu.org; Sat, 10 Aug 2019 18:10:46 -0400 Original-Received: from ecbiz204.inmotionhosting.com ([173.205.126.238]:55815) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hwZZP-0001Lx-OK for 13824@debbugs.gnu.org; Sat, 10 Aug 2019 18:10:40 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=newt.com; s=default; h=Message-ID:Date:Content-ID:Content-Type:MIME-Version:References :In-reply-to:Subject:From:cc:To:Sender:Reply-To:Content-Transfer-Encoding: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=Ndk0t4Y5clVvsvE00QKDXqiSyokb+oxxwoR3Oi4yrgs=; b=YeGBOa4fa9R1/3XrPOupbowB/t NvlRiAGZs1dL4NFjw+u6ewyVbBZdJNmO3beeNzpaPu6KdbxXWEFBQjoeGyMACOeFDwBLRV7jzXpbw MiOLY/WmPcpCUFC/Cmkz+brHxStql+SFpzeVWKSs3Va3tQUwYvMKwOt0hXSVknEFnb6A83KGm0sHM 6gTTW0I/vBQRdjxyByFnlqFL+WCiAyCER+pB857clXXzdYTpwmIM1e/gwkaIJCXHYlO0qxGshLXAe 9I9yaSEyXxI4iuHXM25HBBpxRhZ6cq47TVan5NXnv4qGvZ+7qOFR9paoY8jIhqzVZ90+WyZXU+A5G GkEE30uQ==; Original-Received: from [73.162.57.71] (port=56530 helo=olgas.newt.com) by ecbiz204.inmotionhosting.com with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.92) (envelope-from ) id 1hwZZ0-005f29-84; Sat, 10 Aug 2019 18:10:31 -0400 Original-Received: by olgas.newt.com (Postfix, from userid 1000) id BDECF3802AB; Sat, 10 Aug 2019 15:10:13 -0700 (PDT) In-reply-to: <83sgq98jet.fsf@gnu.org> Comments: In-reply-to Eli Zaretskii message dated "Sat, 10 Aug 2019 12:22:02 +0300." X-Mailer: MH-E 8.6; nmh 1.6; GNU Emacs 24.5.1 X-Image-URL: http://www.newt.com/wohler/images/bill-diving.png Content-ID: <116968.1565475013.1@olgas.newt.com> X-OutGoing-Spam-Status: No, score=-1.0 X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - ecbiz204.inmotionhosting.com X-AntiAbuse: Original Domain - debbugs.gnu.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - newt.com X-Get-Message-Sender-Via: ecbiz204.inmotionhosting.com: authenticated_id: wohler@newt.com X-Authenticated-Sender: ecbiz204.inmotionhosting.com: wohler@newt.com X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:164865 Archived-At: Eli Zaretskii wrote: > > From: Stefan Kangas > > Date: Thu, 8 Aug 2019 05:59:21 +0200 > > Cc: 13824@debbugs.gnu.org > > > > Bastien Guerry writes: > > > > > The docstring of `defcustom' says: > > > > > > :package-version > > > VALUE should be a list with the form (PACKAGE . VERSION) > > > specifying that the variable was first introduced, or its > > > default value was changed, in PACKAGE version VERSION. This > > > keyword takes priority over :version. > > > ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ > > > > > > but `describe-variable-custom-version-info' gives priority to :version > > > over :package-version. Which one is correct here? > > > > This is still an issue on current master (and 26.2). > > > > I reproduced this using: > > > > (progn > > (defcustom foobar nil > > "foo" > > :version "27.1" > > :package-version '(foo . "1")) > > (describe-variable-custom-version-info 'foobar)) > > > > Which results in: > > > > "This variable was introduced, or its default value was changed, in > > version 27.1 of Emacs. > > " > > > > But C-h f defcustom says: > > > > :package-version > > VALUE should be a list with the form (PACKAGE . VERSION) > > specifying that the variable was first introduced, or its > > default value was changed, in PACKAGE version VERSION. This > > keyword takes priority over :version. > > The implementation only prefers :package-version for the purposes of > customize-changed-options, i.e. the Options->Customize Emacs->New > Options menu item. By contrast, describe-variable-custom-version-info > is used for displaying the doc strings of options. For a package that > is bundled with Emacs, I think displaying :version in "C-h v" makes > sense. If people agree, then this is a minor documentation bug (also > to be fixed in the ELisp manual), not a code bug. > > Bill, what is your take on this? Your change, which introduced this > attribute, only modified customize-changed-options. Was that on > purpose? Thanks for asking. The original intent of package-version was to provide more accurate version information in packages that were updated more often than Emacs, regardless of whether they were packaged in Emacs (like MH-E and Gnus) or not. I think that should apply to any function that displays version information for an option. That is, any function that looks for :version should also look for :package-version. -- Bill Wohler aka http://www.newt.com/wohler/, GnuPG ID:610BD9AD