From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Andre Spiegel Newsgroups: gmane.emacs.devel Subject: Re: [simon.marshall@misys.com: vc-diff uses unknown -L switch] Date: Fri, 23 Jun 2006 18:35:41 +0100 Message-ID: <1151084141.18320.19.camel@localhost> References: <1150630533.17525.3.camel@localhost> NNTP-Posting-Host: main.gmane.org Mime-Version: 1.0 Content-Type: text/plain Content-Transfer-Encoding: 7bit X-Trace: sea.gmane.org 1151084141 22217 80.91.229.2 (23 Jun 2006 17:35:41 GMT) X-Complaints-To: usenet@sea.gmane.org NNTP-Posting-Date: Fri, 23 Jun 2006 17:35:41 +0000 (UTC) Cc: Simon Marshall , Stefan Monnier , emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Fri Jun 23 19:35:37 2006 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by ciao.gmane.org with esmtp (Exim 4.43) id 1FtpZ7-0005hE-L2 for ged-emacs-devel@m.gmane.org; Fri, 23 Jun 2006 19:35:33 +0200 Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1FtpZ7-0007X4-4r for ged-emacs-devel@m.gmane.org; Fri, 23 Jun 2006 13:35:33 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1FtpYu-0007Sf-U2 for emacs-devel@gnu.org; Fri, 23 Jun 2006 13:35:21 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1FtpYt-0007Ok-10 for emacs-devel@gnu.org; Fri, 23 Jun 2006 13:35:20 -0400 Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1FtpYs-0007OV-UZ for emacs-devel@gnu.org; Fri, 23 Jun 2006 13:35:18 -0400 Original-Received: from [193.113.160.16] (helo=mail.o2.co.uk) by monty-python.gnu.org with esmtp (Exim 4.52) id 1Ftpk7-0004hv-1z; Fri, 23 Jun 2006 13:46:55 -0400 Original-Received: from [80.187.149.11] (80.187.149.11) by mail.o2.co.uk (7.0.045) id 447CE28B00426767; Fri, 23 Jun 2006 18:35:16 +0100 Original-To: rms@gnu.org In-Reply-To: X-Mailer: Evolution 2.6.2 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:56126 Archived-At: > Whoever looks at this, would you please ack this message > when it is done? I've just installed a patch to deal with this. It uses the same mechanism that VC already uses to find out if rcsdiff understands the --brief option. VC will first try to use -L, and then remember whether it worked in the new variable vc-diff-knows-L. The patch assumes that a "diff" that does not understand -L returns error code 2 when the option is used. I have not been able to verify this with Solaris 8 diff, but I'm pretty sure that this is how it's reported. If anybody sees a more elegant way to implement this, please don't hesitate to change it.