From: Andre Spiegel <spiegel@gnu.org>
Cc: emacs-devel@gnu.org
Subject: Re: Rewrite of vc-user-login-name
Date: Wed, 25 Jan 2006 19:42:22 +0100 [thread overview]
Message-ID: <1138214542.6634.3.camel@localhost> (raw)
In-Reply-To: <E1F1RKK-0000i3-O7@fencepost.gnu.org>
On Tue, 2006-01-24 at 11:47 -0500, Richard M. Stallman wrote:
> Here's a patch that closes a long standing issue, removing the need for
> Tramp to advise vc-user-login-name. I'm not quite sure how to install
> it, though: should I just remove the advice in tramp-vc.el?
>
> What is the cause of your doubts?
> In general, updating the source is all one needs to do
> for a change in the Lisp code. Occasionally one needs
> to update loaddefs.el, but that's not relevant here.
I wasn't sure how the advice mechanism actually works, and I thought
that maybe my change could have forced people to recompile Emacs to make
it work. Also, I'm not the maintainer of tramp-vc.el, so I thought I'd
better ask.
I will install the changes now and comment out the defadvice in
tramp-vc.el. Michael Albinus can then have a closer look.
next prev parent reply other threads:[~2006-01-25 18:42 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-01-22 16:19 Rewrite of vc-user-login-name Andre Spiegel
2006-01-22 22:22 ` Michael Albinus
2006-01-24 16:47 ` Richard M. Stallman
2006-01-25 18:42 ` Andre Spiegel [this message]
2006-01-27 19:52 ` Michael Albinus
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1138214542.6634.3.camel@localhost \
--to=spiegel@gnu.org \
--cc=emacs-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.