From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Timo Savola Newsgroups: gmane.emacs.devel Subject: Re: GtkPlug patch Date: Thu, 05 Jan 2006 08:13:47 +0200 Message-ID: <1136441628.8537.15.camel@localhost.localdomain> References: <200601030753.k037rc1o021950@coolsville.localdomain> <85d5j9f99e.fsf@lola.goethe.zz> <8E272012-0E75-4566-A9A6-F2BC92C43440@swipnet.se> NNTP-Posting-Host: main.gmane.org Mime-Version: 1.0 Content-Type: text/plain Content-Transfer-Encoding: 7bit X-Trace: sea.gmane.org 1136441658 13908 80.91.229.2 (5 Jan 2006 06:14:18 GMT) X-Complaints-To: usenet@sea.gmane.org NNTP-Posting-Date: Thu, 5 Jan 2006 06:14:18 +0000 (UTC) Cc: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Thu Jan 05 07:14:15 2006 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by ciao.gmane.org with esmtp (Exim 4.43) id 1EuOO3-0006s0-Hd for ged-emacs-devel@m.gmane.org; Thu, 05 Jan 2006 07:14:12 +0100 Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1EuOPl-0007r4-Jq for ged-emacs-devel@m.gmane.org; Thu, 05 Jan 2006 01:15:57 -0500 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1EuOPX-0007pn-R7 for emacs-devel@gnu.org; Thu, 05 Jan 2006 01:15:44 -0500 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1EuOPW-0007oF-12 for emacs-devel@gnu.org; Thu, 05 Jan 2006 01:15:43 -0500 Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1EuOPV-0007o1-RI for emacs-devel@gnu.org; Thu, 05 Jan 2006 01:15:41 -0500 Original-Received: from [213.243.153.37] (helo=smtp1.pp.htv.fi) by monty-python.gnu.org with esmtp (Exim 4.34) id 1EuOR2-0007es-DK for emacs-devel@gnu.org; Thu, 05 Jan 2006 01:17:16 -0500 Original-Received: from [192.168.1.100] (cs78235208.pp.htv.fi [62.78.235.208]) by smtp1.pp.htv.fi (Postfix) with ESMTP id 548567FC36; Thu, 5 Jan 2006 08:13:48 +0200 (EET) Original-To: "Jan D." In-Reply-To: <8E272012-0E75-4566-A9A6-F2BC92C43440@swipnet.se> X-Mailer: Evolution 2.4.1 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:48741 Archived-At: > > If all of this is not the case, then the respective code paths would > > basically just get exercised when one explicitly does something that > > one could not do before. If there are just a few such code spaces, > > the impact on the general release quality would be negligible. > > Yes, that is true. But I suspect that if we put this in now we will > get bug reports about things like keyboard focus, which doesn't work > correctly with this patch (due to the fact that Emacs isn't a "pure" > GTK implementation). A weird thing about the GtkPlugged Emacs is that it seems to work perfectly when some window managers (Ion) are used, but not that well with others (Openbox, Metacity). Perhaps this can be addressed in a hand-written XEmbed implementation. > But if the author is willing to handle those bug reports, we can put > this patch in now. It is a very small change, and very safe in that > it does not alter the normal code path unless you use --parent-id. I wonder if this is the case with the emacs-parent-fix.patch. I don't understand what the code was trying to do, unless it was simply buggy. timo