From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Drew Adams Newsgroups: gmane.emacs.bugs Subject: bug#17388: 24.4.50; REGRESSION: Ediff - 1) wrong face, 2) incorrect diffing Date: Fri, 2 May 2014 20:11:54 -0700 (PDT) Message-ID: <111c9271-6a23-426e-adb2-ff5520c02806@default> References: <87wqe43t55.fsf@rosalinde.fritz.box> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: quoted-printable X-Trace: ger.gmane.org 1399086812 10790 80.91.229.3 (3 May 2014 03:13:32 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Sat, 3 May 2014 03:13:32 +0000 (UTC) Cc: 17388-done@debbugs.gnu.org, Michael Kifer To: Stefan Monnier Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sat May 03 05:13:24 2014 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1WgQOB-0006m5-D2 for geb-bug-gnu-emacs@m.gmane.org; Sat, 03 May 2014 05:13:23 +0200 Original-Received: from localhost ([::1]:47113 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WgQOA-0000qs-Lr for geb-bug-gnu-emacs@m.gmane.org; Fri, 02 May 2014 23:13:22 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:60520) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WgQNz-0000ny-9C for bug-gnu-emacs@gnu.org; Fri, 02 May 2014 23:13:19 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WgQNq-0005jh-Gk for bug-gnu-emacs@gnu.org; Fri, 02 May 2014 23:13:11 -0400 Original-Received: from debbugs.gnu.org ([140.186.70.43]:59847) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WgQNq-0005jb-D5 for bug-gnu-emacs@gnu.org; Fri, 02 May 2014 23:13:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.80) (envelope-from ) id 1WgQNp-00076V-Ow for bug-gnu-emacs@gnu.org; Fri, 02 May 2014 23:13:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Drew Adams Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 03 May 2014 03:13:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 17388 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 17388-done@debbugs.gnu.org id=D17388.139908673127222 (code D ref 17388); Sat, 03 May 2014 03:13:01 +0000 Original-Received: (at 17388-done) by debbugs.gnu.org; 3 May 2014 03:12:11 +0000 Original-Received: from localhost ([127.0.0.1]:48965 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1WgQN0-00074z-Ku for submit@debbugs.gnu.org; Fri, 02 May 2014 23:12:11 -0400 Original-Received: from aserp1040.oracle.com ([141.146.126.69]:22127) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1WgQMw-00074Q-Ok for 17388-done@debbugs.gnu.org; Fri, 02 May 2014 23:12:07 -0400 Original-Received: from ucsinet21.oracle.com (ucsinet21.oracle.com [156.151.31.93]) by aserp1040.oracle.com (Sentrion-MTA-4.3.2/Sentrion-MTA-4.3.2) with ESMTP id s433BvoP026397 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Sat, 3 May 2014 03:11:58 GMT Original-Received: from aserz7021.oracle.com (aserz7021.oracle.com [141.146.126.230]) by ucsinet21.oracle.com (8.14.4+Sun/8.14.4) with ESMTP id s433BtVk028120 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Sat, 3 May 2014 03:11:56 GMT Original-Received: from abhmp0012.oracle.com (abhmp0012.oracle.com [141.146.116.18]) by aserz7021.oracle.com (8.14.4+Sun/8.14.4) with ESMTP id s433BtJB029653; Sat, 3 May 2014 03:11:55 GMT In-Reply-To: X-Priority: 3 X-Mailer: Oracle Beehive Extensions for Outlook 2.0.1.8 (707110) [OL 12.0.6691.5000 (x86)] X-Source-IP: ucsinet21.oracle.com [156.151.31.93] X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:88566 Archived-At: > >> See the attached screenshot. The first diff shown, with the gray > >> highlighting, shows the regression. >=20 > I installed the patch below which should fix those problems, thanks. >=20 > >> 2. The fine diffs are also not correct. See the same screenshot. For > >> the first diff, "advertise" and "d-signature-table" should be > >> highlighted the same as "(defvar " and ")", and for the second diff, > >> "fil" and "s-alist" should be highlighted the same as "(defvar " and > >> ")". These are not differences. >=20 > You mean you want finer granularity of fine diffs. Not at all. How do you get that from what I said? There should be EITHER, (a) as previously, NO fine diffs shown for other than the current diff OR (b) CORRECT (helpful) fine diffs shown for the non-current diffs. In the text you quoted I spoke only of (a): return to the previous behavior of NOT showing fine diffs except for the current diff. > >> still a regression wrt prior Emacs versions. With Emacs 24.3, for > >> instance (using the same Cygwin `diff'), there is no fine diff shown > >> here. Instead, the diff, which is shown only as a main diff, is betwe= en > >> "file-local-variables-alist" and "filxxxxxxxxxxxxxxxxxxxxxs-alist". > >> Which is correct. >=20 > I don't see that here with Debian's Emacs-24.3, and neither with 23.4. It's not very clear from the above what you see and do not see, especially since you apparently did not understand the description. Do you see a bug for Emacs 24.3 or 23.4? There is none that I see - the behavior is as I described it. No fine diffs are shown for the non-current diff highlighting with Emacs 24.3 or 23.4. Are you sure you are looking at the non-current diffs (the gray ones)? That's where both bugs are: (1) wrong face (`default'), (2) incorrect fine diffing. I just repeated everything, again starting from emacs -Q with the above recipe, using 24.3. That's 5 times now I've done it (2x for 24.4, 24.3, 1x for 23.4). Same thing - just what I described originally. > The behavior you describe seems to correspond to ediff-word-mode, IIRC, > so I assume this is not really a bug/regression but just a pilot error > on your part. If not, feel free to re-open this bug report, providing > more details about the problem. I can no longer reopen bugs - Glenn apparently banned me some time ago. This has nothing to do with `ediff-word-mode' or pilot error. What I showed and described was already from emacs -Q. And S. Berman had no trouble following the recipe and confirming the behavior. But let me try again. emacs -Q Load file `cygwin-mount.el', then `setup-cygwin.el' (from Emacs Wiki). Cygwin `diff' is apparently irrelevant, but that's what I used anyway. In foo.el type some text. E.g.: (defvar advertised-signature-table) (defvar dir-local-variables-alist) (defvar dir-locals-file) (defvar file-local-variables-alist) (defvar Info-indexed-nodes) Put the same text in bar.el. Then modify it a bit in bar.el: (defvar advertiseyyyyyyyyyyyd-signature-table) (defvar dir-local-variables-alist) (defvar dir-locals-file) (defvar filxxxxxxxxxxxxxxs-alist) (defvar Info-indexed-nodes) M-x ediff-buffers ; for foo.el and bar.el Cycle among the two diffs. You will see the screenshot I sent. Now read the bug report as to what is wrong with what you see, if it is still not clear why it is a bug (2 bugs). Stephen Berman's confirmation indicates that Cygwin `diff' is irrelevant: > I see both of these problematic highlightings on GNU/Linux builds from > both the trunk (bzr 117042) and the emacs-24 branch (bzr 117049).