From mboxrd@z Thu Jan 1 00:00:00 1970 Path: main.gmane.org!not-for-mail From: Andre Spiegel Newsgroups: gmane.emacs.devel Subject: Re: behavior of vc-recompute-state in combination with vc-cvs-stay-local is t Date: Tue, 30 Nov 2004 12:08:01 +0100 Message-ID: <1101812881.15479.21.camel@localhost> References: <1B3ACCFD5694A94DBA4E231402B0E9ED57AECB@mucmail1.sdm.de> NNTP-Posting-Host: deer.gmane.org Mime-Version: 1.0 Content-Type: text/plain Content-Transfer-Encoding: 7bit X-Trace: sea.gmane.org 1101812978 15702 80.91.229.6 (30 Nov 2004 11:09:38 GMT) X-Complaints-To: usenet@sea.gmane.org NNTP-Posting-Date: Tue, 30 Nov 2004 11:09:38 +0000 (UTC) Cc: Stefan Monnier , emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Tue Nov 30 12:09:15 2004 Return-path: Original-Received: from lists.gnu.org ([199.232.76.165]) by deer.gmane.org with esmtp (Exim 3.35 #1 (Debian)) id 1CZ5sh-0004ob-00 for ; Tue, 30 Nov 2004 12:09:15 +0100 Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.33) id 1CZ628-00066S-Cf for ged-emacs-devel@m.gmane.org; Tue, 30 Nov 2004 06:19:00 -0500 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.33) id 1CZ61B-0005sA-8s for emacs-devel@gnu.org; Tue, 30 Nov 2004 06:18:01 -0500 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.33) id 1CZ61A-0005rf-C7 for emacs-devel@gnu.org; Tue, 30 Nov 2004 06:18:00 -0500 Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.33) id 1CZ61A-0005ra-8S for emacs-devel@gnu.org; Tue, 30 Nov 2004 06:18:00 -0500 Original-Received: from [193.113.160.41] (helo=mail.o2.co.uk) by monty-python.gnu.org with esmtp (Exim 4.34) id 1CZ5rH-00013K-PG for emacs-devel@gnu.org; Tue, 30 Nov 2004 06:07:47 -0500 Original-Received: from [217.231.186.110] (217.231.186.110) by mail.o2.co.uk (7.0.028) (authenticated as andre.spiegel@o2online.de) id 40EC1F6B01B5DC2D; Tue, 30 Nov 2004 11:05:06 +0000 Original-To: klaus.berndl@sdm.de In-Reply-To: <1B3ACCFD5694A94DBA4E231402B0E9ED57AECB@mucmail1.sdm.de> X-Mailer: Evolution 2.0.2 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: main.gmane.org gmane.emacs.devel:30525 X-Report-Spam: http://spam.gmane.org/gmane.emacs.devel:30525 On Mon, 2004-11-29 at 17:31 +0100, klaus.berndl@sdm.de wrote: > 4. Running (vc-recompute-state "/a/file/under/remote-repository-CVS/file.txt") > ==> returns always nil, because the state-binding in the vc-cvs-state is > always nil for that file. The code was simply based on the assumption that vc-recompute-state would only be called for files that are already visited. In this case, vc-state can never be nil because we compute it at visiting time already. I've changed this now and moved vc-recompute-state into vc-hooks.el. It should always return a valid state now.