From: Dmitry Gutov <dgutov@yandex.ru>
To: emacs-devel@gnu.org, Noam Postavsky <npostavs@gmail.com>
Subject: Re: [Emacs-diffs] master 644cdd1: Use grep's --null option (Bug#6843)
Date: Wed, 26 Jul 2017 19:58:32 +0300 [thread overview]
Message-ID: <10f1ac4b-aca5-53e9-5112-b8312471df82@yandex.ru> (raw)
In-Reply-To: <20170720000210.0E44020A56@vcs0.savannah.gnu.org>
Hey Noam,
Sorry I'm late to the party. Some questions below. Thanks.
On 7/20/17 3:02 AM, Noam Postavsky wrote:
> branch: master
> commit 644cdd1aa0a10dbfffa3b9b4c7a97f8cddded0b8
> Author: Noam Postavsky <npostavs@gmail.com>
> Commit: Noam Postavsky <npostavs@gmail.com>
...
> +*** Grep commands will now use GNU grep's '--null' option if
> +available, which allows distinguishing the filename from contents if
> +they contain colons. This can be controlled by the new custom option
> +'grep-use-null-filename-separator'.
Why do the want the option?
And on the same note, are there any versions of Grep in widespread usage
that don't support '--null'? AFAICT this flag was added to GNU Grep 2.4
which was released in 1999.
> +(defconst grep--regexp-alist-bin-matcher
> + '("^Binary file \\(.+\\) matches$" 1 nil nil 0 1))
> +(defconst grep-with-null-regexp-alist
> + `(("^\\([^\0]+\\)\\(\0\\)\\([0-9]+\\):" 1 3 ,grep--regexp-alist-column nil nil
Any reason to change 2 to 3? Why don't we use a non-capturing group for
\0 here?
If the numbers are the same, we could keep the variable's name the same
as well. As a result, most third-party code would continue to simply work.
> + (2 '(face unspecified display ":")))
> + ,grep--regexp-alist-bin-matcher)
> + "Regexp used to match grep hits.
> +See `compilation-error-regexp-alist'.")
> +(defconst grep-fallback-regexp-alist
Compensating for the multitude of variables by eliminating newlines
between them doesn't look too hot to me.
next parent reply other threads:[~2017-07-26 16:58 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20170720000208.23054.66272@vcs0.savannah.gnu.org>
[not found] ` <20170720000210.0E44020A56@vcs0.savannah.gnu.org>
2017-07-26 16:58 ` Dmitry Gutov [this message]
2017-07-26 18:10 ` [Emacs-diffs] master 644cdd1: Use grep's --null option (Bug#6843) Michael Albinus
2017-07-27 12:01 ` Dmitry Gutov
2017-07-27 12:51 ` Alexis
2017-07-27 12:53 ` Herring, Davis
2017-07-27 13:09 ` Kaushal Modi
2017-07-27 13:30 ` Michael Albinus
2017-07-27 13:55 ` Dmitry Gutov
2017-07-26 18:54 ` Andreas Schwab
2017-07-26 19:01 ` Eli Zaretskii
2017-07-26 23:31 ` Noam Postavsky
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=10f1ac4b-aca5-53e9-5112-b8312471df82@yandex.ru \
--to=dgutov@yandex.ru \
--cc=emacs-devel@gnu.org \
--cc=npostavs@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.