From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Dmitry Gutov Newsgroups: gmane.emacs.devel Subject: Re: Missing entries for Perl in etags-regen-file-extensions -- okay for emacs-30? Date: Fri, 20 Sep 2024 21:20:59 +0300 Message-ID: <10dd3554-4249-41d1-864d-30cab687da6a@gutov.dev> References: <87y13mznw9.fsf@zephyr.silentflame.com> <86h6aa7gw1.fsf@gnu.org> <87ploya1hc.fsf@zephyr.silentflame.com> <867cb67888.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="18608"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Mozilla Thunderbird Cc: emacs-devel@gnu.org To: Eli Zaretskii , Sean Whitton Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Fri Sep 20 20:22:13 2024 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1sriGi-0004g2-Tb for ged-emacs-devel@m.gmane-mx.org; Fri, 20 Sep 2024 20:22:13 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1sriFk-0001YX-4y; Fri, 20 Sep 2024 14:21:12 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sriFi-0001YK-55 for emacs-devel@gnu.org; Fri, 20 Sep 2024 14:21:10 -0400 Original-Received: from fhigh1-smtp.messagingengine.com ([103.168.172.152]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sriFf-0005Bx-Cw; Fri, 20 Sep 2024 14:21:09 -0400 Original-Received: from phl-compute-02.internal (phl-compute-02.phl.internal [10.202.2.42]) by mailfhigh.phl.internal (Postfix) with ESMTP id 3E1C1114018E; Fri, 20 Sep 2024 14:21:04 -0400 (EDT) Original-Received: from phl-mailfrontend-02 ([10.202.2.163]) by phl-compute-02.internal (MEProxy); Fri, 20 Sep 2024 14:21:04 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gutov.dev; h=cc :cc:content-transfer-encoding:content-type:content-type:date :date:from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:subject:subject:to:to; s=fm3; t=1726856464; x=1726942864; bh=Ejx6G7hbucwB1KMCuFhl1w5JfYqfDIgW4XukrrFiMfA=; b= FlJ91/65T33/lwa8bEUDHTY+rdm7Lm/bnjUcQKgcueV8RleGCz3DuHrM11b2DBRC K2dciKA/06MuRiNTAKhpGB+ANjA+1CkmnbmQDSgZiQaE0xCpCxitFf2GKbqH9UXu BZjdY5HSCTF4yUADPPFhHfqasO8w+tMqUAkdwlZFDQlS8T/0jrV4ok+aSCaxiPa8 a7BEw0WU8WtM8VSgO6wKbZxEF1kcEe65tsORB6jHKDAvdl4hjCvwvNkS1pHv49PW 4qt/IHiOuK7u9QwgKmzx+iOycy+YTOMntEJIurMF+2X2+RMTJxF8khFyvhJ59YY+ VhoiHK5IP9j9SS/WqC9FEw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:content-type:date:date:feedback-id:feedback-id :from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:subject:subject:to:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm2; t=1726856464; x= 1726942864; bh=Ejx6G7hbucwB1KMCuFhl1w5JfYqfDIgW4XukrrFiMfA=; b=V mjf/oDxOeZUZs4XO2kSERBohSSv4vlvrnUnnlLBWMX2gIQBXSTO+EjMTptj8k1uZ u3Uq6oNc/p/0S0auhXWQrRWlvrRKYxxWeVVqVR5YTOyXypAXM9KLTaUga2xod/xV tiv7yameGhmIDJKdnr5kuquU7C/yc2VG+fSRnzjJAfDfJaZwHhcPOcmkKUA7sJPs BRilT58zimQe56M+qF+GGBrm+yjRKfoIL2SYtM8NyrFESMlyJhV8oPL+Up65Po6m d5VDZvWJK6D51QP2FzIzhnHNrEUd/SI0txt3s9UkJlTpoIcAmz1ozJyXCMQMuhgw 42NaRL98YvDLx7xkON5Ag== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeeftddrudelfedguddvhecutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpggftfghnshhusghstghrihgsvgdp uffrtefokffrpgfnqfghnecuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivg hnthhsucdlqddutddtmdenucfjughrpefkffggfgfuvfevfhfhjggtgfesthejredttddv jeenucfhrhhomhepffhmihhtrhihucfiuhhtohhvuceoughmihhtrhihsehguhhtohhvrd guvghvqeenucggtffrrghtthgvrhhnpeffieefvdelueektdfgleeigedugfevkeefjeev jeffteffueeuueeghfevieduvdenucffohhmrghinhepghhnuhdrohhrghenucevlhhush htvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpegumhhithhrhiesghhu thhovhdruggvvhdpnhgspghrtghpthhtohepfedpmhhouggvpehsmhhtphhouhhtpdhrtg hpthhtohepvghlihiisehgnhhurdhorhhgpdhrtghpthhtohepshhpfihhihhtthhonhes shhpfihhihhtthhonhdrnhgrmhgvpdhrtghpthhtohepvghmrggtshdquggvvhgvlhesgh hnuhdrohhrgh X-ME-Proxy: Feedback-ID: i07de48aa:Fastmail Original-Received: by mail.messagingengine.com (Postfix) with ESMTPA; Fri, 20 Sep 2024 14:21:02 -0400 (EDT) Content-Language: en-US In-Reply-To: <867cb67888.fsf@gnu.org> Received-SPF: pass client-ip=103.168.172.152; envelope-from=dmitry@gutov.dev; helo=fhigh1-smtp.messagingengine.com X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:323858 Archived-At: Hi! On 20/09/2024 16:41, Eli Zaretskii wrote: >>>> diff --git a/lisp/progmodes/etags-regen.el b/lisp/progmodes/etags-regen.el >>>> index 21ea9bfb8b3..e97b0cd7574 100644 >>>> --- a/lisp/progmodes/etags-regen.el >>>> +++ b/lisp/progmodes/etags-regen.el >>>> @@ -119,7 +119,7 @@ etags-regen-regexp-alist >>>> ;;http://lists.gnu.org/archive/html/emacs-devel/2018-01/msg00323.html >>>> (defcustom etags-regen-file-extensions >>>> '("rb" "js" "py" "pl" "el" "c" "cpp" "cc" "h" "hh" "hpp" >>>> - "java" "go" "cl" "lisp" "prolog" "php" "erl" "hrl" >>>> + "java" "go" "cl" "lisp" "prolog" "php" "erl" "hrl" "pl" "pm" >>>> "F" "f" "f90" "for" "cs" "a" "asm" "ads" "adb" "ada") >>>> "Code file extensions for `etags-regen-mode'. >>> We already have "pl" in the list. Adding "pm" is okay, but then why >>> only it? why not add all the extensions that 'etags' supports? Adding "pm" sounds good. "All supported extensions" (or most) might be a good idea as well. As long as the additions are not misdetected often - false positives based on obscure languages might be a nuisance. >> Okay thanks, I'll add "pm" so we don't have just one Perl extension, and >> hopefully we can figure out a better solution for master. > My question about adding more extensions was for emacs-30. > > Let's wait for Dmitry to chime in, and take it from there. The reason why is that etags parses files with unknown extensions as Fortran sources, and there is currently no opt-out. See this thread: https://lists.gnu.org/archive/html/emacs-devel/2018-01/msg00323.html The same issue stops us from benefiting from etags' hashbang detection.