From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: David Reitter Newsgroups: gmane.emacs.bugs Subject: bug#3303: delete-frame raises old (invisible) frame Date: Tue, 26 May 2009 14:20:22 -0400 Message-ID: <10D37A53-45B3-46C2-8F2B-C38534094A93@cmu.edu> References: <513F6DDF-F57F-4C8E-A2ED-C2163183BFF0@cmu.edu> Reply-To: David Reitter , 3303@emacsbugs.donarmstrong.com NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 (Apple Message framework v935.3) Content-Type: multipart/signed; boundary=Apple-Mail-36-914333579; micalg=sha1; protocol="application/pkcs7-signature" X-Trace: ger.gmane.org 1243362586 15079 80.91.229.12 (26 May 2009 18:29:46 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Tue, 26 May 2009 18:29:46 +0000 (UTC) Cc: 3303@emacsbugs.donarmstrong.com, Chong Yidong , Adrian Robert To: Stefan Monnier Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Tue May 26 20:29:42 2009 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1M91P7-0000kS-1O for geb-bug-gnu-emacs@m.gmane.org; Tue, 26 May 2009 20:29:37 +0200 Original-Received: from localhost ([127.0.0.1]:47894 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1M91P6-00049L-D1 for geb-bug-gnu-emacs@m.gmane.org; Tue, 26 May 2009 14:29:36 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1M91Oq-0003tR-Jq for bug-gnu-emacs@gnu.org; Tue, 26 May 2009 14:29:20 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1M91Om-0003ne-L6 for bug-gnu-emacs@gnu.org; Tue, 26 May 2009 14:29:20 -0400 Original-Received: from [199.232.76.173] (port=58832 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1M91Om-0003nI-Fs for bug-gnu-emacs@gnu.org; Tue, 26 May 2009 14:29:16 -0400 Original-Received: from rzlab.ucr.edu ([138.23.92.77]:35793) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1M91Ol-00060c-LQ for bug-gnu-emacs@gnu.org; Tue, 26 May 2009 14:29:16 -0400 Original-Received: from rzlab.ucr.edu (rzlab.ucr.edu [127.0.0.1]) by rzlab.ucr.edu (8.14.3/8.14.3/Debian-5) with ESMTP id n4QITB1e015542; Tue, 26 May 2009 11:29:12 -0700 Original-Received: (from debbugs@localhost) by rzlab.ucr.edu (8.14.3/8.14.3/Submit) id n4QIP4i8014951; Tue, 26 May 2009 11:25:04 -0700 X-Loop: owner@emacsbugs.donarmstrong.com Resent-From: David Reitter Resent-To: bug-submit-list@donarmstrong.com Resent-CC: Emacs Bugs Resent-Date: Tue, 26 May 2009 18:25:04 +0000 Resent-Message-ID: Resent-Sender: owner@emacsbugs.donarmstrong.com X-Emacs-PR-Message: followup 3303 X-Emacs-PR-Package: emacs X-Emacs-PR-Keywords: Original-Received: via spool by 3303-submit@emacsbugs.donarmstrong.com id=B3303.124336203414548 (code B ref 3303); Tue, 26 May 2009 18:25:04 +0000 Original-Received: (at 3303) by emacsbugs.donarmstrong.com; 26 May 2009 18:20:34 +0000 X-Spam-Bayes: score:0.5 Bayes not run. spammytokens:Tokens not available. hammytokens:Tokens not available. Original-Received: from smtp.andrew.cmu.edu (SMTP.ANDREW.CMU.EDU [128.2.11.61]) by rzlab.ucr.edu (8.14.3/8.14.3/Debian-5) with ESMTP id n4QIKSh5014543 for <3303@emacsbugs.donarmstrong.com>; Tue, 26 May 2009 11:20:29 -0700 Original-Received: from SCARLETT.PSY.CMU.EDU (SCARLETT.PSY.CMU.EDU [128.2.249.106]) (user=reitter mech=PLAIN (0 bits)) by smtp.andrew.cmu.edu (8.14.3/8.13.8) with ESMTP id n4QIKMPN019461 (version=TLSv1/SSLv3 cipher=AES128-SHA bits=128 verify=NOT); Tue, 26 May 2009 14:20:22 -0400 In-Reply-To: X-Mailer: Apple Mail (2.935.3) X-PMX-Version: 5.5.5.374460, Antispam-Engine: 2.7.1.369594, Antispam-Data: 2009.5.26.180435 X-SMTP-Spam-Clean: 10% ( CTYPE_MULTIPART_NO_QUOTE 0.5, BODY_SIZE_5000_5999 0, BODY_SIZE_7000_LESS 0, FROM_EDU_TLD 0, __BOUNCE_CHALLENGE_SUBJ 0, __CT 0, __CTYPE_HAS_BOUNDARY 0, __CTYPE_MULTIPART 0, __HAS_MSGID 0, __HAS_X_MAILER 0, __MIME_VERSION 0, __MSGID_APPLEMAIL 0, __SANE_MSGID 0, __TO_MALFORMED_2 0) X-SMTP-Spam-Score: 10% X-Scanned-By: MIMEDefang 2.60 on 128.2.11.61 X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6 (newer, 3) Resent-Date: Tue, 26 May 2009 14:29:20 -0400 X-BeenThere: bug-gnu-emacs@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:28198 Archived-At: --Apple-Mail-36-914333579 Content-Type: text/plain; charset=US-ASCII; format=flowed; delsp=yes Content-Transfer-Encoding: 7bit Thanks Stefan for reviewing these changes. Agreed on all of your points. I've adopted them and checked this in now since I didn't get any other feedback. >> PS.: I agree with the proposed change to after-make-frame-functions >> (not >> selecting the frame immediately), but this doesn't relate to the >> bug at >> hand. Also, I don't know why the modeline isn't updated. > > Agreed, this is a separate problem. OK, are you keeping track of it, should we file another bug report to do so? >> frame.c: >> Fraise_frame: do not make invisible frames visible (Stefan Monnier). > > This is not OK for 23.1. It might be good to try it for 23.2. > Also I think your other changes should make it unnecessary for the > problem we're trying to fix. As above. >> keyDown: do not swallow events that aren't re-sent if frame isn't >> key window. > > If you say so. What does Adrian say?? I'm just fixing the workaround, even though I don't fully understand the bug that leads to the problem. >> drawRect: do not set visibility/iconified flags because drawRect >> may be >> called by NSView even if the frame is hidden. > > Do you happen to know why/when NSView might be called even for a frame > that's not visible? Unfortunately not, but invisibility does not guarantee absence of drawRect messages unless this is promised somewhere in the NS API. I do think that my patch here is right, though, as other ports set visibility in more obvious places. Perhaps we should make sure that we don't get a lot of drawRect calls for totally obscured frames, which would possibly be a performance- eater. --Apple-Mail-36-914333579 Content-Disposition: attachment; filename=smime.p7s Content-Type: application/pkcs7-signature; name=smime.p7s Content-Transfer-Encoding: base64 MIAGCSqGSIb3DQEHAqCAMIACAQExCzAJBgUrDgMCGgUAMIAGCSqGSIb3DQEHAQAAoIIGODCCAvEw ggJaoAMCAQICEEUTODS9VcXIOFaPH+ApeTwwDQYJKoZIhvcNAQEFBQAwYjELMAkGA1UEBhMCWkEx JTAjBgNVBAoTHFRoYXd0ZSBDb25zdWx0aW5nIChQdHkpIEx0ZC4xLDAqBgNVBAMTI1RoYXd0ZSBQ ZXJzb25hbCBGcmVlbWFpbCBJc3N1aW5nIENBMB4XDTA4MDgyNzAwMzgxNloXDTA5MDgyNzAwMzgx NlowWjEQMA4GA1UEBBMHUmVpdHRlcjEOMAwGA1UEKhMFRGF2aWQxFjAUBgNVBAMTDURhdmlkIFJl aXR0ZXIxHjAcBgkqhkiG9w0BCQEWD3JlaXR0ZXJAY211LmVkdTCCASIwDQYJKoZIhvcNAQEBBQAD ggEPADCCAQoCggEBAJW3Pr3O1TOI9MTahUDKcJkkoZQOmnQVYtchDAALotmkjxNO/wC2b+CiDGGg +8TbJ/EwdMD2IOh1TilL/SXKk2txTgduV5yBrYXk04z1cGxNcCCTRiSZY1A5I3rvnP2jhUf8I49O WXFs8v8XvcJ0o1wFoPITU7b9KBLg22kl+DqNuj10fCLQldlNfe4o5PX/TWFE/NqI+//Ooehr+5hY B1XtAXQXU3/DC6M8l6Sqsm0vw5OO44K7KceG85zQchZ60LOJnGWA2UKcfNTIZGr18LUJMdl6kiU2 TEwy1H/3JAOMmekIbiQ7AWDiVYlkY6QUXBmgAPizQ81yOL3u/sUolt0CAwEAAaMsMCowGgYDVR0R BBMwEYEPcmVpdHRlckBjbXUuZWR1MAwGA1UdEwEB/wQCMAAwDQYJKoZIhvcNAQEFBQADgYEAuxCV 2UwfCwGkNBLsntGFfOObkWhvGLwol+lIdGLGBUll1A1QXdL279qMr2Nk1yR8tVgxx36z3p29itxu jRI7e5WA/devk3WIZwjK4MrWmC/TS5FAbR5PD/Q8iUXaiqQJR39kOdokEVAS3R8wYnHDSV/eQkUx OhDWpDhMbdCgtk4wggM/MIICqKADAgECAgENMA0GCSqGSIb3DQEBBQUAMIHRMQswCQYDVQQGEwJa QTEVMBMGA1UECBMMV2VzdGVybiBDYXBlMRIwEAYDVQQHEwlDYXBlIFRvd24xGjAYBgNVBAoTEVRo YXd0ZSBDb25zdWx0aW5nMSgwJgYDVQQLEx9DZXJ0aWZpY2F0aW9uIFNlcnZpY2VzIERpdmlzaW9u MSQwIgYDVQQDExtUaGF3dGUgUGVyc29uYWwgRnJlZW1haWwgQ0ExKzApBgkqhkiG9w0BCQEWHHBl cnNvbmFsLWZyZWVtYWlsQHRoYXd0ZS5jb20wHhcNMDMwNzE3MDAwMDAwWhcNMTMwNzE2MjM1OTU5 WjBiMQswCQYDVQQGEwJaQTElMCMGA1UEChMcVGhhd3RlIENvbnN1bHRpbmcgKFB0eSkgTHRkLjEs MCoGA1UEAxMjVGhhd3RlIFBlcnNvbmFsIEZyZWVtYWlsIElzc3VpbmcgQ0EwgZ8wDQYJKoZIhvcN AQEBBQADgY0AMIGJAoGBAMSmPFVzVftOucqZWh5owHUEcJ3f6f+jHuy9zfVb8hp2vX8MOmHyv1HO AdTlUAow1wJjWiyJFXCO3cnwK4Vaqj9xVsuvPAsH5/EfkTYkKhPPK9Xzgnc9A74r/rsYPge/QIAC ZNenprufZdHFKlSFD0gEf6e20TxhBEAeZBlyYLf7AgMBAAGjgZQwgZEwEgYDVR0TAQH/BAgwBgEB /wIBADBDBgNVHR8EPDA6MDigNqA0hjJodHRwOi8vY3JsLnRoYXd0ZS5jb20vVGhhd3RlUGVyc29u YWxGcmVlbWFpbENBLmNybDALBgNVHQ8EBAMCAQYwKQYDVR0RBCIwIKQeMBwxGjAYBgNVBAMTEVBy aXZhdGVMYWJlbDItMTM4MA0GCSqGSIb3DQEBBQUAA4GBAEiM0VCD6gsuzA2jZqxnD3+vrL7CF6FD lpSdf0whuPg2H6otnzYvwPQcUCCTcDz9reFhYsPZOhl+hLGZGwDFGguCdJ4lUJRix9sncVcljd2p nDmOjCBPZV+V2vf3h9bGCE6u9uo05RAaWzVNd+NWIXiC3CEZNd4ksdMdRv9dX2VPMYIDEDCCAwwC AQEwdjBiMQswCQYDVQQGEwJaQTElMCMGA1UEChMcVGhhd3RlIENvbnN1bHRpbmcgKFB0eSkgTHRk LjEsMCoGA1UEAxMjVGhhd3RlIFBlcnNvbmFsIEZyZWVtYWlsIElzc3VpbmcgQ0ECEEUTODS9VcXI OFaPH+ApeTwwCQYFKw4DAhoFAKCCAW8wGAYJKoZIhvcNAQkDMQsGCSqGSIb3DQEHATAcBgkqhkiG 9w0BCQUxDxcNMDkwNTI2MTgyMDIyWjAjBgkqhkiG9w0BCQQxFgQUJkMX6YI4pyZIUDwAdcH6+R0x ZaEwgYUGCSsGAQQBgjcQBDF4MHYwYjELMAkGA1UEBhMCWkExJTAjBgNVBAoTHFRoYXd0ZSBDb25z dWx0aW5nIChQdHkpIEx0ZC4xLDAqBgNVBAMTI1RoYXd0ZSBQZXJzb25hbCBGcmVlbWFpbCBJc3N1 aW5nIENBAhBFEzg0vVXFyDhWjx/gKXk8MIGHBgsqhkiG9w0BCRACCzF4oHYwYjELMAkGA1UEBhMC WkExJTAjBgNVBAoTHFRoYXd0ZSBDb25zdWx0aW5nIChQdHkpIEx0ZC4xLDAqBgNVBAMTI1RoYXd0 ZSBQZXJzb25hbCBGcmVlbWFpbCBJc3N1aW5nIENBAhBFEzg0vVXFyDhWjx/gKXk8MA0GCSqGSIb3 DQEBAQUABIIBAFN4SPy5iLDHpTldAf3FBA+kUIMvj4TwDSlNJoaNNi4yP7E2LhZ0ylmeKVGIhLWL Ic72seiwFZJtlnU0oflRy4gpQuP3hJFIkpgFeZ5b2UunlIWWDByKd00iHyIPpGSFLXQNWMoJ3EOw OfsP8mQxShnWP9WqkGj/2/Pt4OJ8XnpRzuiZ/ceBD3qDDovnFqX1UO8FLxVjlAmBWA1mL+Uwepuu H1SdiJZcNSDrlz5/mxGntJ9Mp3qecjOLKXdR4nx5713J71Naipy9r/CCS0awo1Zgg1aDTZgmzJX3 KlzGhGZEnRAyqPeNlNAdzlCUmJMKFZg/tiSOYEkugs5NGigvKgAAAAAAAAA= --Apple-Mail-36-914333579--