From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Paul Eggert Newsgroups: gmane.emacs.bugs Subject: bug#33731: Fwd: 26.1; cl-make-random-state copying not working Date: Wed, 19 Dec 2018 14:27:59 -0800 Organization: UCLA Computer Science Department Message-ID: <1098fd1b-37b1-b900-8cda-52396b70b837@cs.ucla.edu> References: <69b9732f-97f5-d752-c899-3bdc21cd74e8@cs.ucla.edu> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="------------D14AF6D48B9BC7112423CFF2" X-Trace: blaine.gmane.org 1545258435 9086 195.159.176.226 (19 Dec 2018 22:27:15 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Wed, 19 Dec 2018 22:27:15 +0000 (UTC) User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.3.1 To: 33731-done@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Wed Dec 19 23:27:11 2018 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gZkJ2-0002Bx-Uw for geb-bug-gnu-emacs@m.gmane.org; Wed, 19 Dec 2018 23:27:09 +0100 Original-Received: from localhost ([::1]:34444 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gZkL9-0008N1-GH for geb-bug-gnu-emacs@m.gmane.org; Wed, 19 Dec 2018 17:29:19 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:33897) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gZkL0-0008JV-7H for bug-gnu-emacs@gnu.org; Wed, 19 Dec 2018 17:29:11 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gZkKu-0003O6-EG for bug-gnu-emacs@gnu.org; Wed, 19 Dec 2018 17:29:10 -0500 Original-Received: from debbugs.gnu.org ([208.118.235.43]:50981) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1gZkKs-0003NX-Gv for bug-gnu-emacs@gnu.org; Wed, 19 Dec 2018 17:29:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1gZkKs-0005td-7A for bug-gnu-emacs@gnu.org; Wed, 19 Dec 2018 17:29:02 -0500 Resent-From: Paul Eggert Original-Sender: "Debbugs-submit" Resent-To: bug-gnu-emacs@gnu.org Resent-Date: Wed, 19 Dec 2018 22:29:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: cc-closed 33731 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Mail-Followup-To: 33731@debbugs.gnu.org, eggert@cs.ucla.edu, mail@xuchunyang.me Original-Received: via spool by 33731-done@debbugs.gnu.org id=D33731.154525848822569 (code D ref 33731); Wed, 19 Dec 2018 22:29:01 +0000 Original-Received: (at 33731-done) by debbugs.gnu.org; 19 Dec 2018 22:28:08 +0000 Original-Received: from localhost ([127.0.0.1]:55239 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gZkK0-0005rx-E9 for submit@debbugs.gnu.org; Wed, 19 Dec 2018 17:28:08 -0500 Original-Received: from zimbra.cs.ucla.edu ([131.179.128.68]:59626) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gZkJy-0005rR-C6 for 33731-done@debbugs.gnu.org; Wed, 19 Dec 2018 17:28:06 -0500 Original-Received: from localhost (localhost [127.0.0.1]) by zimbra.cs.ucla.edu (Postfix) with ESMTP id D66CF160A71 for <33731-done@debbugs.gnu.org>; Wed, 19 Dec 2018 14:28:00 -0800 (PST) Original-Received: from zimbra.cs.ucla.edu ([127.0.0.1]) by localhost (zimbra.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10032) with ESMTP id I58IrUeHveVw for <33731-done@debbugs.gnu.org>; Wed, 19 Dec 2018 14:28:00 -0800 (PST) Original-Received: from localhost (localhost [127.0.0.1]) by zimbra.cs.ucla.edu (Postfix) with ESMTP id F047D160A6F for <33731-done@debbugs.gnu.org>; Wed, 19 Dec 2018 14:27:59 -0800 (PST) X-Virus-Scanned: amavisd-new at zimbra.cs.ucla.edu Original-Received: from zimbra.cs.ucla.edu ([127.0.0.1]) by localhost (zimbra.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id SecEJ8hnd811 for <33731-done@debbugs.gnu.org>; Wed, 19 Dec 2018 14:27:59 -0800 (PST) Original-Received: from Penguin.CS.UCLA.EDU (Penguin.CS.UCLA.EDU [131.179.64.200]) by zimbra.cs.ucla.edu (Postfix) with ESMTPSA id D5DB6160942 for <33731-done@debbugs.gnu.org>; Wed, 19 Dec 2018 14:27:59 -0800 (PST) Openpgp: preference=signencrypt Autocrypt: addr=eggert@cs.ucla.edu; prefer-encrypt=mutual; keydata= xsFNBEyAcmQBEADAAyH2xoTu7ppG5D3a8FMZEon74dCvc4+q1XA2J2tBy2pwaTqfhpxxdGA9 Jj50UJ3PD4bSUEgN8tLZ0san47l5XTAFLi2456ciSl5m8sKaHlGdt9XmAAtmXqeZVIYX/UFS 96fDzf4xhEmm/y7LbYEPQdUdxu47xA5KhTYp5bltF3WYDz1Ygd7gx07Auwp7iw7eNvnoDTAl KAl8KYDZzbDNCQGEbpY3efZIvPdeI+FWQN4W+kghy+P6au6PrIIhYraeua7XDdb2LS1en3Ss mE3QjqfRqI/A2ue8JMwsvXe/WK38Ezs6x74iTaqI3AFH6ilAhDqpMnd/msSESNFt76DiO1ZK QMr9amVPknjfPmJISqdhgB1DlEdw34sROf6V8mZw0xfqT6PKE46LcFefzs0kbg4GORf8vjG2 Sf1tk5eU8MBiyN/bZ03bKNjNYMpODDQQwuP84kYLkX2wBxxMAhBxwbDVZudzxDZJ1C2VXujC OJVxq2kljBM9ETYuUGqd75AW2LXrLw6+MuIsHFAYAgRr7+KcwDgBAfwhPBYX34nSSiHlmLC+ KaHLeCLF5ZI2vKm3HEeCTtlOg7xZEONgwzL+fdKo+D6SoC8RRxJKs8a3sVfI4t6CnrQzvJbB n6gxdgCu5i29J1QCYrCYvql2UyFPAK+do99/1jOXT4m2836j1wARAQABzSBQYXVsIEVnZ2Vy dCA8ZWdnZXJ0QGNzLnVjbGEuZWR1PsLBfgQTAQIAKAUCTIByZAIbAwUJEswDAAYLCQgHAwIG FQgCCQoLBBYCAwECH X-Forwarded-Message-Id: <69b9732f-97f5-d752-c899-3bdc21cd74e8@cs.ucla.edu> In-Reply-To: <69b9732f-97f5-d752-c899-3bdc21cd74e8@cs.ucla.edu> Content-Language: en-US X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:153626 Archived-At: This is a multi-part message in MIME format. --------------D14AF6D48B9BC7112423CFF2 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Thanks for reporting this bug; it is a regression introduced when we separated records from vectors. I installed the attached patch into the emacs-26 branch. --------------D14AF6D48B9BC7112423CFF2 Content-Type: text/x-patch; name="0001-cl-make-random-state-was-not-copying-its-arg.patch" Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename="0001-cl-make-random-state-was-not-copying-its-arg.patch" >From 78c883cc1c30ab82732eac02fb07bb747436854a Mon Sep 17 00:00:00 2001 From: Paul Eggert Date: Wed, 19 Dec 2018 13:42:21 -0800 Subject: [PATCH] cl-make-random-state was not copying its arg Problem reported by Xu Chunyang (Bug#33731). * lisp/emacs-lisp/cl-extra.el (cl-make-random-state): Use copy-sequence, not copy-tree, so that the record is copied. * test/lisp/emacs-lisp/cl-extra-tests.el: (cl-extra-test-cl-make-random-state): New test. --- lisp/emacs-lisp/cl-extra.el | 2 +- test/lisp/emacs-lisp/cl-extra-tests.el | 5 +++++ 2 files changed, 6 insertions(+), 1 deletion(-) diff --git a/lisp/emacs-lisp/cl-extra.el b/lisp/emacs-lisp/cl-extra.el index 36b65f97b0..c38b4957fc 100644 --- a/lisp/emacs-lisp/cl-extra.el +++ b/lisp/emacs-lisp/cl-extra.el @@ -484,7 +484,7 @@ cl-make-random-state If STATE is t, return a new state object seeded from the time of day." (unless state (setq state cl--random-state)) (if (cl-random-state-p state) - (copy-tree state t) + (copy-sequence state) (cl--make-random-state (if (integerp state) state (cl--random-time))))) ;; Implementation limits. diff --git a/test/lisp/emacs-lisp/cl-extra-tests.el b/test/lisp/emacs-lisp/cl-extra-tests.el index baad8eb8e6..fe59703530 100644 --- a/test/lisp/emacs-lisp/cl-extra-tests.el +++ b/test/lisp/emacs-lisp/cl-extra-tests.el @@ -94,4 +94,9 @@ (should (equal (list lst3 (cdr lst3) (cddr lst3)) (cl-maplist fn3 lst lst2 lst3))))) +(ert-deftest cl-extra-test-cl-make-random-state () + (let ((s (cl-make-random-state))) + ;; Test for Bug#33731. + (should-not (eq s (cl-make-random-state s))))) + ;;; cl-extra-tests.el ends here -- 2.19.2 --------------D14AF6D48B9BC7112423CFF2--