From mboxrd@z Thu Jan 1 00:00:00 1970 Path: main.gmane.org!not-for-mail From: Andre Spiegel Newsgroups: gmane.emacs.devel Subject: Re: [patch] add interactive browse of revisions from vc *Annotate* buffers Date: Tue, 20 Jan 2004 18:58:20 +0100 Sender: emacs-devel-bounces+emacs-devel=quimby.gnus.org@gnu.org Message-ID: <1074621500.13077.151.camel@localhost> References: <1073937837.2822.180.camel@localhost> <1074519239.10692.24.camel@localhost> NNTP-Posting-Host: deer.gmane.org Mime-Version: 1.0 Content-Type: text/plain Content-Transfer-Encoding: 7bit X-Trace: sea.gmane.org 1074624366 32019 80.91.224.253 (20 Jan 2004 18:46:06 GMT) X-Complaints-To: usenet@sea.gmane.org NNTP-Posting-Date: Tue, 20 Jan 2004 18:46:06 +0000 (UTC) Cc: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+emacs-devel=quimby.gnus.org@gnu.org Tue Jan 20 19:45:55 2004 Return-path: Original-Received: from quimby.gnus.org ([80.91.224.244]) by deer.gmane.org with esmtp (Exim 3.35 #1 (Debian)) id 1Aj0st-0001Ci-00 for ; Tue, 20 Jan 2004 19:45:55 +0100 Original-Received: from monty-python.gnu.org ([199.232.76.173]) by quimby.gnus.org with esmtp (Exim 3.35 #1 (Debian)) id 1Aj0ss-0000TJ-00 for ; Tue, 20 Jan 2004 19:45:54 +0100 Original-Received: from localhost ([127.0.0.1] helo=monty-python.gnu.org) by monty-python.gnu.org with esmtp (Exim 4.24) id 1Aj0fm-00051R-De for emacs-devel@quimby.gnus.org; Tue, 20 Jan 2004 13:32:22 -0500 Original-Received: from list by monty-python.gnu.org with tmda-scanned (Exim 4.24) id 1Aj0UA-00026W-GS for emacs-devel@gnu.org; Tue, 20 Jan 2004 13:20:22 -0500 Original-Received: from mail by monty-python.gnu.org with spam-scanned (Exim 4.24) id 1Aj0Ta-00020q-Ad for emacs-devel@gnu.org; Tue, 20 Jan 2004 13:20:18 -0500 Original-Received: from [193.113.160.15] (helo=mail.o2.co.uk) by monty-python.gnu.org with esmtp (Exim 4.24) id 1Aj09e-0006yK-OO for emacs-devel@gnu.org; Tue, 20 Jan 2004 12:59:10 -0500 Original-Received: from [217.235.31.164] (217.235.31.164) by mail.o2.co.uk (7.0.020) (authenticated as 01792247376@o2online.de) id 400B412E000BF65E; Tue, 20 Jan 2004 17:58:40 +0000 Original-To: Benjamin Rutt In-Reply-To: X-Mailer: Ximian Evolution 1.4.5 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.2 Precedence: list List-Id: Emacs development discussions. List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+emacs-devel=quimby.gnus.org@gnu.org Xref: main.gmane.org gmane.emacs.devel:19359 X-Report-Spam: http://spam.gmane.org/gmane.emacs.devel:19359 On Mon, 2004-01-19 at 22:13, Benjamin Rutt wrote: > Thanks for the feedback, I've implemented your changes (I think :). Thanks for the patch. It's installed now. (I think vc-current-line is good enough right now, since there isn't a much better way to do it, we might as well stay with it. I agree with your reasoning that the current-line number seems like the best way to keep track of the current position in this case.) However, I'm getting a "Cyclic keymap inheritance" error now when I try to use one of the old items from the VC-Annotate menu (Like "Span Oldest->Newest"). Could you have a look at that?