From mboxrd@z Thu Jan 1 00:00:00 1970 Path: main.gmane.org!not-for-mail From: Andre Spiegel Newsgroups: gmane.emacs.devel Subject: Re: [patch] add interactive browse of revisions from vc *Annotate* buffers Date: Mon, 12 Jan 2004 21:09:09 +0100 Sender: emacs-devel-bounces+emacs-devel=quimby.gnus.org@gnu.org Message-ID: <1073937837.2822.180.camel@localhost> References: NNTP-Posting-Host: deer.gmane.org Mime-Version: 1.0 Content-Type: text/plain Content-Transfer-Encoding: 7bit X-Trace: sea.gmane.org 1073938439 3085 80.91.224.253 (12 Jan 2004 20:13:59 GMT) X-Complaints-To: usenet@sea.gmane.org NNTP-Posting-Date: Mon, 12 Jan 2004 20:13:59 +0000 (UTC) Cc: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+emacs-devel=quimby.gnus.org@gnu.org Mon Jan 12 21:13:49 2004 Return-path: Original-Received: from quimby.gnus.org ([80.91.224.244]) by deer.gmane.org with esmtp (Exim 3.35 #1 (Debian)) id 1Ag8RZ-0005w6-00 for ; Mon, 12 Jan 2004 21:13:49 +0100 Original-Received: from monty-python.gnu.org ([199.232.76.173]) by quimby.gnus.org with esmtp (Exim 3.35 #1 (Debian)) id 1Ag8RZ-0002jI-00 for ; Mon, 12 Jan 2004 21:13:49 +0100 Original-Received: from localhost ([127.0.0.1] helo=monty-python.gnu.org) by monty-python.gnu.org with esmtp (Exim 4.24) id 1Ag9LF-0005zK-DG for emacs-devel@quimby.gnus.org; Mon, 12 Jan 2004 16:11:21 -0500 Original-Received: from list by monty-python.gnu.org with tmda-scanned (Exim 4.24) id 1Ag9L8-0005yI-Rs for emacs-devel@gnu.org; Mon, 12 Jan 2004 16:11:14 -0500 Original-Received: from mail by monty-python.gnu.org with spam-scanned (Exim 4.24) id 1Ag9Kc-0005oq-FD for emacs-devel@gnu.org; Mon, 12 Jan 2004 16:11:13 -0500 Original-Received: from [193.113.160.15] (helo=mail.o2.co.uk) by monty-python.gnu.org with esmtp (Exim 4.24) id 1Ag9Kc-0005oU-2M for emacs-devel@gnu.org; Mon, 12 Jan 2004 16:10:42 -0500 Original-Received: from dialin-145-254-066-038.arcor-ip.net (145.254.66.38) by mail.o2.co.uk (7.0.020) (authenticated as 01792247376@o2online.de) id 3FF2A9F80049B576; Mon, 12 Jan 2004 20:09:17 +0000 Original-To: Benjamin Rutt In-Reply-To: X-Mailer: Ximian Evolution 1.4.5 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.2 Precedence: list List-Id: Emacs development discussions. List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+emacs-devel=quimby.gnus.org@gnu.org Xref: main.gmane.org gmane.emacs.devel:19149 X-Report-Spam: http://spam.gmane.org/gmane.emacs.devel:19149 I like the features you (Benjamin) are suggesting but the keybindings seem a bit problematic to me. Since those features would be very important in VC Annotate, I wonder if you couldn't use simpler bindings. Ideally, I'd put the annotate buffer in view mode and use "p" and "n" for previous and next, but these are already bound to View-search-last-regexp-backward/forward. Do people think it's justified to replace that binding in vc-annotate-mode? I would think the relative importance justifies it. To annotate from the revision _before_ the one on the current line (which I feel is the most important of those new features), "f" could be used (similar to Dired), without any clash in view mode. I know this has the potential to become an endless discussion, but perhaps we can just go through one iteration and then decide :-)