From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Mattias =?UTF-8?Q?Engdeg=C3=A5rd?= Newsgroups: gmane.emacs.bugs Subject: bug#59426: 29.0.50; [tree-sitter] Some functions exceed maximum recursion limit Date: Thu, 24 Nov 2022 11:24:19 +0100 Message-ID: <104387C6-BF9A-4243-AD64-1ADCC25CBBA0@acm.org> References: <87wn7o6c9c.fsf@yahoo.com> <701BF611-6506-403E-B70B-2D93F3339E0C@acm.org> <83v8n82yzl.fsf@gnu.org> <83fsec2qq3.fsf@gnu.org> <83edtw2pz3.fsf@gnu.org> <835yf82oc4.fsf@gnu.org> <942C72E7-3DA9-4E2B-8B40-137B8FB23473@acm.org> <04236EB0-122B-41D0-B696-CC2EFA4B6A93@gmail.com> <6822E77F-3094-4E73-A7E7-EF5C096FC08F@acm.org> Mime-Version: 1.0 (Mac OS X Mail 14.0 \(3654.120.0.1.13\)) Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="11452"; mail-complaints-to="usenet@ciao.gmane.io" Cc: Po Lu , 59426@debbugs.gnu.org, Eli Zaretskii , Stefan Kangas To: Yuan Fu Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu Nov 24 11:25:36 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oy9QG-0002jt-AK for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 24 Nov 2022 11:25:36 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oy9Pq-0006YD-Gb; Thu, 24 Nov 2022 05:25:10 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oy9Pj-0006Xa-2V for bug-gnu-emacs@gnu.org; Thu, 24 Nov 2022 05:25:03 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1oy9Pi-0005El-Jl for bug-gnu-emacs@gnu.org; Thu, 24 Nov 2022 05:25:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1oy9Pi-0006F2-F2 for bug-gnu-emacs@gnu.org; Thu, 24 Nov 2022 05:25:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Mattias =?UTF-8?Q?Engdeg=C3=A5rd?= Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 24 Nov 2022 10:25:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 59426 X-GNU-PR-Package: emacs Original-Received: via spool by 59426-submit@debbugs.gnu.org id=B59426.166928546923941 (code B ref 59426); Thu, 24 Nov 2022 10:25:02 +0000 Original-Received: (at 59426) by debbugs.gnu.org; 24 Nov 2022 10:24:29 +0000 Original-Received: from localhost ([127.0.0.1]:57364 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oy9PA-0006E3-Qw for submit@debbugs.gnu.org; Thu, 24 Nov 2022 05:24:29 -0500 Original-Received: from mail74c50.megamailservers.eu ([91.136.10.84]:53728 helo=mail92c50.megamailservers.eu) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oy9P8-0006Du-Pe for 59426@debbugs.gnu.org; Thu, 24 Nov 2022 05:24:28 -0500 X-Authenticated-User: mattiase@bredband.net DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=megamailservers.eu; s=maildub; t=1669285464; bh=AHtuVvanlIOoXtqGzLpTOOaoLkrDPSlR9RVh8lMFwg0=; h=Subject:From:In-Reply-To:Date:Cc:References:To:From; b=OYn9WWDdX13MXq97j3i2FWxsc62rxKQL4g2qFRDXz09Zwmni3ZTeevENEbkgwBdtM 1xVjkG0fD/Y04fi3K6aKfVeHfyUsUy18OI02pHkj/Yl5NmhEjIfmBoJ4dYeDq5KYPW TEnhfdY7imfVN2GOozSI6yIUqdiqht7G95gcu8vw= Feedback-ID: mattiase@acm.or Original-Received: from smtpclient.apple (c188-150-171-209.bredband.tele2.se [188.150.171.209]) (authenticated bits=0) by mail92c50.megamailservers.eu (8.14.9/8.13.1) with ESMTP id 2AOAOKD0051132; Thu, 24 Nov 2022 10:24:22 +0000 In-Reply-To: X-Mailer: Apple Mail (2.3654.120.0.1.13) X-CTCH-RefID: str=0001.0A782F24.637F4658.005B, ss=1, re=0.000, recu=0.000, reip=0.000, cl=1, cld=1, fgs=0 X-CTCH-VOD: Unknown X-CTCH-Spam: Unknown X-CTCH-Score: 0.000 X-CTCH-Flags: 0 X-CTCH-ScoreCust: 0.000 X-Origin-Country: SE X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:248843 Archived-At: 24 nov. 2022 kl. 10.17 skrev Yuan Fu : > Does it worth the complexity tho? We only need a stack if we want to = support this scenario, in which case tree-sitter has a wrong parse tree. = Instead of spending the time and resource to go down that deep tree, = it=E2=80=99s better to fail early, and let the user decide to either = give up on weird files, or try some other approximation. >=20 > It=E2=80=99s too early to tell if being able to go down arbitrarily = deep into a deep tree is useful. The only use of traversing the whole = tree right now is to generate the imenu indexes, which don=E2=80=99t = really need to go down more than 10 levels, since most defun nodes we = are interested in are either top-level or near top-level. You may very well be right about that. > So I=E2=80=99d prefer we keep it simple and have a hard limit for now. = If we later find that a stack is favorable we can always add it in. That sounds good. Maybe the #line snag in the packet-rrc.c example = should be reported upstream?