all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: "Mattias Engdegård" <mattiase@acm.org>
To: Yuan Fu <casouri@gmail.com>
Cc: Po Lu <luangruo@yahoo.com>,
	59426@debbugs.gnu.org, Eli Zaretskii <eliz@gnu.org>,
	Stefan Kangas <stefankangas@gmail.com>
Subject: bug#59426: 29.0.50; [tree-sitter] Some functions exceed maximum recursion limit
Date: Thu, 24 Nov 2022 11:24:19 +0100	[thread overview]
Message-ID: <104387C6-BF9A-4243-AD64-1ADCC25CBBA0@acm.org> (raw)
In-Reply-To: <B74EC69F-7ACC-4A1D-A4AA-F724E5C244FA@gmail.com>

24 nov. 2022 kl. 10.17 skrev Yuan Fu <casouri@gmail.com>:

> Does it worth the complexity tho? We only need a stack if we want to support this scenario, in which case tree-sitter has a wrong parse tree. Instead of spending the time and resource to go down that deep tree, it’s better to fail early, and let the user decide to either give up on weird files, or try some other approximation.
> 
> It’s too early to tell if being able to go down arbitrarily deep into a deep tree is useful. The only use of traversing the whole tree right now is to generate the imenu indexes, which don’t really need to go down more than 10 levels, since most defun nodes we are interested in are either top-level or near top-level.

You may very well be right about that.

> So I’d prefer we keep it simple and have a hard limit for now. If we later find that a stack is favorable we can always add it in.

That sounds good. Maybe the #line snag in the packet-rrc.c example should be reported upstream?






  reply	other threads:[~2022-11-24 10:24 UTC|newest]

Thread overview: 34+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-11-21  0:53 bug#59426: 29.0.50; [tree-sitter] Some functions exceed maximum recursion limit Yuan Fu
2022-11-21  6:40 ` Po Lu via Bug reports for GNU Emacs, the Swiss army knife of text editors
2022-11-21  7:38   ` Stefan Kangas
2022-11-21 12:00     ` Mattias Engdegård
2022-11-21 13:55       ` Eli Zaretskii
2022-11-21 14:46         ` Mattias Engdegård
2022-11-21 16:43           ` Yuan Fu
2022-11-21 16:54             ` Eli Zaretskii
2022-11-21 17:10               ` Eli Zaretskii
2022-11-21 17:45                 ` Eli Zaretskii
2022-11-21 18:20                   ` Mattias Engdegård
2022-11-21 18:26                     ` Eli Zaretskii
2022-11-21 18:59                       ` Mattias Engdegård
2022-11-21 19:00                     ` Yuan Fu
2022-11-22  9:08                       ` Mattias Engdegård
2022-11-22 23:19                         ` Yuan Fu
2022-11-23 10:40                           ` Mattias Engdegård
2022-11-23 18:46                             ` Yuan Fu
2022-11-23 20:01                               ` Mattias Engdegård
2022-11-24  9:17                                 ` Yuan Fu
2022-11-24 10:24                                   ` Mattias Engdegård [this message]
2022-11-24 19:25                                     ` Yuan Fu
2022-11-24 19:28                                       ` Eli Zaretskii
2022-11-27  2:36                                         ` Yuan Fu
2022-11-24 10:24                                   ` Eli Zaretskii
2022-11-21 16:56             ` Mattias Engdegård
2022-11-21 17:01               ` Yuan Fu
2022-11-21 17:44               ` Eli Zaretskii
2022-11-22  1:46             ` Stefan Kangas
2022-11-22  0:27       ` Po Lu via Bug reports for GNU Emacs, the Swiss army knife of text editors
2022-11-22  8:59         ` Mattias Engdegård
2022-11-21 13:19 ` Eli Zaretskii
2022-11-21 16:52   ` Yuan Fu
2022-11-21 17:16     ` Eli Zaretskii

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=104387C6-BF9A-4243-AD64-1ADCC25CBBA0@acm.org \
    --to=mattiase@acm.org \
    --cc=59426@debbugs.gnu.org \
    --cc=casouri@gmail.com \
    --cc=eliz@gnu.org \
    --cc=luangruo@yahoo.com \
    --cc=stefankangas@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.