From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Bill Wohler Newsgroups: gmane.emacs.devel,gmane.mail.mh-e.devel Subject: Re: mh-e/mh-acros.el advices `require' incorrectly Date: Fri, 13 Jan 2006 17:39:59 -0800 Organization: Newt Software Message-ID: <10231.1137202799@olgas.newt.com> References: <837.1137190309@olgas.newt.com> NNTP-Posting-Host: main.gmane.org X-Trace: sea.gmane.org 1137202832 9815 80.91.229.2 (14 Jan 2006 01:40:32 GMT) X-Complaints-To: usenet@sea.gmane.org NNTP-Posting-Date: Sat, 14 Jan 2006 01:40:32 +0000 (UTC) Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sat Jan 14 02:40:29 2006 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by ciao.gmane.org with esmtp (Exim 4.43) id 1ExaP2-0000xo-N4 for ged-emacs-devel@m.gmane.org; Sat, 14 Jan 2006 02:40:26 +0100 Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1ExaRC-00022t-ID for ged-emacs-devel@m.gmane.org; Fri, 13 Jan 2006 20:42:38 -0500 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1ExaQx-00022k-AW for emacs-devel@gnu.org; Fri, 13 Jan 2006 20:42:23 -0500 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1ExaQv-00022H-HR for emacs-devel@gnu.org; Fri, 13 Jan 2006 20:42:22 -0500 Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1ExaQv-00022A-7H for emacs-devel@gnu.org; Fri, 13 Jan 2006 20:42:21 -0500 Original-Received: from [69.93.192.76] (helo=tassie.newt.com) by monty-python.gnu.org with esmtp (Exim 4.34) id 1ExaTz-0000Yj-NH for emacs-devel@gnu.org; Fri, 13 Jan 2006 20:45:32 -0500 Original-Received: from olgas.newt.com (m110e36d0.tmodns.net [208.54.14.17]) by tassie.newt.com (Postfix) with ESMTP id 2B7CC2D4012; Fri, 13 Jan 2006 17:40:06 -0800 (PST) Original-Received: by olgas.newt.com (Postfix, from userid 1000) id AE0A516FD9; Fri, 13 Jan 2006 17:39:59 -0800 (PST) Original-Received: from olgas.newt.com (localhost [127.0.0.1]) by olgas.newt.com (Postfix) with ESMTP id AAA6916FA9; Fri, 13 Jan 2006 17:39:59 -0800 (PST) Original-To: emacs-devel@gnu.org, mh-e-devel@lists.sourceforge.net In-Reply-To: Satyaki Das's message of Fri, 13 Jan 2006 15:36:51 PST. X-Mailer: MH-E 7.85+cvs; nmh 1.1; GNU Emacs 22.0.50.1 X-Image-URL: http://www.newt.com/wohler/images/bill-diving.png Mail-Followup-To: emacs-devel@gnu.org, mh-e-devel@lists.sourceforge.net X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:49053 gmane.mail.mh-e.devel:11277 Archived-At: Satyaki Das wrote: > On 1/13/06, Bill Wohler wrote: > > Drew Adams wrote: > > > > > > The origianl `require' returns FEATURE even if it is already > > > > provided, but the adviced `require' returns nil in such a > > > > case. So, once mh-acros.el is loaded, a code depending on > > > > the return value of `require' stops working. > > > > > > > > How about this change? > > > > > > What do you (and others) think about this? > > > > > > Besides the fact that we shouldn't use defadvice in vanilla Emacs code, I > > > don't think we should change the return value of `require' at all. It has > > > acted this way for a very long time, and there is undoubtedly code that > > > depends on this behavior (at least some external libraries). Besides, we > > > certainly should not make such a change just before a release. > > > > Unless you load MH-E, require does not change. > > Even if you load MH-E, require isn't adviced since mh-acros.el is > never loaded at run time unless you load it yourself. > > > If I understand > > correctly, Kanichi's patch addresses your concern (about the return > > value of require changing). Here's the ChangeLog for that change: > > Kenichi's patch won't cause any problems for MH-E. This means you can check in your patch, Kenichi ;-). Thanks very much for the explanation, Satyaki. -- Bill Wohler http://www.newt.com/wohler/ GnuPG ID:610BD9AD Maintainer of comp.mail.mh FAQ and MH-E. Vote Libertarian! If you're passed on the right, you're in the wrong lane.