NT Emacs mouse-wheel code broken in keyboard.c

NT Emacs mouse-wheel code broken in keyboard.c

[David PONCE]

Hi All,

Following this change:

2002-08-03  Andrew Choi  <akochoi@shaw.ca>

 * keyboard.c: Define Qmouse_wheel, mouse_wheel_syms, and
   lispy_mouse_wheel_names for MAC_OSX as well as for WINDOWS_NT.
   (kbd_buffer_get_event): Set used_mouse_menu for MENU_BAR_EVENT and
   TOOL_BAR_EVENT for MAC_OS as well.
   (make_lispy_event): Handle MOUSE_WHEEL_EVENT for MAC_OSX as well
   as for WINDOWS_NT.
   (syms_of_keyboard): Initialize Qmouse_wheel for MAC_OSX.

Emacs abort when using wheel mouse on Windows NT.

This happens because of a typo in keyboard.c where an #ifdef uses the
symbol WINDOWS_NT instead of WINDOWSNT.  The following very small
patch fixes the problem :-)

*** keyboard.c.ori	Sun Aug  4 15:49:51 2002
--- keyboard.c	Tue Aug  6 14:12:21 2002
***************
*** 5281,5288 ****
  			       Qnil));
  	}
        }
! #endif /* WINDOWS_NT */
! #if defined(WINDOWS_NT) || defined(MAC_OSX)
      case MOUSE_WHEEL_EVENT:
        {
  	int part;
--- 5281,5288 ----
  			       Qnil));
  	}
        }
! #endif /* WINDOWSNT */
! #if defined(WINDOWSNT) || defined(MAC_OSX)
      case MOUSE_WHEEL_EVENT:
        {
  	int part;


Sincerely,
David


In GNU Emacs 21.3.50.1 (i386-mingw-nt4.0.1381)
 of 2002-08-06 on EBAT311
configured using `configure --with-gcc (2.95)'

Important settings:
  value of $LC_ALL: nil
  value of $LC_COLLATE: nil
  value of $LC_CTYPE: nil
  value of $LC_MESSAGES: nil
  value of $LC_MONETARY: nil
  value of $LC_NUMERIC: nil
  value of $LC_TIME: nil
  value of $LANG: ENU
  locale-coding-system: iso-latin-1
  default-enable-multibyte-characters: t

Re: NT Emacs mouse-wheel code broken in keyboard.c

[Tak Ota]

Why doesn't someone check this in please?

-Tak

Tue, 06 Aug 2002 15:25:42 +0200 (MET DST): "David PONCE" <David.Ponce@wanadoo.fr> wrote:

> Hi All,
> 
> Following this change:
> 
> 2002-08-03  Andrew Choi  <akochoi@shaw.ca>
> 
>  * keyboard.c: Define Qmouse_wheel, mouse_wheel_syms, and
>    lispy_mouse_wheel_names for MAC_OSX as well as for WINDOWS_NT.
>    (kbd_buffer_get_event): Set used_mouse_menu for MENU_BAR_EVENT and
>    TOOL_BAR_EVENT for MAC_OS as well.
>    (make_lispy_event): Handle MOUSE_WHEEL_EVENT for MAC_OSX as well
>    as for WINDOWS_NT.
>    (syms_of_keyboard): Initialize Qmouse_wheel for MAC_OSX.
> 
> Emacs abort when using wheel mouse on Windows NT.
> 
> This happens because of a typo in keyboard.c where an #ifdef uses the
> symbol WINDOWS_NT instead of WINDOWSNT.  The following very small
> patch fixes the problem :-)
> 
> *** keyboard.c.ori	Sun Aug  4 15:49:51 2002
> --- keyboard.c	Tue Aug  6 14:12:21 2002
> ***************
> *** 5281,5288 ****
>   			       Qnil));
>   	}
>         }
> ! #endif /* WINDOWS_NT */
> ! #if defined(WINDOWS_NT) || defined(MAC_OSX)
>       case MOUSE_WHEEL_EVENT:
>         {
>   	int part;
> --- 5281,5288 ----
>   			       Qnil));
>   	}
>         }
> ! #endif /* WINDOWSNT */
> ! #if defined(WINDOWSNT) || defined(MAC_OSX)
>       case MOUSE_WHEEL_EVENT:
>         {
>   	int part;
> 
> 
> Sincerely,
> David
> 
> 
> In GNU Emacs 21.3.50.1 (i386-mingw-nt4.0.1381)
>  of 2002-08-06 on EBAT311
> configured using `configure --with-gcc (2.95)'
> 
> Important settings:
>   value of $LC_ALL: nil
>   value of $LC_COLLATE: nil
>   value of $LC_CTYPE: nil
>   value of $LC_MESSAGES: nil
>   value of $LC_MONETARY: nil
>   value of $LC_NUMERIC: nil
>   value of $LC_TIME: nil
>   value of $LANG: ENU
>   locale-coding-system: iso-latin-1
>   default-enable-multibyte-characters: t
> 
> 
> 
> _______________________________________________
> Emacs-devel mailing list
> Emacs-devel@gnu.org
> http://mail.gnu.org/mailman/listinfo/emacs-devel

Re: NT Emacs mouse-wheel code broken in keyboard.c

[Richard Stallman]

I checked in that change.  Thanks.