From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Konstantin Reich Newsgroups: gmane.emacs.bugs Subject: bug#28118: 25.1; input-method-deactivate-hook works twice because of backward compatibility Date: Fri, 18 Aug 2017 06:36:47 +0300 Message-ID: <100131503027407@web38g.yandex.ru> References: <162771502942864@web2j.yandex.ru> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain Content-Transfer-Encoding: 7bit X-Trace: blaine.gmane.org 1503027433 18695 195.159.176.226 (18 Aug 2017 03:37:13 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Fri, 18 Aug 2017 03:37:13 +0000 (UTC) To: 28118@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Fri Aug 18 05:37:09 2017 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1diY5s-0004cg-2m for geb-bug-gnu-emacs@m.gmane.org; Fri, 18 Aug 2017 05:37:08 +0200 Original-Received: from localhost ([::1]:48415 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1diY5y-0006MB-OJ for geb-bug-gnu-emacs@m.gmane.org; Thu, 17 Aug 2017 23:37:14 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:32995) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1diY5p-0006Kc-BM for bug-gnu-emacs@gnu.org; Thu, 17 Aug 2017 23:37:06 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1diY5m-0004FF-7u for bug-gnu-emacs@gnu.org; Thu, 17 Aug 2017 23:37:05 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:34701) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1diY5m-0004Eb-1E for bug-gnu-emacs@gnu.org; Thu, 17 Aug 2017 23:37:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1diY5l-0004Zp-Ox for bug-gnu-emacs@gnu.org; Thu, 17 Aug 2017 23:37:01 -0400 X-Loop: help-debbugs@gnu.org In-Reply-To: <162771502942864@web2j.yandex.ru> Resent-From: Konstantin Reich Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 18 Aug 2017 03:37:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 28118 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 28118-submit@debbugs.gnu.org id=B28118.150302741617578 (code B ref 28118); Fri, 18 Aug 2017 03:37:01 +0000 Original-Received: (at 28118) by debbugs.gnu.org; 18 Aug 2017 03:36:56 +0000 Original-Received: from localhost ([127.0.0.1]:43382 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1diY5f-0004ZQ-PU for submit@debbugs.gnu.org; Thu, 17 Aug 2017 23:36:55 -0400 Original-Received: from forward104j.mail.yandex.net ([5.45.198.247]:56905) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1diY5e-0004ZE-2q for 28118@debbugs.gnu.org; Thu, 17 Aug 2017 23:36:54 -0400 Original-Received: from mxback12g.mail.yandex.net (mxback12g.mail.yandex.net [IPv6:2a02:6b8:0:1472:2741:0:8b7:91]) by forward104j.mail.yandex.net (Yandex) with ESMTP id E6049443E2 for <28118@debbugs.gnu.org>; Fri, 18 Aug 2017 06:36:47 +0300 (MSK) Original-Received: from web38g.yandex.ru (web38g.yandex.ru [95.108.252.208]) by mxback12g.mail.yandex.net (nwsmtp/Yandex) with ESMTP id F37XqNUID7-allaiZ99; Fri, 18 Aug 2017 06:36:47 +0300 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yandex.ru; s=mail; t=1503027407; bh=i3/4YbogOcuNm3qqOp3rwVr2i2y8Hwp6tKIgJfJPNys=; h=From:To:Subject:Message-Id:Date; b=vdd6NvM5NWd3R+JUvUr+ymlutTKMIlBtYW+FZURZ0CMQW+7k9EE0i4boRfWwnVokD aosIlW2RCVI8PohTp+ooN1o4BdkO3bnK8yk3kLqkVsrLCB3Awi9Ri7XzMimhxPxsLe eplJeuMqaUZUg4Daox/RYK3785u7QHhs73zuhg8o= Authentication-Results: mxback12g.mail.yandex.net; dkim=pass header.i=@yandex.ru Original-Received: by web38g.yandex.ru with HTTP; Fri, 18 Aug 2017 06:36:47 +0300 Envelope-From: reich-cv@yandex.ru X-Mailer: Yamail [ http://yandex.ru ] 5.0 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:135890 Archived-At: I think the following patch solves the problem. --- emacs-25.2/lisp/international/mule-cmds.el.orig 2017-02-03 04:25:44.000000000 -0600 +++ emacs-25.2/lisp/international/mule-cmds.el 2017-08-17 22:24:38.750733577 -0500 @@ -1483,7 +1483,6 @@ system (if it corresponds to a MIME char (funcall deactivate-current-input-method-function)) (unwind-protect (run-hooks - 'input-method-inactivate-hook ; for backward compatibility 'input-method-deactivate-hook) (setq current-input-method nil) (force-mode-line-update))))) The problem is that the function deactivate-input-method in the file mule-cmds run two hooks:input-method-inactivate-hook and input-method-deactivate-hook. But they are identical: (define-obsolete-function-alias 'inactivate-input-method 'deactivate-input-method "24.3") So one hook should be removed.