bug#28118: 25.1; input-method-deactivate-hook works twice because of backward compatibility

bug#28118: 25.1; input-method-deactivate-hook works twice because of backward compatibility

[Рейх Константин]

Hi,

I noticed that when i add hook to input-method-deactivate-hook i also
add hook to input-method-inactivate-hook. As a result  the hook in
input-method-deactivate-hook works twice, which should not be the case.

This can be seen from the code in function deactivate-input-method in international/mule-cmds.el:
....
 (run-hooks
	   'input-method-inactivate-hook ; for backward compatibility
	   'input-method-deactivate-hook)
.....

For example
(add-hook 'input-method-deactivate-hook '(lambda () (message
"b") ))

produces "b [2 times]" with deactivation of the input method. 


All version of emacs from 24.3 are affected.

bug#28118: 25.1; input-method-deactivate-hook works twice because of backward compatibility

[Konstantin Reich]

I think the following patch solves the problem.

--- emacs-25.2/lisp/international/mule-cmds.el.orig   2017-02-03 04:25:44.000000000 -0600
+++ emacs-25.2/lisp/international/mule-cmds.el       2017-08-17 22:24:38.750733577 -0500
@@ -1483,7 +1483,6 @@ system (if it corresponds to a MIME char
          (funcall deactivate-current-input-method-function))
       (unwind-protect
          (run-hooks
-          'input-method-inactivate-hook ; for backward compatibility
           'input-method-deactivate-hook)
        (setq current-input-method nil)
        (force-mode-line-update)))))

The problem is that the function deactivate-input-method in the file mule-cmds run two hooks:input-method-inactivate-hook and input-method-deactivate-hook. But they are identical:

(define-obsolete-function-alias
  'inactivate-input-method
  'deactivate-input-method "24.3")


So one hook should be removed.

bug#28118: 25.1; input-method-deactivate-hook works twice because of backward compatibility

[Eli Zaretskii]

> From: Konstantin Reich <reich-cv@yandex.ru>
> Date: Fri, 18 Aug 2017 06:36:47 +0300
> 
> I think the following patch solves the problem.

Indeed, but there were several other instances of the same bug.  Now
fixed on the master branch.

Thanks.