From: Konstantin Reich <reich-cv@yandex.ru>
To: 28118@debbugs.gnu.org
Subject: bug#28118: 25.1; input-method-deactivate-hook works twice because of backward compatibility
Date: Fri, 18 Aug 2017 06:36:47 +0300 [thread overview]
Message-ID: <100131503027407@web38g.yandex.ru> (raw)
In-Reply-To: <162771502942864@web2j.yandex.ru>
I think the following patch solves the problem.
--- emacs-25.2/lisp/international/mule-cmds.el.orig 2017-02-03 04:25:44.000000000 -0600
+++ emacs-25.2/lisp/international/mule-cmds.el 2017-08-17 22:24:38.750733577 -0500
@@ -1483,7 +1483,6 @@ system (if it corresponds to a MIME char
(funcall deactivate-current-input-method-function))
(unwind-protect
(run-hooks
- 'input-method-inactivate-hook ; for backward compatibility
'input-method-deactivate-hook)
(setq current-input-method nil)
(force-mode-line-update)))))
The problem is that the function deactivate-input-method in the file mule-cmds run two hooks:input-method-inactivate-hook and input-method-deactivate-hook. But they are identical:
(define-obsolete-function-alias
'inactivate-input-method
'deactivate-input-method "24.3")
So one hook should be removed.
next prev parent reply other threads:[~2017-08-18 3:36 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-17 4:07 bug#28118: 25.1; input-method-deactivate-hook works twice because of backward compatibility Рейх Константин
2017-08-18 3:36 ` Konstantin Reich [this message]
2017-08-18 9:34 ` Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=100131503027407@web38g.yandex.ru \
--to=reich-cv@yandex.ru \
--cc=28118@debbugs.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.